[v3,00/17] Updates for turris-mox-rwtm driver

Message

Marek Behún June 17, 2024, 2:45 p.m. UTC

Hi Gregory, Arnd, Andy et al.

this is v3 of series of fixes, refactors and cleanups for the
turris-mox-rwtm driver.

v1 and v2 can be found at:
  https://patchwork.kernel.org/project/linux-soc/list/?series=861215
  https://patchwork.kernel.org/project/linux-soc/list/?series=861716

Changes since v2:
- use SZ_4K instead of PAGE_SIZE for size of dma buffer
- other small fixes that Andy suggested, like:
  - use if(ret) instead of if(ret<0) if return value can't be positive
  - use max() from minmax.h
  - removed check for -EPROFE_DEFER, it is done by dev_err_probe()
    internally
  - ...

Marek

Marek Behún (17):
  firmware: turris-mox-rwtm: Do not complete if there are no waiters
  firmware: turris-mox-rwtm: Fix checking return value of
    wait_for_completion_timeout()
  firmware: turris-mox-rwtm: Use macro constant instead of hardcoded
    4096
  firmware: turris-mox-rwtm: Use ETH_ALEN instead of hardcoded 6
  firmware: turris-mox-rwtm: Use the boolean type where appropriate
  firmware: turris-mox-rwtm: Hide signature related constants behind
    macros
  firmware: turris-mox-rwtm: Fix driver includes
  firmware: turris-mox-rwtm: Don't create own kobject type
  firmware: turris-mox-rwtm: Simplify debugfs code
  firmware: turris-mox-rwtm: Convert rest to devm_* and get rid of
    driver .remove()
  firmware: turris-mox-rwtm: Use dev_err_probe() where possible
  firmware: turris-mox-rwtm: Initialize completion before mailbox
  firmware: turris-mox-rwtm: Drop redundant device pointer
  firmware: turris-mox-rwtm: Use devm_mutex_init() instead of
    mutex_init()
  firmware: turris-mox-rwtm: Use container_of() instead of hwrng .priv
    member
  firmware: turris-mox-rwtm: Use EOPNOTSUPP instead of ENOSYS
  firmware: turris-mox-rwtm: Deduplicate command execution code

 drivers/firmware/turris-mox-rwtm.c | 384 ++++++++++++-----------------
 1 file changed, 155 insertions(+), 229 deletions(-)

Comments

Andy Shevchenko June 17, 2024, 8:31 p.m. UTC | #1

On Mon, Jun 17, 2024 at 4:45 PM Marek Behún <[e-mail]> wrote:
>
> Hi Gregory, Arnd, Andy et al.
>
> this is v3 of series of fixes, refactors and cleanups for the
> turris-mox-rwtm driver.

As far as I'm concerned this looks good enough to proceed.
FWIW,
Reviewed-by: Andy Shevchenko <[e-mail]>

In case of a new version, please address a few nit-picks.