| Message ID | 20240715104723.17751-1-kabel@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Updates for turris-mox-rwtm driver | expand |
On Mon, Jul 15, 2024, at 12:47, Marek Behún wrote: > Hi Arnd, Andy, Gregory et al. > > this is v4 of series of fixes, refactors and cleanups for the > turris-mox-rwtm driver. > > Changes since v3: > - addressed Andy's recommendations. Some of them resulted in 2 new > patches (08/19 and 18/19). Im patch 10/19 I did not address Andy's > comment > "Actually you may do that without devm. There is a lookup method > or so in debugfs APIs that can be used. Can be amended later on, > though." > since I do not see how to use the debugfs_lookup_and_remove() > function without devm and get rid of the driver's .remove() method > at the same time... > Hi Marek, The 6.11 merge window is now open, so I am not applying the cleanup and refactoring patches for this release. Can you separate the two and resend just the bugfixes so I can apply them into a branch for 6.11-rc1? After -rc1 is out with those fixes, please rebase the rest and send that got inclusion in 6.12. Arnd
Hello: This series was applied to soc/soc.git (arm/fixes) by Arnd Bergmann <arnd@arndb.de>: On Mon, 15 Jul 2024 12:47:04 +0200 you wrote: > Hi Arnd, Andy, Gregory et al. > > this is v4 of series of fixes, refactors and cleanups for the > turris-mox-rwtm driver. > > Changes since v3: > - addressed Andy's recommendations. Some of them resulted in 2 new > patches (08/19 and 18/19). Im patch 10/19 I did not address Andy's > comment > "Actually you may do that without devm. There is a lookup method > or so in debugfs APIs that can be used. Can be amended later on, > though." > since I do not see how to use the debugfs_lookup_and_remove() > function without devm and get rid of the driver's .remove() method > at the same time... > > [...] Here is the summary with links: - [v4,01/19] firmware: turris-mox-rwtm: Do not complete if there are no waiters https://git.kernel.org/soc/soc/c/0bafb172b111 - [v4,02/19] firmware: turris-mox-rwtm: Fix checking return value of wait_for_completion_timeout() https://git.kernel.org/soc/soc/c/8467cfe821ac - [v4,03/19] firmware: turris-mox-rwtm: Use macro constant instead of hardcoded 4096 (no matching commit) - [v4,04/19] firmware: turris-mox-rwtm: Use ETH_ALEN instead of hardcoded 6 (no matching commit) - [v4,05/19] firmware: turris-mox-rwtm: Use the boolean type where appropriate (no matching commit) - [v4,06/19] firmware: turris-mox-rwtm: Hide signature related constants behind macros (no matching commit) - [v4,07/19] firmware: turris-mox-rwtm: Fix driver includes (no matching commit) - [v4,08/19] firmware: turris-mox-rwtm: Use sysfs_emit() instead of sprintf() (no matching commit) - [v4,09/19] firmware: turris-mox-rwtm: Don't create own kobject type (no matching commit) - [v4,10/19] firmware: turris-mox-rwtm: Simplify debugfs code (no matching commit) - [v4,11/19] firmware: turris-mox-rwtm: Convert rest to devm_* and get rid of driver .remove() (no matching commit) - [v4,12/19] firmware: turris-mox-rwtm: Use dev_err_probe() where possible (no matching commit) - [v4,13/19] firmware: turris-mox-rwtm: Initialize completion before mailbox (no matching commit) - [v4,14/19] firmware: turris-mox-rwtm: Drop redundant device pointer (no matching commit) - [v4,15/19] firmware: turris-mox-rwtm: Use devm_mutex_init() instead of mutex_init() (no matching commit) - [v4,16/19] firmware: turris-mox-rwtm: Use container_of() instead of hwrng .priv member (no matching commit) - [v4,17/19] firmware: turris-mox-rwtm: Use EOPNOTSUPP instead of ENOSYS (no matching commit) - [v4,18/19] firmware: turris-mox-rwtm: Use ALIGN() instead of hardcoding (no matching commit) - [v4,19/19] firmware: turris-mox-rwtm: Deduplicate command execution code (no matching commit) You are awesome, thank you!
Hi Arnd, Andy, Gregory et al. this is v4 of series of fixes, refactors and cleanups for the turris-mox-rwtm driver. Changes since v3: - addressed Andy's recommendations. Some of them resulted in 2 new patches (08/19 and 18/19). Im patch 10/19 I did not address Andy's comment "Actually you may do that without devm. There is a lookup method or so in debugfs APIs that can be used. Can be amended later on, though." since I do not see how to use the debugfs_lookup_and_remove() function without devm and get rid of the driver's .remove() method at the same time... v1 - v3 can be found at: https://patchwork.kernel.org/project/linux-soc/list/?series=861215 https://patchwork.kernel.org/project/linux-soc/list/?series=861716 https://patchwork.kernel.org/project/linux-soc/list/?series=862643 Marek Behún (19): firmware: turris-mox-rwtm: Do not complete if there are no waiters firmware: turris-mox-rwtm: Fix checking return value of wait_for_completion_timeout() firmware: turris-mox-rwtm: Use macro constant instead of hardcoded 4096 firmware: turris-mox-rwtm: Use ETH_ALEN instead of hardcoded 6 firmware: turris-mox-rwtm: Use the boolean type where appropriate firmware: turris-mox-rwtm: Hide signature related constants behind macros firmware: turris-mox-rwtm: Fix driver includes firmware: turris-mox-rwtm: Use sysfs_emit() instead of sprintf() firmware: turris-mox-rwtm: Don't create own kobject type firmware: turris-mox-rwtm: Simplify debugfs code firmware: turris-mox-rwtm: Convert rest to devm_* and get rid of driver .remove() firmware: turris-mox-rwtm: Use dev_err_probe() where possible firmware: turris-mox-rwtm: Initialize completion before mailbox firmware: turris-mox-rwtm: Drop redundant device pointer firmware: turris-mox-rwtm: Use devm_mutex_init() instead of mutex_init() firmware: turris-mox-rwtm: Use container_of() instead of hwrng .priv member firmware: turris-mox-rwtm: Use EOPNOTSUPP instead of ENOSYS firmware: turris-mox-rwtm: Use ALIGN() instead of hardcoding firmware: turris-mox-rwtm: Deduplicate command execution code drivers/firmware/turris-mox-rwtm.c | 389 ++++++++++++----------------- 1 file changed, 157 insertions(+), 232 deletions(-)