diff mbox series

[afzal.mohd.ma@gmail.com:,[PATCH,v3] ARM: ep93xx: Replace setup_irq() by request_irq()]

Message ID 20200327110134.GA8207@afzalpc (mailing list archive)
State Superseded
Headers show
Series [afzal.mohd.ma@gmail.com:,[PATCH,v3] ARM: ep93xx: Replace setup_irq() by request_irq()] | expand

Commit Message

afzal mohammed March 27, 2020, 11:01 a.m. UTC
----- Forwarded message from afzal mohammed <afzal.mohd.ma@gmail.com> -----

Date: Sun,  1 Mar 2020 17:51:12 +0530
From: afzal mohammed <afzal.mohd.ma@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>, Hartley Sweeten <hsweeten@visionengravers.com>, Alexander Sverdlin <alexander.sverdlin@gmail.com>, Russell King
	<linux@armlinux.org.uk>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: afzal mohammed <afzal.mohd.ma@gmail.com>
Subject: [PATCH v3] ARM: ep93xx: Replace setup_irq() by request_irq()
X-Mailer: git-send-email 2.18.0

request_irq() is preferred over setup_irq(). Invocations of setup_irq()
occur after memory allocators are ready.

Per tglx[1], setup_irq() existed in olden days when allocators were not
ready by the time early interrupts were initialized.

Hence replace setup_irq() by request_irq().

[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos

Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
Hi sub-arch maintainers,

If the patch is okay, please take it thr' your tree.


 * Split out from series, also create subarch level patch as Thomas
	suggested to take it thr' respective maintainers
 * Modify string displayed in case of error as suggested by Thomas
 * Re-arrange code as required to improve readability
 * Remove irrelevant parts from commit message & improve
 * Replace pr_err("request_irq() on %s failed" by
           pr_err("%s: request_irq() failed"
 * Commit message massage

 arch/arm/mach-ep93xx/timer-ep93xx.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
diff mbox series


diff --git a/arch/arm/mach-ep93xx/timer-ep93xx.c b/arch/arm/mach-ep93xx/timer-ep93xx.c
index de998830f534..dd4b164d1831 100644
--- a/arch/arm/mach-ep93xx/timer-ep93xx.c
+++ b/arch/arm/mach-ep93xx/timer-ep93xx.c
@@ -117,15 +117,11 @@  static irqreturn_t ep93xx_timer_interrupt(int irq, void *dev_id)
 	return IRQ_HANDLED;
-static struct irqaction ep93xx_timer_irq = {
-	.name		= "ep93xx timer",
-	.handler	= ep93xx_timer_interrupt,
-	.dev_id		= &ep93xx_clockevent,
 void __init ep93xx_timer_init(void)
+	int irq = IRQ_EP93XX_TIMER3;
+	unsigned long flags = IRQF_TIMER | IRQF_IRQPOLL;
 	/* Enable and register clocksource and sched_clock on timer 4 */
@@ -136,7 +132,9 @@  void __init ep93xx_timer_init(void)
 	/* Set up clockevent on timer 3 */
-	setup_irq(IRQ_EP93XX_TIMER3, &ep93xx_timer_irq);
+	if (request_irq(irq, ep93xx_timer_interrupt, flags, "ep93xx timer",
+			&ep93xx_clockevent))
+		pr_err("Failed to request irq %d (ep93xx timer)\n", irq);