mbox series

[GIT,PULL] ARM: at91: soc for 5.12

Message ID 20210122143536.168833-1-nicolas.ferre@microchip.com (mailing list archive)
State Queued
Headers show
Series [GIT,PULL] ARM: at91: soc for 5.12 | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/at91/linux.git tags/at91-soc-5.12

Message

Nicolas Ferre Jan. 22, 2021, 2:35 p.m. UTC
From: Nicolas Ferre <nicolas.ferre@microchip.com>

Arnd, Olof,

I'm taking back the lead on sending the pull-requests for AT91 and hope that I
didn't loose the knowledge in the meantime. Tell me if there's something I'm
missing. Thanks a lot to Alexandre who kept our flow steady and very
predictable during all those years!

Here are the first SoC changes for 5.12 which contain a single patch for multi
platform kernels.

I plan to send another pull-request for the SoC changes related to new sama7g5
that Claudiu sent to the mainling-list recently. I'll let it mature in
linux-next by the beginning of next week and will send another pull-request by
mid-next-week.
Tell me if you see a problem with this approach.

Thanks, best regards,

The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e:

  Linux 5.11-rc1 (2020-12-27 15:30:22 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/at91/linux.git tags/at91-soc-5.12

for you to fetch changes up to 960ddf70cc11024e6e9dac206316d0160e00a77d:

  drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs (2020-12-28 17:58:20 +0100)

----------------------------------------------------------------
AT91 SoC for 5.12

 - Only call atmel/soc.c driver on AT91 platforms

----------------------------------------------------------------
Sudeep Holla (1):
      drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs

 drivers/soc/atmel/soc.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Arnd Bergmann Jan. 22, 2021, 3:25 p.m. UTC | #1
On Fri, Jan 22, 2021 at 3:35 PM <nicolas.ferre@microchip.com> wrote:
>
> From: Nicolas Ferre <nicolas.ferre@microchip.com>
>
> Arnd, Olof,
>
> I'm taking back the lead on sending the pull-requests for AT91 and hope that I
> didn't loose the knowledge in the meantime. Tell me if there's something I'm
> missing. Thanks a lot to Alexandre who kept our flow steady and very
> predictable during all those years!
>
> Here are the first SoC changes for 5.12 which contain a single patch for multi
> platform kernels.
>
> I plan to send another pull-request for the SoC changes related to new sama7g5
> that Claudiu sent to the mainling-list recently. I'll let it mature in
> linux-next by the beginning of next week and will send another pull-request by
> mid-next-week.
> Tell me if you see a problem with this approach.

This all looks good to me, but I think I'd rather take the 'soc' pull request
into the v5.11 bugfixes, as this may already affect users on other machines.

I would also suggest adding a 'Cc: stable@vger.kernel.org' tag. If you like,
I can just cherry-pick that patch into the fixes branch and add it there.

       Arnd
Nicolas Ferre Jan. 22, 2021, 4:14 p.m. UTC | #2
On 22/01/2021 at 16:25, Arnd Bergmann wrote:
> On Fri, Jan 22, 2021 at 3:35 PM <nicolas.ferre@microchip.com> wrote:
>>
>> From: Nicolas Ferre <nicolas.ferre@microchip.com>
>>
>> Arnd, Olof,
>>
>> I'm taking back the lead on sending the pull-requests for AT91 and hope that I
>> didn't loose the knowledge in the meantime. Tell me if there's something I'm
>> missing. Thanks a lot to Alexandre who kept our flow steady and very
>> predictable during all those years!
>>
>> Here are the first SoC changes for 5.12 which contain a single patch for multi
>> platform kernels.
>>
>> I plan to send another pull-request for the SoC changes related to new sama7g5
>> that Claudiu sent to the mainling-list recently. I'll let it mature in
>> linux-next by the beginning of next week and will send another pull-request by
>> mid-next-week.
>> Tell me if you see a problem with this approach.
> 
> This all looks good to me, but I think I'd rather take the 'soc' pull request
> into the v5.11 bugfixes, as this may already affect users on other machines.
> 
> I would also suggest adding a 'Cc: stable@vger.kernel.org' tag. If you like,
> I can just cherry-pick that patch into the fixes branch and add it there.

Oh yes, that'd be good, indeed.

You can add the following tag:
Cc: stable@vger.kernel.org #4.12+

Best regards,
Alexandre Belloni Jan. 22, 2021, 4:35 p.m. UTC | #3
On 22/01/2021 16:25:47+0100, Arnd Bergmann wrote:
> On Fri, Jan 22, 2021 at 3:35 PM <nicolas.ferre@microchip.com> wrote:
> >
> > From: Nicolas Ferre <nicolas.ferre@microchip.com>
> >
> > Arnd, Olof,
> >
> > I'm taking back the lead on sending the pull-requests for AT91 and hope that I
> > didn't loose the knowledge in the meantime. Tell me if there's something I'm
> > missing. Thanks a lot to Alexandre who kept our flow steady and very
> > predictable during all those years!
> >
> > Here are the first SoC changes for 5.12 which contain a single patch for multi
> > platform kernels.
> >
> > I plan to send another pull-request for the SoC changes related to new sama7g5
> > that Claudiu sent to the mainling-list recently. I'll let it mature in
> > linux-next by the beginning of next week and will send another pull-request by
> > mid-next-week.
> > Tell me if you see a problem with this approach.
> 
> This all looks good to me, but I think I'd rather take the 'soc' pull request
> into the v5.11 bugfixes, as this may already affect users on other machines.
> 
> I would also suggest adding a 'Cc: stable@vger.kernel.org' tag. If you like,
> I can just cherry-pick that patch into the fixes branch and add it there.
> 

I wouldn't backport it as a fix, this is just a warning, in a
configuration that is very unlikely to be used (and honestly, I
wouldn't enable this driver on any platform).

If you take it as a fix, you'll have to also get
https://lore.kernel.org/linux-arm-kernel/1611318097-8970-5-git-send-email-claudiu.beznea@microchip.com/
Nicolas Ferre Jan. 22, 2021, 5:05 p.m. UTC | #4
On 22/01/2021 at 17:35, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 22/01/2021 16:25:47+0100, Arnd Bergmann wrote:
>> On Fri, Jan 22, 2021 at 3:35 PM <nicolas.ferre@microchip.com> wrote:
>>>
>>> From: Nicolas Ferre <nicolas.ferre@microchip.com>
>>>
>>> Arnd, Olof,
>>>
>>> I'm taking back the lead on sending the pull-requests for AT91 and hope that I
>>> didn't loose the knowledge in the meantime. Tell me if there's something I'm
>>> missing. Thanks a lot to Alexandre who kept our flow steady and very
>>> predictable during all those years!
>>>
>>> Here are the first SoC changes for 5.12 which contain a single patch for multi
>>> platform kernels.
>>>
>>> I plan to send another pull-request for the SoC changes related to new sama7g5
>>> that Claudiu sent to the mainling-list recently. I'll let it mature in
>>> linux-next by the beginning of next week and will send another pull-request by
>>> mid-next-week.
>>> Tell me if you see a problem with this approach.
>>
>> This all looks good to me, but I think I'd rather take the 'soc' pull request
>> into the v5.11 bugfixes, as this may already affect users on other machines.
>>
>> I would also suggest adding a 'Cc: stable@vger.kernel.org' tag. If you like,
>> I can just cherry-pick that patch into the fixes branch and add it there.
>>
> 
> I wouldn't backport it as a fix, this is just a warning, in a
> configuration that is very unlikely to be used (and honestly, I
> wouldn't enable this driver on any platform).
> 
> If you take it as a fix, you'll have to also get
> https://lore.kernel.org/linux-arm-kernel/1611318097-8970-5-git-send-email-claudiu.beznea@microchip.com/

Arnd, Alexandre,

Whatever you prefer is fine with me. As I'm not the first impacted I 
wouldn't push in one direction or another.

Best regards,
Arnd Bergmann Jan. 22, 2021, 10:36 p.m. UTC | #5
On Fri, Jan 22, 2021 at 6:05 PM Nicolas Ferre
<nicolas.ferre@microchip.com> wrote:
> On 22/01/2021 at 17:35, Alexandre Belloni wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > I wouldn't backport it as a fix, this is just a warning, in a
> > configuration that is very unlikely to be used (and honestly, I
> > wouldn't enable this driver on any platform).
> >
> > If you take it as a fix, you'll have to also get
> > https://lore.kernel.org/linux-arm-kernel/1611318097-8970-5-git-send-email-claudiu.beznea@microchip.com/
>
> Arnd, Alexandre,
>
> Whatever you prefer is fine with me. As I'm not the first impacted I
> wouldn't push in one direction or another.

I've applied both patches to the fixes branch now. While it's only
a harmless warning, it is one that would show up for anyone that
runs a kernel with this driver built-in on a different machine, and
this could be fairly annoying.

        Arnd