diff mbox series

[PULL/direct] ARM: s3c: delete unneed local variable "delay"

Message ID 20210818204422.17919-1-krzysztof.kozlowski@canonical.com (mailing list archive)
State Accepted
Commit 319a1b58f6c7432345f13383b26c8c10e7eb1dda
Headers show
Series [PULL/direct] ARM: s3c: delete unneed local variable "delay" | expand

Commit Message

Krzysztof Kozlowski Aug. 18, 2021, 8:44 p.m. UTC 
From: Jason Wang <wangborong@cdjrlc.com>

"delay" variable on line 79 can be deleted by returning "0" on line 88.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
Link: https://lore.kernel.org/r/20210624055627.22295-1-wangborong@cdjrlc.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---

Hi Arnd and Olof,

I have just one patch for Samsung ARM mach/soc, so sending this
directly.

Best regards,
Krzysztof


 arch/arm/mach-s3c/mach-gta02.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

patchwork-bot+linux-soc@kernel.org Aug. 19, 2021, 3:30 p.m. UTC | #1 
Hello:

This patch was applied to soc/soc.git (refs/heads/arm/fixes):

On Wed, 18 Aug 2021 22:44:22 +0200 you wrote:
> From: Jason Wang <wangborong@cdjrlc.com>
> 
> "delay" variable on line 79 can be deleted by returning "0" on line 88.
> 
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> Link: https://lore.kernel.org/r/20210624055627.22295-1-wangborong@cdjrlc.com
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> [...]

Here is the summary with links:
  - [PULL/direct] ARM: s3c: delete unneed local variable "delay"
    https://git.kernel.org/soc/soc/c/319a1b58f6c7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Arnd Bergmann Aug. 19, 2021, 3:44 p.m. UTC | #2 
From: Arnd Bergmann <arnd@arndb.de>

On Wed, 18 Aug 2021 22:44:22 +0200, Krzysztof Kozlowski wrote:
> "delay" variable on line 79 can be deleted by returning "0" on line 88.

Applied to for-next, thanks!

[1/1] ARM: s3c: delete unneed local variable "delay"
      commit: 319a1b58f6c7432345f13383b26c8c10e7eb1dda

       Arnd
Arnd Bergmann Aug. 19, 2021, 9:40 p.m. UTC | #3 
On Thu, Aug 19, 2021 at 5:44 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> On Wed, 18 Aug 2021 22:44:22 +0200, Krzysztof Kozlowski wrote:
> > "delay" variable on line 79 can be deleted by returning "0" on line 88.
>
> Applied to for-next, thanks!
>
> [1/1] ARM: s3c: delete unneed local variable "delay"
>       commit: 319a1b58f6c7432345f13383b26c8c10e7eb1dda

I had accidentally added this to the arm/fixes branch at first, but corrected
that now and applied it to arm/soc instead, as you intended.

          Arnd
diff mbox series

Patch

diff --git a/arch/arm/mach-s3c/mach-gta02.c b/arch/arm/mach-s3c/mach-gta02.c
index aec8b451c016..418939ce0fc3 100644
--- a/arch/arm/mach-s3c/mach-gta02.c
+++ b/arch/arm/mach-s3c/mach-gta02.c
@@ -79,13 +79,12 @@  static struct pcf50633 *gta02_pcf;
 
 static long gta02_panic_blink(int state)
 {
-	long delay = 0;
 	char led;
 
 	led = (state) ? 1 : 0;
 	gpio_direction_output(GTA02_GPIO_AUX_LED, led);
 
-	return delay;
+	return 0;
 }