diff mbox series

[4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers

Message ID 20210910190322.27058-5-romain.perier@gmail.com (mailing list archive)
State Queued
Headers show
Series Add support for IDO-SBC2D06-V1B-22W | expand

Commit Message

Romain Perier Sept. 10, 2021, 7:03 p.m. UTC
As proposed by Daniel, I am going to help him to maintain the platform,
so add myself as co-maintainer.

Signed-off-by: Romain Perier <romain.perier@gmail.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Daniel Palmer Sept. 11, 2021, 2:56 a.m. UTC | #1
Hi Romain,

On Sat, 11 Sept 2021 at 04:03, Romain Perier <romain.perier@gmail.com> wrote:
>
> As proposed by Daniel, I am going to help him to maintain the platform,
> so add myself as co-maintainer.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3a9a7cbf9456..ad1a0e5a5425 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2231,6 +2231,7 @@ F:        arch/arm/mach-pxa/mioa701.c
>
>  ARM/MStar/Sigmastar Armv7 SoC support
>  M:     Daniel Palmer <daniel@thingy.jp>
> +M:     Romain Perier <romain.perier@gmail.com>
>  L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>  S:     Maintained
>  W:     http://linux-chenxing.org/
> --
> 2.33.0
>

Acked-by: Daniel Palmer <daniel@thingy.jp>

For everyone else: For MStar/SigmaStar I have a ~350 commit backlog
that makes almost everything work on these machines.
It's impossible for me to finish up working out the hardware and clean
up and push patches without the whole process taking years.
Romain stepped up to help out and has been pulling out patches,
cleaning them up and pushing them. He deserves to be listed as a
maintainer.

Cheers,

Daniel
Arnd Bergmann Sept. 14, 2021, 1:54 p.m. UTC | #2
On Sat, Sep 11, 2021 at 4:57 AM Daniel Palmer <daniel@0x0f.com> wrote:
> On Sat, 11 Sept 2021 at 04:03, Romain Perier <romain.perier@gmail.com> wrote:
> >
> > As proposed by Daniel, I am going to help him to maintain the platform,
> > so add myself as co-maintainer.
> >
> > Signed-off-by: Romain Perier <romain.perier@gmail.com>
> > ---
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 3a9a7cbf9456..ad1a0e5a5425 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -2231,6 +2231,7 @@ F:        arch/arm/mach-pxa/mioa701.c
> >
> >  ARM/MStar/Sigmastar Armv7 SoC support
> >  M:     Daniel Palmer <daniel@thingy.jp>
> > +M:     Romain Perier <romain.perier@gmail.com>
> >  L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> >  S:     Maintained
> >  W:     http://linux-chenxing.org/
> > --
> > 2.33.0
> >
>
> Acked-by: Daniel Palmer <daniel@thingy.jp>
>
> For everyone else: For MStar/SigmaStar I have a ~350 commit backlog
> that makes almost everything work on these machines.
> It's impossible for me to finish up working out the hardware and clean
> up and push patches without the whole process taking years.
> Romain stepped up to help out and has been pulling out patches,
> cleaning them up and pushing them. He deserves to be listed as a
> maintainer.

Sounds good to me.

One process issue though: These emails were sent 'cc:soc@kernel.org', so
they end up in patchwork, but I'm guessing they were not actually meant
for us to apply from there. I'm happy to take merge these patches (or
a future version of the series) directly from patchwork if that's what you
both had in mind, but for clarity please either

a) drop soc@kernel.org from Cc for patches that are meant for review
and will be part of a pull request.

or

b) put soc@kernel.org in the 'to:' field after they have been reviewed
and you want them to get merged.

Or even better, add an explicit sentence below the '---' line asking
for the patches to be merged directly into the soc tree when this
is what you want.

FWIW, I'd suggest merging the MAINTAINERS file change as a
bugfix for 5.15, it's generally better to do these as early as possible
to make sure any patches reach all the right people.

      Arnd
Daniel Palmer Sept. 14, 2021, 3:04 p.m. UTC | #3
Hi Arnd,

On Tue, 14 Sept 2021 at 22:54, Arnd Bergmann <arnd@arndb.de> wrote:
> Sounds good to me.
>
> One process issue though: These emails were sent 'cc:soc@kernel.org', so
> they end up in patchwork, but I'm guessing they were not actually meant
> for us to apply from there. I'm happy to take merge these patches (or
> a future version of the series) directly from patchwork if that's what you
> both had in mind, but for clarity please either
>
> a) drop soc@kernel.org from Cc for patches that are meant for review
> and will be part of a pull request.
>
> or
>
> b) put soc@kernel.org in the 'to:' field after they have been reviewed
> and you want them to get merged.

Noted for the future. Until now we haven't done pull requests so
having the patches go into the soc patchwork made sense but from now
on we'll send pull requests when needed to you and Olof for the ARM
specific bits. Which I don't think there will be much aside from dts
stuff.

> Or even better, add an explicit sentence below the '---' line asking
> for the patches to be merged directly into the soc tree when this
> is what you want.

Noted.

> FWIW, I'd suggest merging the MAINTAINERS file change as a
> bugfix for 5.15, it's generally better to do these as early as possible
> to make sure any patches reach all the right people.

That makes sense.
Would it be possible for you to merge that single commit for me?
Seems like that would be easier than me creating a fixes branch for a
single commit, sending you a PR, finding out I still don't actually
know how to do PR properly.. :)
If it's a hassle I'll do the PR though.

Cheers,

Daniel
Arnd Bergmann Sept. 14, 2021, 3:26 p.m. UTC | #4
On Tue, Sep 14, 2021 at 5:03 PM Daniel Palmer <daniel@0x0f.com> wrote:
> On Tue, 14 Sept 2021 at 22:54, Arnd Bergmann <arnd@arndb.de> wrote:

> > FWIW, I'd suggest merging the MAINTAINERS file change as a
> > bugfix for 5.15, it's generally better to do these as early as possible
> > to make sure any patches reach all the right people.
>
> That makes sense.
> Would it be possible for you to merge that single commit for me?

Done, merged into arm/fixes.

> Seems like that would be easier than me creating a fixes branch for a
> single commit, sending you a PR, finding out I still don't actually
> know how to do PR properly.. :)
> If it's a hassle I'll do the PR though.

If you only have one or two patches, sending that patch to soc@kernel.org
is usually the easiest way anyway, unless there is a reason to keep the
branch description separate from the patch description in the git log.

      Arnd
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 3a9a7cbf9456..ad1a0e5a5425 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2231,6 +2231,7 @@  F:	arch/arm/mach-pxa/mioa701.c
 
 ARM/MStar/Sigmastar Armv7 SoC support
 M:	Daniel Palmer <daniel@thingy.jp>
+M:	Romain Perier <romain.perier@gmail.com>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
 W:	http://linux-chenxing.org/