| Message ID | 20230216131511.3327943-1-conor.dooley@microchip.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e43efb6d713bca3855909a2f9caec280a2b0a503 |
| Headers | show |
| Series | [v1] dt-bindings: riscv: correct starfive visionfive 2 compatibles | expand |
On 16/02/2023 14:15, Conor Dooley wrote: > Using "va" and "vb" doesn't match what's written on the board, or the > communications from StarFive. > Switching to using the silkscreened version number will ease confusion & > the risk of another spin of the board containing a "conflicting" version > identifier. > As the binding has not made it into mainline yet, take the opportunity > to "correct" things. > > Suggested-by: Emil Renner Berthing <emil.renner.berthing@canonical.com> > Link: https://lore.kernel.org/linux-riscv/Y+4AxDSDLyL1WAqh@wendy/ > Fixes: 97b7ed072784 ("dt-bindings: riscv: Add StarFive JH7110 SoC and VisionFive 2 board") > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hello: This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <arnd@arndb.de>: On Thu, 16 Feb 2023 13:15:12 +0000 you wrote: > Using "va" and "vb" doesn't match what's written on the board, or the > communications from StarFive. > Switching to using the silkscreened version number will ease confusion & > the risk of another spin of the board containing a "conflicting" version > identifier. > As the binding has not made it into mainline yet, take the opportunity > to "correct" things. > > [...] Here is the summary with links: - [v1] dt-bindings: riscv: correct starfive visionfive 2 compatibles https://git.kernel.org/soc/soc/c/e43efb6d713b You are awesome, thank you!
diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml index 60c7c03fcdce..cc4d92f0a1bf 100644 --- a/Documentation/devicetree/bindings/riscv/starfive.yaml +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml @@ -26,8 +26,8 @@ properties: - items: - enum: - - starfive,visionfive-2-va - - starfive,visionfive-2-vb + - starfive,visionfive-2-v1.2a + - starfive,visionfive-2-v1.3b - const: starfive,jh7110 additionalProperties: true
Using "va" and "vb" doesn't match what's written on the board, or the communications from StarFive. Switching to using the silkscreened version number will ease confusion & the risk of another spin of the board containing a "conflicting" version identifier. As the binding has not made it into mainline yet, take the opportunity to "correct" things. Suggested-by: Emil Renner Berthing <emil.renner.berthing@canonical.com> Link: https://lore.kernel.org/linux-riscv/Y+4AxDSDLyL1WAqh@wendy/ Fixes: 97b7ed072784 ("dt-bindings: riscv: Add StarFive JH7110 SoC and VisionFive 2 board") Signed-off-by: Conor Dooley <conor.dooley@microchip.com> --- Arnd, If this is okay with the dt folk, could you please send this to Linus in the merge window? The dts for this binding hasn't landed yet so this is a standalone "fix" on top of my earlier dt for v6.3 PR. Thanks, Conor. --- Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)