| Message ID | 20231025112136.3445-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a9838799e2fa9fedd77867942e661b657d5591a0 |
| Headers | show |
| Series | arm: debug: reuse the config DEBUG_OMAP2UART{1,2} for OMAP{3,4,5} | expand |
Hello: This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <arnd@arndb.de>: On Wed, 25 Oct 2023 13:21:36 +0200 you wrote: > Commit d2b310b0234c ("ARM: debug: Use generic 8250 debug_ll for omap2 and > omap3/4/5 common uarts") adds address definitions of DEBUG_UART_PHYS for > OMAP2, OMAP3, OMAP4 and OMAP5 in ./arch/arm/Kconfig.debug. > > These definitions depend on DEBUG_OMAP{2,3,4,5}UART{1,2}; however, only > DEBUG_OMAP2UART{1,2} are defined in ./arch/arm/Kconfig.debug, and > DEBUG_OMAP{3,4,5}UART{1,2} are not defined. Hence, the script > ./scripts/checkkconfigsymbols.py warns here on non-existing symbols. > Simply reuse the config DEBUG_OMAP2UART{1,2}; there is no need to define > separate config symbols for OMAP{3,4,5}. So, just delete the dead > references to DEBUG_OMAP{3,4,5}UART{1,2}. > > [...] Here is the summary with links: - arm: debug: reuse the config DEBUG_OMAP2UART{1,2} for OMAP{3,4,5} https://git.kernel.org/soc/soc/c/a9838799e2fa You are awesome, thank you!
* Lukas Bulwahn <lukas.bulwahn@gmail.com> [231025 14:21]: > Simply reuse the config DEBUG_OMAP2UART{1,2}; there is no need to define > separate config symbols for OMAP{3,4,5}. So, just delete the dead > references to DEBUG_OMAP{3,4,5}UART{1,2}. Thanks applying into omap-for-v6.8/debug. Tony
* Tony Lindgren <tony@atomide.com> [231201 09:02]: > * Lukas Bulwahn <lukas.bulwahn@gmail.com> [231025 14:21]: > > Simply reuse the config DEBUG_OMAP2UART{1,2}; there is no need to define > > separate config symbols for OMAP{3,4,5}. So, just delete the dead > > references to DEBUG_OMAP{3,4,5}UART{1,2}. > > Thanks applying into omap-for-v6.8/debug. It's been already applied by Arnd, no need to do anything :) Regards, Tony
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index b407b7b9b715..fc2b41d41447 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -1593,10 +1593,8 @@ config DEBUG_UART_PHYS default 0x48020000 if DEBUG_OMAP4UART3 || DEBUG_TI81XXUART1 default 0x48022000 if DEBUG_TI81XXUART2 default 0x48024000 if DEBUG_TI81XXUART3 - default 0x4806a000 if DEBUG_OMAP2UART1 || DEBUG_OMAP3UART1 || \ - DEBUG_OMAP4UART1 || DEBUG_OMAP5UART1 - default 0x4806c000 if DEBUG_OMAP2UART2 || DEBUG_OMAP3UART2 || \ - DEBUG_OMAP4UART2 || DEBUG_OMAP5UART2 + default 0x4806a000 if DEBUG_OMAP2UART1 + default 0x4806c000 if DEBUG_OMAP2UART2 default 0x4806e000 if DEBUG_OMAP2UART3 || DEBUG_OMAP4UART4 default 0x49020000 if DEBUG_OMAP3UART3 default 0x49042000 if DEBUG_OMAP3UART4 @@ -1719,10 +1717,8 @@ config DEBUG_UART_VIRT default 0xfa020000 if DEBUG_OMAP4UART3 || DEBUG_TI81XXUART1 default 0xfa022000 if DEBUG_TI81XXUART2 default 0xfa024000 if DEBUG_TI81XXUART3 - default 0xfa06a000 if DEBUG_OMAP2UART1 || DEBUG_OMAP3UART1 || \ - DEBUG_OMAP4UART1 || DEBUG_OMAP5UART1 - default 0xfa06c000 if DEBUG_OMAP2UART2 || DEBUG_OMAP3UART2 || \ - DEBUG_OMAP4UART2 || DEBUG_OMAP5UART2 + default 0xfa06a000 if DEBUG_OMAP2UART1 + default 0xfa06c000 if DEBUG_OMAP2UART2 default 0xfa06e000 if DEBUG_OMAP2UART3 || DEBUG_OMAP4UART4 default 0xfa71e000 if DEBUG_QCOM_UARTDM default 0xfb009000 if DEBUG_REALVIEW_STD_PORT
Commit d2b310b0234c ("ARM: debug: Use generic 8250 debug_ll for omap2 and omap3/4/5 common uarts") adds address definitions of DEBUG_UART_PHYS for OMAP2, OMAP3, OMAP4 and OMAP5 in ./arch/arm/Kconfig.debug. These definitions depend on DEBUG_OMAP{2,3,4,5}UART{1,2}; however, only DEBUG_OMAP2UART{1,2} are defined in ./arch/arm/Kconfig.debug, and DEBUG_OMAP{3,4,5}UART{1,2} are not defined. Hence, the script ./scripts/checkkconfigsymbols.py warns here on non-existing symbols. Simply reuse the config DEBUG_OMAP2UART{1,2}; there is no need to define separate config symbols for OMAP{3,4,5}. So, just delete the dead references to DEBUG_OMAP{3,4,5}UART{1,2}. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- arch/arm/Kconfig.debug | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)