| Message ID | 20240726110355.2181563-7-kevin_chen@aspeedtech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Introduce ASPEED AST27XX BMC SoC | expand |
On 26/07/2024 13:03, Kevin Chen wrote: > --- > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > index 71c31c08a8ad..b21551817f44 100644 > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > @@ -99,4 +99,9 @@ properties: > - ufispace,ncplite-bmc > - const: aspeed,ast2600 > > + - description: AST2700 based boards > + items: > + - enum: > + - aspeed,ast2700-evb NAK, this cannot be alone. Look at all other examples. Why are you doing things differently? Best regards, Krzysztof
Hi Krzk, >> --- >> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> index 71c31c08a8ad..b21551817f44 100644 >> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> @@ -99,4 +99,9 @@ properties: >> - ufispace,ncplite-bmc >> - const: aspeed,ast2600 >> >> + - description: AST2700 based boards >> + items: >> + - enum: >> + - aspeed,ast2700-evb > >NAK, this cannot be alone. Look at all other examples. Why are you doing >things differently? Disagree, ast2700-evb is 7th generation IC in ASPEED. It not in the sub-set of AST2400/AST2500/AST2600 based boards. -- Best Regards, Kevin. Chen
Hi Krzk, > > --- > > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > > b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > > index 71c31c08a8ad..b21551817f44 100644 > > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > > @@ -99,4 +99,9 @@ properties: > > - ufispace,ncplite-bmc > > - const: aspeed,ast2600 > > > > + - description: AST2700 based boards > > + items: > > + - enum: > > + - aspeed,ast2700-evb > > NAK, this cannot be alone. Look at all other examples. Why are you doing > things differently? Disagree, ast2700-evb is 7th generation IC in ASPEED. It not in the sub-set of AST2400/AST2500/AST2600 based boards. > > Best regards, > Krzysztof -- Best Regards, Kevin.Chen ************* Email Confidentiality Notice ******************** 免責聲明: 本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作! DISCLAIMER: This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
On 16/08/2024 06:08, Kevin Chen wrote: > Hi Krzk, > >>> --- >>> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>> b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>> index 71c31c08a8ad..b21551817f44 100644 >>> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>> @@ -99,4 +99,9 @@ properties: >>> - ufispace,ncplite-bmc >>> - const: aspeed,ast2600 >>> >>> + - description: AST2700 based boards >>> + items: >>> + - enum: >>> + - aspeed,ast2700-evb >> >> NAK, this cannot be alone. Look at all other examples. Why are you doing >> things differently? > Disagree, ast2700-evb is 7th generation IC in ASPEED. I gave you argument and you just respond "disagree" with unrelated statement? > It not in the sub-set of AST2400/AST2500/AST2600 based boards. ? That does not answer at all my concerns. Bring me any example doing this that way: single board compatible. Answer to the argument, instead of bringing useless text "ast is a board". Yeah, of course it is. What else could it be? A ship? A car? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 71c31c08a8ad..b21551817f44 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -99,4 +99,9 @@ properties: - ufispace,ncplite-bmc - const: aspeed,ast2600 + - description: AST2700 based boards + items: + - enum: + - aspeed,ast2700-evb + additionalProperties: true