| Message ID | 20240726110355.2181563-8-kevin_chen@aspeedtech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Introduce ASPEED AST27XX BMC SoC | expand |
On 26/07/2024 13:03, Kevin Chen wrote: > --- > MAINTAINERS | 3 +++ > arch/arm64/Kconfig.platforms | 14 ++++++++++++++ > 2 files changed, 17 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index c0a3d9e93689..08609430cfe0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2121,7 +2121,10 @@ Q: https://patchwork.ozlabs.org/project/linux-aspeed/list/ > T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git > F: Documentation/devicetree/bindings/arm/aspeed/ > F: arch/arm/boot/dts/aspeed/ > +F: arch/arm64/boot/dts/aspeed/ > F: arch/arm/mach-aspeed/ > +F: include/dt-bindings/clock/aspeed,ast2700-clk.h > +F: include/dt-bindings/reset/aspeed,ast2700-reset.h > N: aspeed > > ARM/AXM LSI SOC > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 6c6d11536b42..1db7b6f1ee0a 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -40,6 +40,20 @@ config ARCH_APPLE > This enables support for Apple's in-house ARM SoC family, starting > with the Apple M1. > > +config ARCH_ASPEED > + bool "Aspeed SoC family" > + select MACH_ASPEED_G7 > + help > + Say yes if you intend to run on an Aspeed ast2700 or similar > + seventh generation Aspeed BMCs. > + > +config MACH_ASPEED_G7 > + bool "Aspeed SoC AST2700" There are no MACHines for arm64. Look at this code. Do you see MACH anywhere else? No. Then why Aspeed must be different? No. Drop. Best regards, Krzysztof
Hi Krzk, >> --- >> MAINTAINERS | 3 +++ >> arch/arm64/Kconfig.platforms | 14 ++++++++++++++ >> 2 files changed, 17 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index c0a3d9e93689..08609430cfe0 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -2121,7 +2121,10 @@ Q: https://patchwork.ozlabs.org/project/linux-aspeed/list/ >> T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git >> F: Documentation/devicetree/bindings/arm/aspeed/ >> F: arch/arm/boot/dts/aspeed/ >> +F: arch/arm64/boot/dts/aspeed/ >> F: arch/arm/mach-aspeed/ >> +F: include/dt-bindings/clock/aspeed,ast2700-clk.h >> +F: include/dt-bindings/reset/aspeed,ast2700-reset.h >> N: aspeed >> >> ARM/AXM LSI SOC >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >> index 6c6d11536b42..1db7b6f1ee0a 100644 >> --- a/arch/arm64/Kconfig.platforms >> +++ b/arch/arm64/Kconfig.platforms >> @@ -40,6 +40,20 @@ config ARCH_APPLE >> This enables support for Apple's in-house ARM SoC family, starting >> with the Apple M1. >> >> +config ARCH_ASPEED >> + bool "Aspeed SoC family" >> + select MACH_ASPEED_G7 >> + help >> + Say yes if you intend to run on an Aspeed ast2700 or similar >> + seventh generation Aspeed BMCs. >> + >> +config MACH_ASPEED_G7 >> + bool "Aspeed SoC AST2700" > >There are no MACHines for arm64. Look at this code. Do you see MACH >anywhere else? No. Then why Aspeed must be different? > >No. Drop. Agree. -- Best Regards, Kevin. Chen
Hi Krzk, > > --- > > MAINTAINERS | 3 +++ > > arch/arm64/Kconfig.platforms | 14 ++++++++++++++ > > 2 files changed, 17 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS index > > c0a3d9e93689..08609430cfe0 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -2121,7 +2121,10 @@ Q: > https://patchwork.ozlabs.org/project/linux-aspeed/list/ > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git > > F: Documentation/devicetree/bindings/arm/aspeed/ > > F: arch/arm/boot/dts/aspeed/ > > +F: arch/arm64/boot/dts/aspeed/ > > F: arch/arm/mach-aspeed/ > > +F: include/dt-bindings/clock/aspeed,ast2700-clk.h > > +F: include/dt-bindings/reset/aspeed,ast2700-reset.h > > N: aspeed > > > > ARM/AXM LSI SOC > > diff --git a/arch/arm64/Kconfig.platforms > > b/arch/arm64/Kconfig.platforms index 6c6d11536b42..1db7b6f1ee0a 100644 > > --- a/arch/arm64/Kconfig.platforms > > +++ b/arch/arm64/Kconfig.platforms > > @@ -40,6 +40,20 @@ config ARCH_APPLE > > This enables support for Apple's in-house ARM SoC family, starting > > with the Apple M1. > > > > +config ARCH_ASPEED > > + bool "Aspeed SoC family" > > + select MACH_ASPEED_G7 > > + help > > + Say yes if you intend to run on an Aspeed ast2700 or similar > > + seventh generation Aspeed BMCs. > > + > > +config MACH_ASPEED_G7 > > + bool "Aspeed SoC AST2700" > > There are no MACHines for arm64. Look at this code. Do you see MACH > anywhere else? No. Then why Aspeed must be different? > > No. Drop. Agree. > > Best regards, > Krzysztof -- Best Regards, Kevin.Chen ************* Email Confidentiality Notice ******************** 免責聲明: 本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作! DISCLAIMER: This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
diff --git a/MAINTAINERS b/MAINTAINERS index c0a3d9e93689..08609430cfe0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2121,7 +2121,10 @@ Q: https://patchwork.ozlabs.org/project/linux-aspeed/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git F: Documentation/devicetree/bindings/arm/aspeed/ F: arch/arm/boot/dts/aspeed/ +F: arch/arm64/boot/dts/aspeed/ F: arch/arm/mach-aspeed/ +F: include/dt-bindings/clock/aspeed,ast2700-clk.h +F: include/dt-bindings/reset/aspeed,ast2700-reset.h N: aspeed ARM/AXM LSI SOC diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 6c6d11536b42..1db7b6f1ee0a 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -40,6 +40,20 @@ config ARCH_APPLE This enables support for Apple's in-house ARM SoC family, starting with the Apple M1. +config ARCH_ASPEED + bool "Aspeed SoC family" + select MACH_ASPEED_G7 + help + Say yes if you intend to run on an Aspeed ast2700 or similar + seventh generation Aspeed BMCs. + +config MACH_ASPEED_G7 + bool "Aspeed SoC AST2700" + help + Say yes if you intend to run on an Aspeed ast2700 + seventh generation Aspeed BMCs. + Aspeed ast2700 BMC based on the Cortex A35. + menuconfig ARCH_BCM bool "Broadcom SoC Support"