| Message ID | 20240802090544.2741206-3-kevin_chen@aspeedtech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Introduce ASPEED AST27XX BMC SoC | expand |
On 02/08/2024 11:05, Kevin Chen wrote: > Add compatible for two SCU of SCU0 and SCU1 in AST2700. > > Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> > --- A nit, subject: drop second/last, redundant "schema". The "dt-bindings" prefix is already stating that these are bindings in the schema. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > .../bindings/mfd/aspeed,ast2x00-scu.yaml | 70 +++++++++++++------ > 1 file changed, 50 insertions(+), 20 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > index 86ee69c0f45b..3426b1c84132 100644 > --- a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml > @@ -13,33 +13,62 @@ description: > maintainers: > - Joel Stanley <joel@jms.id.au> > - Andrew Jeffery <andrew@aj.id.au> > + - Kevin Chen <kevin_chen@aspeedtech.com> > > -properties: > - compatible: > - items: > - - enum: > - - aspeed,ast2400-scu > - - aspeed,ast2500-scu > - - aspeed,ast2600-scu > - - const: syscon > - - const: simple-mfd > +scu@ast2xx00-scu: > + properties: > + compatible: > + items: > + - enum: > + - aspeed,ast2400-scu > + - aspeed,ast2500-scu > + - aspeed,ast2600-scu > + - const: syscon > + - const: simple-mfd No, no, no, this code is neither correct nor makes any sense. > > - reg: > - maxItems: 1 > + reg: > + maxItems: 1 > > - ranges: true > + ranges: true What? Best regards, Krzysztof
On Fri, 02 Aug 2024 17:05:36 +0800, Kevin Chen wrote: > Add compatible for two SCU of SCU0 and SCU1 in AST2700. > > Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> > --- > .../bindings/mfd/aspeed,ast2x00-scu.yaml | 70 +++++++++++++------ > 1 file changed, 50 insertions(+), 20 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml: 'scu@ast2xx00-scu' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref'] from schema $id: http://devicetree.org/meta-schemas/base.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml: 'scu@ast2xx00-scux' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref'] from schema $id: http://devicetree.org/meta-schemas/base.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml: scu@ast2xx00-scu: Missing additionalProperties/unevaluatedProperties constraint /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml: scu@ast2xx00-scux: Missing additionalProperties/unevaluatedProperties constraint doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240802090544.2741206-3-kevin_chen@aspeedtech.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml index 86ee69c0f45b..3426b1c84132 100644 --- a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml @@ -13,33 +13,62 @@ description: maintainers: - Joel Stanley <joel@jms.id.au> - Andrew Jeffery <andrew@aj.id.au> + - Kevin Chen <kevin_chen@aspeedtech.com> -properties: - compatible: - items: - - enum: - - aspeed,ast2400-scu - - aspeed,ast2500-scu - - aspeed,ast2600-scu - - const: syscon - - const: simple-mfd +scu@ast2xx00-scu: + properties: + compatible: + items: + - enum: + - aspeed,ast2400-scu + - aspeed,ast2500-scu + - aspeed,ast2600-scu + - const: syscon + - const: simple-mfd - reg: - maxItems: 1 + reg: + maxItems: 1 - ranges: true + ranges: true - '#address-cells': - const: 1 + '#address-cells': + const: 1 - '#size-cells': - const: 1 + '#size-cells': + const: 1 - '#clock-cells': - const: 1 + '#clock-cells': + const: 1 - '#reset-cells': - const: 1 + '#reset-cells': + const: 1 + +scu@ast2xx00-scux: + properties: + compatible: + items: + - enum: + - aspeed,ast2700-scu0 + - aspeed,ast2700-scu1 + - const: syscon + - const: simple-mfd + + reg: + maxItems: 1 + + ranges: true + + '#address-cells': + const: 2 + + '#size-cells': + const: 2 + + '#clock-cells': + const: 1 + + '#reset-cells': + const: 1 patternProperties: '^p2a-control@[0-9a-f]+$': @@ -76,6 +105,7 @@ patternProperties: - aspeed,ast2400-silicon-id - aspeed,ast2500-silicon-id - aspeed,ast2600-silicon-id + - aspeed,ast2700-silicon-id - const: aspeed,silicon-id reg:
Add compatible for two SCU of SCU0 and SCU1 in AST2700. Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> --- .../bindings/mfd/aspeed,ast2x00-scu.yaml | 70 +++++++++++++------ 1 file changed, 50 insertions(+), 20 deletions(-)