| Message ID | 20240802090544.2741206-8-kevin_chen@aspeedtech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Introduce ASPEED AST27XX BMC SoC | expand |
On 02/08/2024 11:05, Kevin Chen wrote: > Add two configs of ARCH_ASPEED and MACH_ASPEED_G7. > In current arm64 architecture, ARCH_ASPEED would select MACH_ASPEED_G7. > > Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> > --- NAK. <form letter> This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. </form letter> Best regards, Krzysztof
diff --git a/MAINTAINERS b/MAINTAINERS index 8766f3e5e87e..7d7eded0d6a3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2121,7 +2121,10 @@ Q: https://patchwork.ozlabs.org/project/linux-aspeed/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git F: Documentation/devicetree/bindings/arm/aspeed/ F: arch/arm/boot/dts/aspeed/ +F: arch/arm64/boot/dts/aspeed/ F: arch/arm/mach-aspeed/ +F: include/dt-bindings/clock/aspeed,ast2700-clk.h +F: include/dt-bindings/reset/aspeed,ast2700-reset.h N: aspeed ARM/AXM LSI SOC diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 6c6d11536b42..1db7b6f1ee0a 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -40,6 +40,20 @@ config ARCH_APPLE This enables support for Apple's in-house ARM SoC family, starting with the Apple M1. +config ARCH_ASPEED + bool "Aspeed SoC family" + select MACH_ASPEED_G7 + help + Say yes if you intend to run on an Aspeed ast2700 or similar + seventh generation Aspeed BMCs. + +config MACH_ASPEED_G7 + bool "Aspeed SoC AST2700" + help + Say yes if you intend to run on an Aspeed ast2700 + seventh generation Aspeed BMCs. + Aspeed ast2700 BMC based on the Cortex A35. + menuconfig ARCH_BCM bool "Broadcom SoC Support"
Add two configs of ARCH_ASPEED and MACH_ASPEED_G7. In current arm64 architecture, ARCH_ASPEED would select MACH_ASPEED_G7. Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> --- MAINTAINERS | 3 +++ arch/arm64/Kconfig.platforms | 14 ++++++++++++++ 2 files changed, 17 insertions(+)