| Message ID | 20250209220646.1090868-7-alexander.sverdlin@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64 support for Milk-V Duo Module 01 EVB | expand |
On Sun, Feb 09, 2025 at 11:06:31PM +0100, Alexander Sverdlin wrote: > These syscon blocks will be used for CV18xx reset driver. > > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com> > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 4d67ff26d445..5a0b102d1bd9 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -108,6 +108,8 @@ select: > - rockchip,rk3576-qos > - rockchip,rk3588-qos > - rockchip,rv1126-qos > + - sophgo,cv1800-rtcsys-core > + - sophgo,cv1800-rtcsys-ctrl > - st,spear1340-misc > - stericsson,nomadik-pmu > - starfive,jh7100-sysmain > @@ -207,6 +209,8 @@ properties: > - rockchip,rk3576-qos > - rockchip,rk3588-qos > - rockchip,rv1126-qos > + - sophgo,cv1800-rtcsys-core > + - sophgo,cv1800-rtcsys-ctrl > - st,spear1340-misc > - stericsson,nomadik-pmu > - starfive,jh7100-sysmain > -- > 2.48.1 > No cv1800, use cv1800b as the base one. Regards, Inochi
On 09/02/2025 23:06, Alexander Sverdlin wrote:
> These syscon blocks will be used for CV18xx reset driver.
No, implement proper reset block instead of abusing syscon.
Best regards,
Krzysztof
Hi Krzysztof! On Mon, 2025-02-10 at 09:48 +0100, Krzysztof Kozlowski wrote: > On 09/02/2025 23:06, Alexander Sverdlin wrote: > > These syscon blocks will be used for CV18xx reset driver. > > > No, implement proper reset block instead of abusing syscon. I don't think it's an abuse... You need to look into the corresponding TRM [1]. 4 bits I need to tweak (and one magic number into unlock register) are randomly placed at random memory adresses and otherwise adjacent bits have random unrelated functions from random unrelated subsystems. If it's not syscon, I don't know what it is. It has a reset HW block, as you and Inochi have correctly pointed out, for other purposes, for resetting the SoC IP blocks. The overall SoC reset is complete mamba jamba. I was thinking now about a syscon driver, which will register_restart_handler()... Inochi, do you have more insights into it? You've mentioned RTC and 8051... Looking into TRM I don't get it, why a thing blessed to do all the housekeeping (and called "System Controller" in imx8, for instance) happen to have RTC_ prefix... Would RTC subsystem maintainer be happy with a monster driver which has ties to all other subsystems? [1] https://github.com/sophgo/sophgo-doc/releases/download/sg2000-trm-v1.01/sg2000_trm_en.pdf ("rtc_ctrl_unlockkey", "rtc_ctrl0", "RTC_EN_WARM_RST_REQ", "RTC_EN_PWR_CYC_REQ").
On Mon, 2025-02-10 at 21:30 +0100, Alexander Sverdlin wrote: > On Mon, 2025-02-10 at 09:48 +0100, Krzysztof Kozlowski wrote: > > On 09/02/2025 23:06, Alexander Sverdlin wrote: > > > These syscon blocks will be used for CV18xx reset driver. > > > > > > No, implement proper reset block instead of abusing syscon. > > I don't think it's an abuse... You need to look into the corresponding TRM [1]. > > 4 bits I need to tweak (and one magic number into unlock register) are randomly > placed at random memory adresses and otherwise adjacent bits have random > unrelated functions from random unrelated subsystems. > If it's not syscon, I don't know what it is. > > It has a reset HW block, as you and Inochi have correctly pointed out, for other > purposes, for resetting the SoC IP blocks. The overall SoC reset is complete > mamba jamba. > > I was thinking now about a syscon driver, which will register_restart_handler()... Sorry, I meant "MFD" driver... > Inochi, do you have more insights into it? You've mentioned RTC and 8051... > Looking into TRM I don't get it, why a thing blessed to do all the housekeeping > (and called "System Controller" in imx8, for instance) happen to have RTC_ prefix... > Would RTC subsystem maintainer be happy with a monster driver which has ties > to all other subsystems? > > [1] https://github.com/sophgo/sophgo-doc/releases/download/sg2000-trm-v1.01/sg2000_trm_en.pdf > ("rtc_ctrl_unlockkey", "rtc_ctrl0", "RTC_EN_WARM_RST_REQ", "RTC_EN_PWR_CYC_REQ").
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml index 4d67ff26d445..5a0b102d1bd9 100644 --- a/Documentation/devicetree/bindings/mfd/syscon.yaml +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml @@ -108,6 +108,8 @@ select: - rockchip,rk3576-qos - rockchip,rk3588-qos - rockchip,rv1126-qos + - sophgo,cv1800-rtcsys-core + - sophgo,cv1800-rtcsys-ctrl - st,spear1340-misc - stericsson,nomadik-pmu - starfive,jh7100-sysmain @@ -207,6 +209,8 @@ properties: - rockchip,rk3576-qos - rockchip,rk3588-qos - rockchip,rv1126-qos + - sophgo,cv1800-rtcsys-core + - sophgo,cv1800-rtcsys-ctrl - st,spear1340-misc - stericsson,nomadik-pmu - starfive,jh7100-sysmain
These syscon blocks will be used for CV18xx reset driver. Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com> --- Documentation/devicetree/bindings/mfd/syscon.yaml | 4 ++++ 1 file changed, 4 insertions(+)