| Message ID | 20250209220646.1090868-8-alexander.sverdlin@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64 support for Milk-V Duo Module 01 EVB | expand |
On Sun, Feb 09, 2025 at 11:06:32PM +0100, Alexander Sverdlin wrote: > Add DT bindings for CV18xx reset controller. The power/reboot driver is > going to use only 4 bits from two different MMIO regions which can be > potentially used by other subsystems/drivers, therefore the resources > are not being claimed directly by the device/driver, but via syscons > instead. > > Link: https://github.com/sophgo/sophgo-doc/releases/download/sg2000-trm-v1.01/sg2000_trm_en.pdf > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com> > --- > .../bindings/reset/sophgo,cv1800-reset.yaml | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml > > diff --git a/Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml > new file mode 100644 > index 000000000000..4f058f99df5f > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/sophgo,cv1800-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cvitek CV18xx/Sophgo SG2000 Reset Controller > + > +maintainers: > + - Alexander Sverdlin <alexander.sverdlin@gmail.com> > + > +properties: > + compatible: > + const: sophgo,cv1800-reset Please use cv1800b, not cv1800. And this is a reboot device not reset device. Refer other bindings to write yours. Regards, Inochi
On 09/02/2025 23:06, Alexander Sverdlin wrote: > Add DT bindings for CV18xx reset controller. The power/reboot driver is > going to use only 4 bits from two different MMIO regions which can be > potentially used by other subsystems/drivers, therefore the resources > are not being claimed directly by the device/driver, but via syscons > instead. > > Link: https://github.com/sophgo/sophgo-doc/releases/download/sg2000-trm-v1.01/sg2000_trm_en.pdf > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com> > --- > .../bindings/reset/sophgo,cv1800-reset.yaml | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml > > diff --git a/Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml > new file mode 100644 > index 000000000000..4f058f99df5f > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/sophgo,cv1800-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cvitek CV18xx/Sophgo SG2000 Reset Controller > + > +maintainers: > + - Alexander Sverdlin <alexander.sverdlin@gmail.com> > + > +properties: > + compatible: > + const: sophgo,cv1800-reset > + Missing reset cells. > + sophgo,rtcsys-ctrl: > + description: phandle of the "RTCSYS_CTRL" syscon block > + $ref: /schemas/types.yaml#/definitions/phandle > + > + sophgo,rtcsys-core: > + description: phandle of the "RTCSYS_CORE" syscon block > + $ref: /schemas/types.yaml#/definitions/phandle This does not look right - entirely fake device. And your DTS next patch proves it. > + > +required: > + - compatible > + - sophgo,rtcsys-ctrl > + - sophgo,rtcsys-core > + > +additionalProperties: false > + > +examples: > + - | > + soc-reset { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "sophgo,cv1800-reset"; > + sophgo,rtcsys-ctrl = <&rtcsys_ctrl>; > + sophgo,rtcsys-core = <&rtcsys_core>; > + }; > +... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml new file mode 100644 index 000000000000..4f058f99df5f --- /dev/null +++ b/Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml @@ -0,0 +1,38 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/reset/sophgo,cv1800-reset.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cvitek CV18xx/Sophgo SG2000 Reset Controller + +maintainers: + - Alexander Sverdlin <alexander.sverdlin@gmail.com> + +properties: + compatible: + const: sophgo,cv1800-reset + + sophgo,rtcsys-ctrl: + description: phandle of the "RTCSYS_CTRL" syscon block + $ref: /schemas/types.yaml#/definitions/phandle + + sophgo,rtcsys-core: + description: phandle of the "RTCSYS_CORE" syscon block + $ref: /schemas/types.yaml#/definitions/phandle + +required: + - compatible + - sophgo,rtcsys-ctrl + - sophgo,rtcsys-core + +additionalProperties: false + +examples: + - | + soc-reset { + compatible = "sophgo,cv1800-reset"; + sophgo,rtcsys-ctrl = <&rtcsys_ctrl>; + sophgo,rtcsys-core = <&rtcsys_core>; + }; +...
Add DT bindings for CV18xx reset controller. The power/reboot driver is going to use only 4 bits from two different MMIO regions which can be potentially used by other subsystems/drivers, therefore the resources are not being claimed directly by the device/driver, but via syscons instead. Link: https://github.com/sophgo/sophgo-doc/releases/download/sg2000-trm-v1.01/sg2000_trm_en.pdf Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com> --- .../bindings/reset/sophgo,cv1800-reset.yaml | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml