diff mbox series

dmaengine: cirrus: use snprintf() to calm down gcc 13.3.0

Message ID b1f03ac53b358c135516bec98e626c98aee9d867.camel@gmail.com (mailing list archive)
State Accepted
Commit d7333f9d33772ba93f0144b1e3969866f80fdb9a
Headers show
Series dmaengine: cirrus: use snprintf() to calm down gcc 13.3.0 | expand

Commit Message

Alexander Sverdlin Sept. 12, 2024, 2:21 p.m. UTC 
Even though it's a false positive (highest channel number is "9"), refer to
"struct ep93xx_edma_data edma_m2p", we can avoid new warning by using
snprintf().

   drivers/dma/ep93xx_dma.c: In function 'ep93xx_dma_of_probe':
>> drivers/dma/ep93xx_dma.c:1365:51: warning: '%u' directive writing between 1 and 8 bytes into a region of size 2 [-Wformat-overflow=]
    1365 |                         sprintf(dma_clk_name, "m2p%u", i);
         |                                                   ^~
   drivers/dma/ep93xx_dma.c:1365:47: note: directive argument in the range [0, 16777216]
    1365 |                         sprintf(dma_clk_name, "m2p%u", i);
         |                                               ^~~~~~~
   drivers/dma/ep93xx_dma.c:1365:25: note: 'sprintf' output between 5 and 12 bytes into a destination of size 5
    1365 |                         sprintf(dma_clk_name, "m2p%u", i);
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 4e8ad5ed845b ("dmaengine: cirrus: Convert to DT for Cirrus EP93xx")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202409122133.NctarRoK-lkp@intel.com/
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
---
 drivers/dma/ep93xx_dma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

patchwork-bot+linux-soc@kernel.org Sept. 16, 2024, 12:50 p.m. UTC | #1 
Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Thu, 12 Sep 2024 16:21:06 +0200 you wrote:
> Even though it's a false positive (highest channel number is "9"), refer to
> "struct ep93xx_edma_data edma_m2p", we can avoid new warning by using
> snprintf().
> 
>    drivers/dma/ep93xx_dma.c: In function 'ep93xx_dma_of_probe':
> >> drivers/dma/ep93xx_dma.c:1365:51: warning: '%u' directive writing between 1 and 8 bytes into a region of size 2 [-Wformat-overflow=]
>     1365 |                         sprintf(dma_clk_name, "m2p%u", i);
>          |                                                   ^~
>    drivers/dma/ep93xx_dma.c:1365:47: note: directive argument in the range [0, 16777216]
>     1365 |                         sprintf(dma_clk_name, "m2p%u", i);
>          |                                               ^~~~~~~
>    drivers/dma/ep93xx_dma.c:1365:25: note: 'sprintf' output between 5 and 12 bytes into a destination of size 5
>     1365 |                         sprintf(dma_clk_name, "m2p%u", i);
>          |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> [...]

Here is the summary with links:
  - dmaengine: cirrus: use snprintf() to calm down gcc 13.3.0
    https://git.kernel.org/soc/soc/c/d7333f9d3377

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
index d084bd123c1c..b18cfb60857b 100644
--- a/drivers/dma/ep93xx_dma.c
+++ b/drivers/dma/ep93xx_dma.c
@@ -1404,9 +1404,9 @@  static struct ep93xx_dma_engine *ep93xx_dma_of_probe(struct platform_device *pde
 		edmac->edma = edma;
 
 		if (edma->m2m)
-			sprintf(dma_clk_name, "m2m%u", i);
+			snprintf(dma_clk_name, sizeof(dma_clk_name), "m2m%u", i);
 		else
-			sprintf(dma_clk_name, "m2p%u", i);
+			snprintf(dma_clk_name, sizeof(dma_clk_name), "m2p%u", i);
 
 		edmac->clk = devm_clk_get(dev, dma_clk_name);
 		if (IS_ERR(edmac->clk)) {