| Message ID | 20220620213621.GA694104@ubuntu (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5c586db8465274ce5db64171d42a099ce89ec905 |
| Headers | show |
| Series | usb: host: ehci-q: Fix ehci_submit_single_step_set_feature annotation typo | expand |
On Mon, Jun 20, 2022 at 02:36:21PM -0700, Hyunwoo Kim wrote: > Dear all, > this is Hyunwoo Kim. > > I found the "argument" typo. > > Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com> > --- > drivers/usb/host/ehci-q.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c > index 1163af6fad77..807e64991e3e 100644 > --- a/drivers/usb/host/ehci-q.c > +++ b/drivers/usb/host/ehci-q.c > @@ -1162,7 +1162,7 @@ submit_async ( > * This is done in two parts: first SETUP req for GetDesc is sent then > * 15 seconds later, the IN stage for GetDesc starts to req data from dev > * > - * is_setup : i/p arguement decides which of the two stage needs to be > + * is_setup : i/p argument decides which of the two stage needs to be > * performed; TRUE - SETUP and FALSE - IN+STATUS > * Returns 0 if success > */ > -- > 2.25.1 > > Regards, > Hyunwoo Kim. Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
From 3ba1bf7eb8e672fcd5be65080a265d3428d1303a Mon Sep 17 00:00:00 2001 From: Hyunwoo Kim <imv4bel@gmail.com> Date: Mon, 20 Jun 2022 14:30:10 -0700 Subject: [PATCH] usb: host: ehci-q: Fix ehci_submit_single_step_set_feature annotation typo I found the "argument" typo. It seems that "argument" is more correct than "arguement". Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com> --- drivers/usb/host/ehci-q.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c index 1163af6fad77..807e64991e3e 100644 --- a/drivers/usb/host/ehci-q.c +++ b/drivers/usb/host/ehci-q.c @@ -1162,7 +1162,7 @@ submit_async ( * This is done in two parts: first SETUP req for GetDesc is sent then * 15 seconds later, the IN stage for GetDesc starts to req data from dev * - * is_setup : i/p arguement decides which of the two stage needs to be + * is_setup : i/p argument decides which of the two stage needs to be * performed; TRUE - SETUP and FALSE - IN+STATUS * Returns 0 if success */ -- 2.25.1 Dear Greg, I'm sending the patch back because the greg email bot emailed me. I don't think there was anything wrong with the patch format. Did I receive an email saying my patch was in the wrong format because my patch was a minor typo fix and the description was too short? I'm sorry if I did something wrong. Regards, Hyunwoo Kim.
On Mon, Jun 20, 2022 at 11:29:25PM -0700, Hyunwoo Kim wrote: > >From 3ba1bf7eb8e672fcd5be65080a265d3428d1303a Mon Sep 17 00:00:00 2001 > From: Hyunwoo Kim <imv4bel@gmail.com> > Date: Mon, 20 Jun 2022 14:30:10 -0700 > Subject: [PATCH] usb: host: ehci-q: Fix ehci_submit_single_step_set_feature annotation typo This shouldn't be in the body of the email, try using 'git send-email' instead. > > I found the "argument" typo. > It seems that "argument" is more correct than "arguement". That is much better, thanks. > > Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com> > --- > drivers/usb/host/ehci-q.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c > index 1163af6fad77..807e64991e3e 100644 > --- a/drivers/usb/host/ehci-q.c > +++ b/drivers/usb/host/ehci-q.c > @@ -1162,7 +1162,7 @@ submit_async ( > * This is done in two parts: first SETUP req for GetDesc is sent then > * 15 seconds later, the IN stage for GetDesc starts to req data from dev > * > - * is_setup : i/p arguement decides which of the two stage needs to be > + * is_setup : i/p argument decides which of the two stage needs to be > * performed; TRUE - SETUP and FALSE - IN+STATUS > * Returns 0 if success > */ > -- > 2.25.1 > > Dear Greg, > > I'm sending the patch back because the greg email bot emailed me. > I don't think there was anything wrong with the patch format. > Did I receive an email saying my patch was in the wrong format because > my patch was a minor typo fix and the description was too short? This looks better, but can you resend this without the above header in the body and then we can apply it. thanks, greg k-h
I found the "argument" typo.
It seems that "argument" is more correct than "arguement".
Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
---
drivers/usb/host/ehci-q.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c
index 1163af6fad77..807e64991e3e 100644
--- a/drivers/usb/host/ehci-q.c
+++ b/drivers/usb/host/ehci-q.c
@@ -1162,7 +1162,7 @@ submit_async (
* This is done in two parts: first SETUP req for GetDesc is sent then
* 15 seconds later, the IN stage for GetDesc starts to req data from dev
*
- * is_setup : i/p arguement decides which of the two stage needs to be
+ * is_setup : i/p argument decides which of the two stage needs to be
* performed; TRUE - SETUP and FALSE - IN+STATUS
* Returns 0 if success
*/
--
2.25.1
Send it back without headers.
Sorry to bother you.
Regards,
Hyunwoo Kim.
diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c index 1163af6fad77..807e64991e3e 100644 --- a/drivers/usb/host/ehci-q.c +++ b/drivers/usb/host/ehci-q.c @@ -1162,7 +1162,7 @@ submit_async ( * This is done in two parts: first SETUP req for GetDesc is sent then * 15 seconds later, the IN stage for GetDesc starts to req data from dev * - * is_setup : i/p arguement decides which of the two stage needs to be + * is_setup : i/p argument decides which of the two stage needs to be * performed; TRUE - SETUP and FALSE - IN+STATUS * Returns 0 if success */
Dear all, this is Hyunwoo Kim. I found the "argument" typo. Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com> --- drivers/usb/host/ehci-q.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)