mbox series

[00/13] staging: wilc1000: address few mainline review

Message ID 1547731250-18518-1-git-send-email-ajay.kathat@microchip.com (mailing list archive)
Headers show
Series staging: wilc1000: address few mainline review | expand

Message

Ajay Singh Jan. 17, 2019, 1:21 p.m. UTC
From: Ajay Singh <ajay.kathat@microchip.com>

This series contains changes to address few of the review comments[1].
It mainly has the modification to remove the use of scan shadow
buffer, make use of kernel provided API, avoid typedef's and few
changes to simplify the logic.

[1]. https://www.spinics.net/lists/linux-wireless/msg178735.html
     https://www.spinics.net/lists/linux-wireless/msg179533.html
     https://www.spinics.net/lists/linux-wireless/msg178760.html

Ajay Singh (13):
  staging: wilc1000: make use of get_unaligned_le16/le32 to pack data
  staging: wilc1000: refactor wilc_wlan_set_bssid()
  staging: wilc1000: use 'struct' to pack cfg header frame in
    wilc_wlan_cfg_commit()
  staging: wilc1000: remove the use of scan shadow buffer
  staging: wilc1000: make use of cfg80211_inform_bss_frame()
  staging: wilc1000: corrected order to pack join param buffer
  staging: wilc1000: use struct to pack join parameters for FW
  staging: wilc1000: rename hidden_network related data structure
  staging: wilc1000: use single struct for 'connect' related parameters
  staging: wilc1000: refactor information message parsing logic
  staging: wilc1000: remove 'disconnect_info' structure
  staging: wilc1000: refactor handle_set_mcast_filter()
  staging: wilc1000: avoid the use of typedef for function pointers

 drivers/staging/wilc1000/host_interface.c         | 979 +++++++---------------
 drivers/staging/wilc1000/host_interface.h         | 127 +--
 drivers/staging/wilc1000/linux_wlan.c             |  12 +-
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 450 ++--------
 drivers/staging/wilc1000/wilc_wfi_netdevice.h     |   5 +-
 drivers/staging/wilc1000/wilc_wlan.c              |  35 +-
 drivers/staging/wilc1000/wilc_wlan.h              |  19 +-
 drivers/staging/wilc1000/wilc_wlan_cfg.c          |  27 +-
 drivers/staging/wilc1000/wilc_wlan_if.h           |   3 -
 9 files changed, 456 insertions(+), 1201 deletions(-)

Comments

Greg Kroah-Hartman Jan. 18, 2019, 9:41 a.m. UTC | #1
On Thu, Jan 17, 2019 at 01:21:06PM +0000, Ajay.Kathat@microchip.com wrote:
> From: Ajay Singh <ajay.kathat@microchip.com>
> 
> This series contains changes to address few of the review comments[1].
> It mainly has the modification to remove the use of scan shadow
> buffer, make use of kernel provided API, avoid typedef's and few
> changes to simplify the logic.
> 
> [1]. https://www.spinics.net/lists/linux-wireless/msg178735.html
>      https://www.spinics.net/lists/linux-wireless/msg179533.html
>      https://www.spinics.net/lists/linux-wireless/msg178760.html
> 
> Ajay Singh (13):
>   staging: wilc1000: make use of get_unaligned_le16/le32 to pack data
>   staging: wilc1000: refactor wilc_wlan_set_bssid()
>   staging: wilc1000: use 'struct' to pack cfg header frame in
>     wilc_wlan_cfg_commit()
>   staging: wilc1000: remove the use of scan shadow buffer
>   staging: wilc1000: make use of cfg80211_inform_bss_frame()
>   staging: wilc1000: corrected order to pack join param buffer
>   staging: wilc1000: use struct to pack join parameters for FW
>   staging: wilc1000: rename hidden_network related data structure
>   staging: wilc1000: use single struct for 'connect' related parameters
>   staging: wilc1000: refactor information message parsing logic
>   staging: wilc1000: remove 'disconnect_info' structure
>   staging: wilc1000: refactor handle_set_mcast_filter()
>   staging: wilc1000: avoid the use of typedef for function pointers
> 
>  drivers/staging/wilc1000/host_interface.c         | 979 +++++++---------------
>  drivers/staging/wilc1000/host_interface.h         | 127 +--
>  drivers/staging/wilc1000/linux_wlan.c             |  12 +-
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 450 ++--------
>  drivers/staging/wilc1000/wilc_wfi_netdevice.h     |   5 +-
>  drivers/staging/wilc1000/wilc_wlan.c              |  35 +-
>  drivers/staging/wilc1000/wilc_wlan.h              |  19 +-
>  drivers/staging/wilc1000/wilc_wlan_cfg.c          |  27 +-
>  drivers/staging/wilc1000/wilc_wlan_if.h           |   3 -
>  9 files changed, 456 insertions(+), 1201 deletions(-)

Nice set of cleanups!

all applied, thanks.

greg k-h