| Message ID | 1548937297-14660-1-git-send-email-yhchuang@realtek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | rtw88: major fixes for 8822c to have stable functionalities | expand |
On Thu, Jan 31, 2019 at 08:21:13PM +0800, yhchuang@realtek.com wrote: > From: Yan-Hsuan Chuang <yhchuang@realtek.com> > > Note this patch set is based on the original patch set "rtw88: mac80211 > driver for Realtek 802.11ac wireless network chips". The latest would be here, for reference: https://patchwork.kernel.org/cover/10787651/ http://lkml.kernel.org/linux-wireless/1548820940-15237-1-git-send-email-yhchuang@realtek.com > These patches are mean to make sure 8822c chip to operate normal for most > of the basic functionalities, such as power on, switch channel, scan, > connection establish and connection monitor. > > As the original patch set was sent 3 months ago, progress has been made > by Realtek during the past months. Now we have tested on more chips and > released tables and parameters for them. Also the chips are all > programed with efuse map released for 8822c. > > Most of the changes are about BB and RF, both control the tx/rx path. > PHY parameters/seq and efuse info make sure the hardware is powered on > correctly. And channel setting updates help driver to switch to target > channel accurately. Then trx mode setting and DACK will make hardware to > have stable performance to tx/rx to connect to AP. > > Here tx power control is also required to transmit with a precise power. > Otherwise if the power is too high or too low, the peer might not be able > to receive the signal. > > Finally, we need to report correct tx status for mac80211's connection > monitor system, this requires firmware's C2H of tx status report. After > this, users can use 8822c chips for more stable wireless communication. Besides the comments I added (and needing to fix the out-of-bounds reads), this series helpfully adds RFE 1 support, so the 8822C chip I have works for some basic functions -- it's not too snappy, and I feel like there's still plenty of room for improvement but: Tested-by: Brian Norris <briannorris@chromium.org> And except for a handful of patches (should look at patch 1 closer), these all look pretty sane and helpful. Reviewed-by: Brian Norris <briannorris@chromium.org> I still need to pass back over the original patchset and try a few more things out. Regards, Brian
> From: Brian Norris [mailto:briannorris@chromium.org] > Subject: Re: [PATCH 00/24] rtw88: major fixes for 8822c to have stable > functionalities > > On Thu, Jan 31, 2019 at 08:21:13PM +0800, yhchuang@realtek.com wrote: > > From: Yan-Hsuan Chuang <yhchuang@realtek.com> > > > > Note this patch set is based on the original patch set "rtw88: mac80211 > > driver for Realtek 802.11ac wireless network chips". > > The latest would be here, for reference: > > https://patchwork.kernel.org/cover/10787651/ > http://lkml.kernel.org/linux-wireless/1548820940-15237-1-git-send-email-yhch > uang@realtek.com > > > These patches are mean to make sure 8822c chip to operate normal for most > > of the basic functionalities, such as power on, switch channel, scan, > > connection establish and connection monitor. > > > > As the original patch set was sent 3 months ago, progress has been made > > by Realtek during the past months. Now we have tested on more chips and > > released tables and parameters for them. Also the chips are all > > programed with efuse map released for 8822c. > > > > Most of the changes are about BB and RF, both control the tx/rx path. > > PHY parameters/seq and efuse info make sure the hardware is powered on > > correctly. And channel setting updates help driver to switch to target > > channel accurately. Then trx mode setting and DACK will make hardware to > > have stable performance to tx/rx to connect to AP. > > > > Here tx power control is also required to transmit with a precise power. > > Otherwise if the power is too high or too low, the peer might not be able > > to receive the signal. > > > > Finally, we need to report correct tx status for mac80211's connection > > monitor system, this requires firmware's C2H of tx status report. After > > this, users can use 8822c chips for more stable wireless communication. > > Besides the comments I added (and needing to fix the out-of-bounds > reads), this series helpfully adds RFE 1 support, so the 8822C chip I > have works for some basic functions -- it's not too snappy, and I feel > like there's still plenty of room for improvement but: > > Tested-by: Brian Norris <briannorris@chromium.org> > > And except for a handful of patches (should look at patch 1 closer), > these all look pretty sane and helpful. > > Reviewed-by: Brian Norris <briannorris@chromium.org> > > I still need to pass back over the original patchset and try a few more > things out. > > Regards, > Brian Thanks for your review, helps a lot! Yan-Hsuan
From: Yan-Hsuan Chuang <yhchuang@realtek.com> Note this patch set is based on the original patch set "rtw88: mac80211 driver for Realtek 802.11ac wireless network chips". These patches are mean to make sure 8822c chip to operate normal for most of the basic functionalities, such as power on, switch channel, scan, connection establish and connection monitor. As the original patch set was sent 3 months ago, progress has been made by Realtek during the past months. Now we have tested on more chips and released tables and parameters for them. Also the chips are all programed with efuse map released for 8822c. Most of the changes are about BB and RF, both control the tx/rx path. PHY parameters/seq and efuse info make sure the hardware is powered on correctly. And channel setting updates help driver to switch to target channel accurately. Then trx mode setting and DACK will make hardware to have stable performance to tx/rx to connect to AP. Here tx power control is also required to transmit with a precise power. Otherwise if the power is too high or too low, the peer might not be able to receive the signal. Finally, we need to report correct tx status for mac80211's connection monitor system, this requires firmware's C2H of tx status report. After this, users can use 8822c chips for more stable wireless communication. Chien-Hsun Liao (3): rtw88: add a delay after writing a rf register rtw88: 8822c: update channel setting rtw88: 8822c: update trx mode setting Tzu-En Huang (2): rtw88: add 8822c tx power index table parsing support rtw88: add 8822c tx agc support Yan-Hsuan Chuang (19): rtw88: report correct tx status if mac80211 requested one rtw88: add get_c2h_from_skb for extracting c2h commands rtw88: can not support vif beacon filter actually rtw88: fix incorrect bit definition for RF mode rtw88: 8822c: correct crystal setting rtw88: 8822c: update efuse table as released rtw88: 8822c: update pwr_seq to v12 rtw88: 8822c: update phy parameter to v27 rtw88: add module param to switch lps supportability rtw88: extract utility functions into util.c rtw88: 8822c: add support for DACK rtw88: 8822c: fix RSC setting rtw88: 8822c: set ack timeout rtw88: 8822c: do not reset MAC Rx before sending CCK packet rtw88: 8822c: parse packet by sigb length rtw88: do not count dummy tail into rx counter rtw88: set OFDM ctx to receive ack after cts2self rtw88: fix slot time value rtw88: 8822b: turn rtw_write32s_mask into macro drivers/net/wireless/realtek/rtw88/Makefile | 1 + drivers/net/wireless/realtek/rtw88/fw.c | 19 +- drivers/net/wireless/realtek/rtw88/fw.h | 16 + drivers/net/wireless/realtek/rtw88/mac.c | 53 +- drivers/net/wireless/realtek/rtw88/mac80211.c | 1 - drivers/net/wireless/realtek/rtw88/main.c | 20 +- drivers/net/wireless/realtek/rtw88/main.h | 68 +- drivers/net/wireless/realtek/rtw88/pci.c | 8 +- drivers/net/wireless/realtek/rtw88/pci.h | 1 + drivers/net/wireless/realtek/rtw88/phy.c | 193 +- drivers/net/wireless/realtek/rtw88/phy.h | 9 + drivers/net/wireless/realtek/rtw88/reg.h | 9 +- drivers/net/wireless/realtek/rtw88/rtw8822b.c | 59 +- drivers/net/wireless/realtek/rtw88/rtw8822b.h | 15 + drivers/net/wireless/realtek/rtw88/rtw8822c.c | 934 +- drivers/net/wireless/realtek/rtw88/rtw8822c.h | 75 +- .../net/wireless/realtek/rtw88/rtw8822c_table.c | 11047 ++++++++++++++++--- .../net/wireless/realtek/rtw88/rtw8822c_table.h | 1 + drivers/net/wireless/realtek/rtw88/tx.c | 94 + drivers/net/wireless/realtek/rtw88/tx.h | 8 + drivers/net/wireless/realtek/rtw88/util.c | 72 + drivers/net/wireless/realtek/rtw88/util.h | 34 + 22 files changed, 10667 insertions(+), 2070 deletions(-) create mode 100644 drivers/net/wireless/realtek/rtw88/util.c create mode 100644 drivers/net/wireless/realtek/rtw88/util.h