mbox series

[PATCHv4,0/2] cfg80211/mac80211: Add support to configure and monitor station's rssi threshold

Message ID 1555492880-26457-1-git-send-email-tamizhr@codeaurora.org (mailing list archive)
Headers show
Series cfg80211/mac80211: Add support to configure and monitor station's rssi threshold | expand

Message

Tamizh chelvam April 17, 2019, 9:21 a.m. UTC
This patchsets introduced new NL command and api to support
configuring rssi for the connected stations and api to notify
userspace application upon crossing the configured threshold.
This will be useful for the application which requires
station's current signal strength change information.
Monitoring station's signal strength through station dump command
will unnecessarily increase the system overhead. This event based
mechanism will reduce the system overhead and helps application to
take a decision for the station for which event received.

Tamizh chelvam (2):
  cfg80211: Add support to configure station specific RSSI threshold
    for AP mode
  mac80211: Implement API to configure station specific rssi threshold

v4:
 * Fixed sparse warning

v3:
 * Address Johannes comments

v2:
 * Combined patchset 2 and 3 as single patch and addressed Johannes comments.

 include/net/cfg80211.h       |   39 +++++++++
 include/net/mac80211.h       |    7 ++
 include/uapi/linux/nl80211.h |   21 +++++
 net/mac80211/cfg.c           |  108 +++++++++++++++++++++++++
 net/mac80211/rx.c            |   56 ++++++++++++-
 net/mac80211/sta_info.c      |    1 +
 net/mac80211/sta_info.h      |   31 ++++++++
 net/wireless/nl80211.c       |  179 ++++++++++++++++++++++++++++++++++++------
 net/wireless/rdev-ops.h      |   13 +++
 net/wireless/trace.h         |   21 +++++
 10 files changed, 449 insertions(+), 27 deletions(-)

Comments

Johannes Berg April 26, 2019, 10:03 a.m. UTC | #1
On Wed, 2019-04-17 at 14:51 +0530, Tamizh chelvam wrote:
> This patchsets introduced new NL command and api to support
> configuring rssi for the connected stations and api to notify
> userspace application upon crossing the configured threshold.
> This will be useful for the application which requires
> station's current signal strength change information.

What is "the application"?

Given all our discussions at the summit and my thinking on all of this
recently, I'm _very_ tempted to just reject this patchset after all, and
ask you to (help) implement appropriate eBPF hooks in the stack that can
be used to implement it instead.

Why is this better than programmable infrastructure for it?

johannes