mbox series

[v2,0/2] add Wide Band Scan support

Message ID 1572869374-9635-1-git-send-email-murugana@codeaurora.org (mailing list archive)
Headers show
Series add Wide Band Scan support | expand

Message

Sathishkumar Muruganandam Nov. 4, 2019, 12:09 p.m. UTC
Wide Band Scan allows to perform off-channel scan on requested channel/
frequency along with corresponding phy mode/bandwidth (40Mhz, 80Mhz).

Below are use cases of Wide Band Scan,

1. In case of phy running both AP and monitor vifs, wide band scan on
   a different channel along with phymode (40Mhz, 80Mhz) captures
   those off-channel data frames to monitor vif.

2. Doing wide band scan instead of normal 20Mhz scan before spectral
   dump, allows to fetch FFT reports for the complete requested
   bandwidth (40Mhz, 80Mhz).

Sathishkumar Muruganandam (2):
  nl80211: add Wide Band Scan support

 include/net/cfg80211.h       |  2 ++
 include/uapi/linux/nl80211.h |  7 +++++
 net/mac80211/scan.c          |  2 ++
 net/wireless/nl80211.c       | 68 ++++++++++++++++++++++++++++----------------
 4 files changed, 55 insertions(+), 24 deletions(-)

  ath11k: add Wide Band Scan support

 drivers/net/wireless/ath/ath11k/mac.c |  41 ++++++++++--
 drivers/net/wireless/ath/ath11k/wmi.c | 115 +++++++++++++++++++++++++++++++---
 drivers/net/wireless/ath/ath11k/wmi.h |  34 +++++++++-
 3 files changed, 175 insertions(+), 15 deletions(-)

Comments

Johannes Berg Nov. 4, 2019, 12:11 p.m. UTC | #1
On Mon, 2019-11-04 at 17:39 +0530, Sathishkumar Muruganandam wrote:
> Wide Band Scan allows to perform off-channel scan on requested channel/
> frequency along with corresponding phy mode/bandwidth (40Mhz, 80Mhz).
> 
> Below are use cases of Wide Band Scan,
> 
> 1. In case of phy running both AP and monitor vifs, wide band scan on
>    a different channel along with phymode (40Mhz, 80Mhz) captures
>    those off-channel data frames to monitor vif.
> 
> 2. Doing wide band scan instead of normal 20Mhz scan before spectral
>    dump, allows to fetch FFT reports for the complete requested
>    bandwidth (40Mhz, 80Mhz).

Neither of these are scan use cases (at least not that are covered by
nl80211 scan APIs), so that doesn't make sense.

johannes
Sathishkumar Muruganandam Nov. 5, 2019, 10:21 a.m. UTC | #2
> Neither of these are scan use cases (at least not that are covered by
> nl80211 scan APIs), so that doesn't make sense.
> 

Actually we had extended the existing 'iw scan' command to do Wide Band Scan using nl80211 scan APIs.

dev <devname> scan freq <freq> [HT40+|HT40-|80MHz] [ap-force]

dev <devname> scan trigger freq <freq> [HT40+|HT40-|80MHz] [ap-force]

Raised patch for above change, [PATCH] iw: Add phymode parameters to scan command for Wide Band Scan support.

--
Sathishkumar
Johannes Berg Nov. 5, 2019, 10:22 a.m. UTC | #3
On Tue, 2019-11-05 at 15:51 +0530, Sathishkumar Muruganandam wrote:
> > Neither of these are scan use cases (at least not that are covered by
> > nl80211 scan APIs), so that doesn't make sense.
> > 
> 
> Actually we had extended the existing 'iw scan' command to do Wide
> Band Scan using nl80211 scan APIs.

Yes ... but ... that doesn't address my question.

How is this related to scanning? It sounds to me like you're just
(ab)using scan as a somewhat convenient "do some channel hopping" API
...

johannes
Sathishkumar Muruganandam Nov. 11, 2019, 7:57 a.m. UTC | #4
On 2019-11-05 15:52, Johannes Berg wrote:
> On Tue, 2019-11-05 at 15:51 +0530, Sathishkumar Muruganandam wrote:
>> > Neither of these are scan use cases (at least not that are covered by
>> > nl80211 scan APIs), so that doesn't make sense.
>> >
>> 
>> Actually we had extended the existing 'iw scan' command to do Wide
>> Band Scan using nl80211 scan APIs.
> 
> Yes ... but ... that doesn't address my question.
> 
> How is this related to scanning? It sounds to me like you're just
> (ab)using scan as a somewhat convenient "do some channel hopping" API
> ...
> 

Whether this can be used under "iw offchannel" with 
NL80211_CMD_REMAIN_ON_CHANNEL?

Please provide your comments.
Johannes Berg Nov. 14, 2019, 6:38 a.m. UTC | #5
On Mon, 2019-11-11 at 13:27 +0530, Sathishkumar Muruganandam wrote:
> 
> > How is this related to scanning? It sounds to me like you're just
> > (ab)using scan as a somewhat convenient "do some channel hopping" API
> > ...
> > 
> 
> Whether this can be used under "iw offchannel" with 
> NL80211_CMD_REMAIN_ON_CHANNEL?

Not sure what you're asking. Are you asking if I would accept wide
channel extensions to R-O-C? That seems more reasonable than for
scanning anyway. Still I guess I'd like to see an actual reason for it.

johannes
Sathishkumar Muruganandam Nov. 14, 2019, 12:33 p.m. UTC | #6
On 2019-11-14 12:08, Johannes Berg wrote:
> On Mon, 2019-11-11 at 13:27 +0530, Sathishkumar Muruganandam wrote:
>> 
>> > How is this related to scanning? It sounds to me like you're just
>> > (ab)using scan as a somewhat convenient "do some channel hopping" API
>> > ...
>> >
>> 
>> Whether this can be used under "iw offchannel" with
>> NL80211_CMD_REMAIN_ON_CHANNEL?
> 
> Are you asking if I would accept wide
> channel extensions to R-O-C?

Yes, adding bandwidth config to existing command.

Something like this,

iw offchannel <freq> [HT40+|HT40-|80MHz] <duration>

> Still I guess I'd like to see an actual reason for it.

Wide band scan is actually moving to a off-channel for a
specified duration to capture 40, 80Mhz data frames.

So, I hope offchannel would accommodate this extension.
Johannes Berg Nov. 22, 2019, 12:45 p.m. UTC | #7
On Thu, 2019-11-14 at 18:03 +0530, Sathishkumar Muruganandam wrote:
> On 2019-11-14 12:08, Johannes Berg wrote:
> > On Mon, 2019-11-11 at 13:27 +0530, Sathishkumar Muruganandam wrote:
> > > > How is this related to scanning? It sounds to me like you're just
> > > > (ab)using scan as a somewhat convenient "do some channel hopping" API
> > > > ...
> > > > 
> > > 
> > > Whether this can be used under "iw offchannel" with
> > > NL80211_CMD_REMAIN_ON_CHANNEL?
> > 
> > Are you asking if I would accept wide
> > channel extensions to R-O-C?
> 
> Yes, adding bandwidth config to existing command.
> 
> Something like this,
> 
> iw offchannel <freq> [HT40+|HT40-|80MHz] <duration>
> 
> > Still I guess I'd like to see an actual reason for it.
> 
> Wide band scan is actually moving to a off-channel for a
> specified duration to capture 40, 80Mhz data frames.
> 
> So, I hope offchannel would accommodate this extension.

That certainly makes more sense to me than scan, but it'd *still* be
good to come up with use cases for supporting it and have that in the
commit details.

johannes