| Message ID | 20190214223644.8035-1-Larry.Finger@lwfinger.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | rtlwifi: Remove CamelCase variables from all drivers | expand |
Larry Finger <Larry.Finger@lwfinger.net> writes: > This set of patches fix all instances of CamelCase for all the drivers. > When the symbol refers to a macro, it is converted to upper case. If a > variable or a function, then it is converted to lower case. > > As noted in the comments, some of the other checkpatch exceptions are > addressed. I wish you had separated the camel case fixes from other cleanups, and otherwise tried to simplify the patches, now you made the patchset painful to review as all the changes are mixed and the size of patches is just too large. Remember that the rule of thumb is one logical change per patch. Of course that's not a hard rule, and can be ignored with small and trivial patches, but most of the patches here are not small. No need to resend because of this but please take care with the size of patches and patchsets in the future.
This set of patches fix all instances of CamelCase for all the drivers. When the symbol refers to a macro, it is converted to upper case. If a variable or a function, then it is converted to lower case. As noted in the comments, some of the other checkpatch exceptions are addressed. Larry Finger (8): rtlwifi: Remove CamelCase variables from base code rtlwifi: btcoexist: Remove CamelCase variable rtlwifi: rtl8188ee: Remove CamelCase variable rtlwifi: rtl8192{c,u}: Remove CamelCase variables rtlwifi: rtl8188de: Remove CamelCase variables rtlwifi: rtl8192se: Remove CamelCase variables rtlwifi: rtl8723{be,ae}: Remove CamelCase variables rtlwifi: rtl8821ae: Remove CamelCase variables .../realtek/rtlwifi/btcoexist/halbt_precomp.h | 2 - drivers/net/wireless/realtek/rtlwifi/debug.h | 2 +- drivers/net/wireless/realtek/rtlwifi/efuse.c | 44 +-- drivers/net/wireless/realtek/rtlwifi/efuse.h | 2 +- drivers/net/wireless/realtek/rtlwifi/regd.c | 8 +- .../wireless/realtek/rtlwifi/rtl8188ee/def.h | 3 - .../wireless/realtek/rtlwifi/rtl8188ee/trx.c | 4 +- .../realtek/rtlwifi/rtl8192c/dm_common.h | 4 +- .../realtek/rtlwifi/rtl8192c/fw_common.c | 14 +- .../realtek/rtlwifi/rtl8192c/phy_common.c | 24 +- .../realtek/rtlwifi/rtl8192c/phy_common.h | 6 +- .../wireless/realtek/rtlwifi/rtl8192ce/dm.h | 4 +- .../wireless/realtek/rtlwifi/rtl8192ce/hw.c | 42 +-- .../wireless/realtek/rtlwifi/rtl8192ce/phy.c | 10 +- .../wireless/realtek/rtlwifi/rtl8192ce/phy.h | 6 +- .../wireless/realtek/rtlwifi/rtl8192ce/reg.h | 59 ++-- .../wireless/realtek/rtlwifi/rtl8192ce/rf.c | 112 +++---- .../wireless/realtek/rtlwifi/rtl8192ce/trx.c | 4 +- .../wireless/realtek/rtlwifi/rtl8192cu/hw.c | 278 +++++++++--------- .../wireless/realtek/rtlwifi/rtl8192cu/hw.h | 4 +- .../wireless/realtek/rtlwifi/rtl8192cu/led.c | 6 +- .../wireless/realtek/rtlwifi/rtl8192cu/phy.c | 16 +- .../wireless/realtek/rtlwifi/rtl8192cu/rf.c | 112 +++---- .../realtek/rtlwifi/rtl8192cu/table.c | 8 +- .../realtek/rtlwifi/rtl8192cu/table.h | 16 +- .../wireless/realtek/rtlwifi/rtl8192cu/trx.c | 62 ++-- .../wireless/realtek/rtlwifi/rtl8192cu/trx.h | 4 +- .../wireless/realtek/rtlwifi/rtl8192de/dm.c | 24 +- .../wireless/realtek/rtlwifi/rtl8192de/dm.h | 2 +- .../wireless/realtek/rtlwifi/rtl8192de/fw.c | 16 +- .../wireless/realtek/rtlwifi/rtl8192de/hw.c | 66 ++--- .../wireless/realtek/rtlwifi/rtl8192de/phy.c | 68 ++--- .../wireless/realtek/rtlwifi/rtl8192de/reg.h | 28 +- .../wireless/realtek/rtlwifi/rtl8192de/trx.c | 2 +- .../wireless/realtek/rtlwifi/rtl8192ee/trx.c | 2 +- .../wireless/realtek/rtlwifi/rtl8192se/dm.h | 2 +- .../wireless/realtek/rtlwifi/rtl8192se/fw.c | 4 +- .../wireless/realtek/rtlwifi/rtl8192se/fw.h | 6 +- .../wireless/realtek/rtlwifi/rtl8192se/hw.c | 22 +- .../wireless/realtek/rtlwifi/rtl8192se/phy.c | 44 +-- .../wireless/realtek/rtlwifi/rtl8192se/reg.h | 48 +-- .../wireless/realtek/rtlwifi/rtl8192se/trx.c | 4 +- .../wireless/realtek/rtlwifi/rtl8723ae/def.h | 2 +- .../wireless/realtek/rtlwifi/rtl8723ae/hw.c | 8 +- .../wireless/realtek/rtlwifi/rtl8723ae/phy.c | 2 +- .../wireless/realtek/rtlwifi/rtl8723ae/phy.h | 2 +- .../realtek/rtlwifi/rtl8723ae/pwrseq.h | 18 +- .../wireless/realtek/rtlwifi/rtl8723ae/sw.c | 2 +- .../wireless/realtek/rtlwifi/rtl8723ae/trx.c | 4 +- .../wireless/realtek/rtlwifi/rtl8723be/hw.c | 14 +- .../wireless/realtek/rtlwifi/rtl8723be/trx.c | 4 +- .../wireless/realtek/rtlwifi/rtl8821ae/dm.h | 10 +- .../wireless/realtek/rtlwifi/rtl8821ae/fw.c | 102 +++---- .../wireless/realtek/rtlwifi/rtl8821ae/hw.c | 234 +++++++-------- .../wireless/realtek/rtlwifi/rtl8821ae/phy.c | 132 ++++----- .../wireless/realtek/rtlwifi/rtl8821ae/phy.h | 4 +- .../wireless/realtek/rtlwifi/rtl8821ae/reg.h | 34 +-- .../realtek/rtlwifi/rtl8821ae/table.c | 184 ++++++------ drivers/net/wireless/realtek/rtlwifi/usb.c | 6 +- drivers/net/wireless/realtek/rtlwifi/usb.h | 2 +- drivers/net/wireless/realtek/rtlwifi/wifi.h | 26 +- 61 files changed, 989 insertions(+), 995 deletions(-)