mbox series

[0/4] rtlwifi: 8192de: Fix used uninitialized variables in power tracking

Message ID 20190510080333.3789-1-pkshih@realtek.com (mailing list archive)
Headers show
Series rtlwifi: 8192de: Fix used uninitialized variables in power tracking | expand

Message

Ping-Ke Shih May 10, 2019, 8:03 a.m. UTC
From: Ping-Ke Shih <pkshih@realtek.com>

This issue is found by Coverity and repoerted by Colin Ian King. An array
ofdm_index[3] is never initialized.

In order to fix this issue, I refactor the code to be more readable, and
then I investigate the variable ofdm_index[] should be initialized as
the index corresponding to thermal value programmed in efuse.

The cckswing table in the last patch is used to adjust TX power. When I
check this function, the table is in little-endian order, but compare
with register value in cpu order. Then, fix it as well.

Ping-Ke Shih (4):
  rtlwifi: 8192de: Reduce indentation and fix coding style
  rtlwifi: 8192de: make tables to be 'static const'
  rtlwifi: 8192de: Fix used uninitialized variables in power tracking
  rtlwifi: 8192de: use le32 to access cckswing tables

 .../wireless/realtek/rtlwifi/rtl8192de/dm.c   | 695 +++++++++---------
 1 file changed, 330 insertions(+), 365 deletions(-)