[0/4] marvell: Fix firmware filenames for sd8977/sd8997 chipsets

Message

Pali Rohár June 3, 2020, 8:22 a.m. UTC

This patch series fixes mwifiex and btmrvl drivers to load firmware for sd8977
and sd8997 chipsets from correct filename.

Both Marvell distribution package and linux-firmware repository [1] contain
firmware for these chipsets in files sdsd8977_combo_v2.bin/sdsd8997_combo_v4.bin.

Linux drivers mwifiex and btmrvl try to load firmware for these chipsets from
sd8977_uapsta.bin/sd8997_uapsta.bin files which obviously fails as these files
do not exist neither in linux-firmware [1] nor in Marvell distribution packages.

So the result is that Marvell sd8977 and sd8997 chipsets via mainline kernel
drivers (mwifiex and btmrvl) do not work out of box.

Each patch in this series fixes particular git commit which introduced usage
of incorrect firmware filename. Also each patch contains Fixes: line for easier
backporting to stable kernels.

mwifiex (1/4, 2/4) and btmrvl (3/4, 4/4) parts of this patch series can be
applied separately via wireless and bluetooth trees. I'm sending all four
patches in one patch series for easier review.

[1] - https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/mrvl

Pali Rohár (4):
  mwifiex: Fix firmware filename for sd8977 chipset
  mwifiex: Fix firmware filename for sd8997 chipset
  btmrvl: Fix firmware filename for sd8977 chipset
  btmrvl: Fix firmware filename for sd8997 chipset

 drivers/bluetooth/btmrvl_sdio.c             | 8 ++++----
 drivers/net/wireless/marvell/mwifiex/sdio.h | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

Comments

Ganapathi Bhat June 3, 2020, 9:17 a.m. UTC | #1

Hi Pali,

> This patch series fixes mwifiex and btmrvl drivers to load firmware for
> sd8977 and sd8997 chipsets from correct filename.

Thanks you for the changes, I will ack each patch;

Regards,
Ganapathi

Marcel Holtmann June 3, 2020, 5:47 p.m. UTC | #2

Hi Pali,

> This patch series fixes mwifiex and btmrvl drivers to load firmware for sd8977
> and sd8997 chipsets from correct filename.
> 
> Both Marvell distribution package and linux-firmware repository [1] contain
> firmware for these chipsets in files sdsd8977_combo_v2.bin/sdsd8997_combo_v4.bin.
> 
> Linux drivers mwifiex and btmrvl try to load firmware for these chipsets from
> sd8977_uapsta.bin/sd8997_uapsta.bin files which obviously fails as these files
> do not exist neither in linux-firmware [1] nor in Marvell distribution packages.
> 
> So the result is that Marvell sd8977 and sd8997 chipsets via mainline kernel
> drivers (mwifiex and btmrvl) do not work out of box.
> 
> Each patch in this series fixes particular git commit which introduced usage
> of incorrect firmware filename. Also each patch contains Fixes: line for easier
> backporting to stable kernels.
> 
> mwifiex (1/4, 2/4) and btmrvl (3/4, 4/4) parts of this patch series can be
> applied separately via wireless and bluetooth trees. I'm sending all four
> patches in one patch series for easier review.
> 
> [1] - https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/mrvl
> 
> Pali Rohár (4):
>  mwifiex: Fix firmware filename for sd8977 chipset
>  mwifiex: Fix firmware filename for sd8997 chipset
>  btmrvl: Fix firmware filename for sd8977 chipset
>  btmrvl: Fix firmware filename for sd8997 chipset
> 
> drivers/bluetooth/btmrvl_sdio.c             | 8 ++++----
> drivers/net/wireless/marvell/mwifiex/sdio.h | 4 ++--
> 2 files changed, 6 insertions(+), 6 deletions(-)

all 4 patches have been applied to bluetooth-next tree.

Regards

Marcel