mbox series

[0/1] wcn36xx: Revert firmware link monitoring

Message ID 20211022141008.2846454-1-bryan.odonoghue@linaro.org (mailing list archive)
Headers show
Series wcn36xx: Revert firmware link monitoring | expand

Message

Bryan O'Donoghue Oct. 22, 2021, 2:10 p.m. UTC
We can get this working with

- Secure APs PS on/off
- Open APs PS on

by setting firmware feature bit WLANACTIVE_OFFLOAD 

Open APs PS off though is non-functional even with the above bit enabled
and three quaters of a wheel is useless.

So unfortunately for now zap it off.

Bryan O'Donoghue (1):
  Revert "wcn36xx: Enable firmware link monitoring"

 drivers/net/wireless/ath/wcn36xx/main.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Kalle Valo Oct. 25, 2021, 8:52 a.m. UTC | #1
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:

> We can get this working with
>
> - Secure APs PS on/off
> - Open APs PS on
>
> by setting firmware feature bit WLANACTIVE_OFFLOAD 
>
> Open APs PS off though is non-functional even with the above bit enabled
> and three quaters of a wheel is useless.
>
> So unfortunately for now zap it off.

Avoid using acronyms as much as possible, PS meaning power save might
not be clear for everyone.

And please try to be more specific, I'm not sure what power save feature
you are meaning here. (802.11 protocol power save, BMPS or what?)
Bryan O'Donoghue Oct. 25, 2021, 9:07 a.m. UTC | #2
On 25/10/2021 09:52, Kalle Valo wrote:
> Avoid using acronyms as much as possible, PS meaning power save might
> not be clear for everyone.
> 
> And please try to be more specific, I'm not sure what power save feature
> you are meaning here. (802.11 protocol power save, BMPS or what?)

Yep - the issue is on an Open AP when we enter BMPS link monitoring 
stops working.

I'll make that clear in a resend