[0/3] rtw89: fix crash when loading firmware file on certain platforms

Message

Ping-Ke Shih Nov. 11, 2021, 2:14 a.m. UTC

First patch is to avoid writing "partition size" on read-only firmware
buffer, so it has to fix the crash.
The later two patches are used to make the semantics clear, but they don't
change the logic at all.

I hope at least first patch can be taken into 5.16-rc, so people can avoid
this crash.

Ping-Ke Shih (3):
  rtw89: update partition size of firmware header on skb->data
  rtw89: add const in the cast of le32_get_bits()
  rtw89: use inline function instead macro to set H2C and CAM

 drivers/net/wireless/realtek/rtw89/cam.h  |  468 ++++--
 drivers/net/wireless/realtek/rtw89/fw.c   |    2 +-
 drivers/net/wireless/realtek/rtw89/fw.h   | 1768 ++++++++++++---------
 drivers/net/wireless/realtek/rtw89/txrx.h |   46 +-
 4 files changed, 1370 insertions(+), 914 deletions(-)

Comments

Larry Finger Nov. 11, 2021, 6:43 p.m. UTC | #1

On 11/10/21 20:14, Ping-Ke Shih wrote:
> First patch is to avoid writing "partition size" on read-only firmware
> buffer, so it has to fix the crash.
> The later two patches are used to make the semantics clear, but they don't
> change the logic at all.
> 
> I hope at least first patch can be taken into 5.16-rc, so people can avoid
> this crash.

Tested-by: Larry Finger <[e-mail]>
> 
> Ping-Ke Shih (3):
>    rtw89: update partition size of firmware header on skb->data
>    rtw89: add const in the cast of le32_get_bits()
>    rtw89: use inline function instead macro to set H2C and CAM
> 
>   drivers/net/wireless/realtek/rtw89/cam.h  |  468 ++++--
>   drivers/net/wireless/realtek/rtw89/fw.c   |    2 +-
>   drivers/net/wireless/realtek/rtw89/fw.h   | 1768 ++++++++++++---------
>   drivers/net/wireless/realtek/rtw89/txrx.h |   46 +-
>   4 files changed, 1370 insertions(+), 914 deletions(-)
>