| Message ID | 20220524153621.19027-1-Larry.Finger@lwfinger.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | rtw88: Fix some Sparse Warnings | expand |
> -----Original Message----- > From: Larry Finger <Larry.Finger@lwfinger.net> > Sent: Tuesday, May 24, 2022 11:36 PM > To: Kalle Valo <kvalo@kernel.org> > Cc: Johannes Berg <johannes@sipsolutions.net>; linux-wireless@vger.kernel.org; Larry Finger > <Larry.Finger@lwfinger.net>; Ping-Ke Shih <pkshih@realtek.com> > Subject: [PATCH v3 0/4] rtw88: Fix some Sparse Warnings > > Sparse shows warnings for symbols that can be static. In these cases. > the wrong solution is suggested - again reinforcing the concept > that all tools may suggest the wrong answer, and must be checked. > > Constify all *_hw_spec variables > > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> This patchset looks good to me. Thanks! Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Sparse shows warnings for symbols that can be static. In these cases. the wrong solution is suggested - again reinforcing the concept that all tools may suggest the wrong answer, and must be checked. Constify all *_hw_spec variables Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> --- v2 Change patch subjects as recommended by Kalle v3 Make the correct fix for the warnings - 'static' is incorrect, but const is correct --- Larry Finger (4): rtw88: Fix sparse warning for rtw8822b_hw_spec rtw88: Fix Sparse warning for rtw8822c_hw_spec rtw88: Fix Sparse warning for rtw8723d_hw_spec rtw88: Fix Sparse warning for rtw8821c_hw_spec drivers/net/wireless/realtek/rtw88/rtw8723d.h | 2 ++ drivers/net/wireless/realtek/rtw88/rtw8723de.c | 2 +- drivers/net/wireless/realtek/rtw88/rtw8723de.h | 10 ---------- drivers/net/wireless/realtek/rtw88/rtw8821c.h | 2 ++ drivers/net/wireless/realtek/rtw88/rtw8821ce.c | 2 +- drivers/net/wireless/realtek/rtw88/rtw8821ce.h | 10 ---------- drivers/net/wireless/realtek/rtw88/rtw8822b.h | 2 ++ drivers/net/wireless/realtek/rtw88/rtw8822be.c | 2 +- drivers/net/wireless/realtek/rtw88/rtw8822be.h | 10 ---------- drivers/net/wireless/realtek/rtw88/rtw8822c.h | 2 ++ drivers/net/wireless/realtek/rtw88/rtw8822ce.c | 2 +- drivers/net/wireless/realtek/rtw88/rtw8822ce.h | 10 ---------- 12 files changed, 12 insertions(+), 44 deletions(-) delete mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723de.h delete mode 100644 drivers/net/wireless/realtek/rtw88/rtw8821ce.h delete mode 100644 drivers/net/wireless/realtek/rtw88/rtw8822be.h delete mode 100644 drivers/net/wireless/realtek/rtw88/rtw8822ce.h