| Message ID | 20230302160310.923349-1-jaewan@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mac80211_hwsim: Add PMSR support | expand |
On Thu, Mar 02, 2023 at 04:03:05PM +0000, Jaewan Kim wrote: > Dear Kernel maintainers, > > First of all, thank you for spending your precious time for reviewing > my changes, and also sorry for my mistakes in previous patchsets. > > Let me propose series of CLs for adding PMSR support in the mac80211_hwsim. What is a "CL"?
Greg KH <gregkh@linuxfoundation.org> writes: > On Thu, Mar 02, 2023 at 04:03:05PM +0000, Jaewan Kim wrote: >> Dear Kernel maintainers, >> >> First of all, thank you for spending your precious time for reviewing >> my changes, and also sorry for my mistakes in previous patchsets. >> >> Let me propose series of CLs for adding PMSR support in the mac80211_hwsim. > > What is a "CL"? Hehe, we are not the only ones asking for this: https://stackoverflow.com/questions/25716920/what-does-cl-mean-in-a-commit-message-what-does-it-stand-for Apparently this is Google terminology but in upstream we use "patch" and "patchset". But the recommendation is to not say "in this patchset" or "in this patch" in commit logs, everyone know they are patches anyway.
Jaewan Kim <jaewan@google.com> writes: > Sorry about the inconvenience. > I checked all patchset comments and also got internal reviews, > but forgot to double check in the cover letter. > > Should I send another patchset just for cover-letter? > Otherwise let me keep this as of now, unless I need to send another patchset. Please don't use HTML, our lists drop all HTML mail.
On Wed, Mar 8, 2023 at 7:05 PM Kalle Valo <kvalo@kernel.org> wrote: > > Jaewan Kim <jaewan@google.com> writes: > > > Sorry about the inconvenience. > > I checked all patchset comments and also got internal reviews, > > but forgot to double check in the cover letter. > > > > Should I send another patchset just for cover-letter? > > Otherwise let me keep this as of now, unless I need to send another patchset. > > Please don't use HTML, our lists drop all HTML mail. > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches Sorry about any inconvenience caused by my mistake. Uploaded a new patchset without 'CL', and also double checked 'plain text mode' before replying.
Dear Kernel maintainers, First of all, thank you for spending your precious time for reviewing my changes, and also sorry for my mistakes in previous patchsets. Let me propose series of CLs for adding PMSR support in the mac80211_hwsim. PMSR (peer measurement) is generalized measurement between STAs, and currently FTM (fine time measurement or flight time measurement) is the one and only measurement. FTM measures the RTT (round trip time) and FTM can be used to measure distances between two STAs. RTT is often referred as 'measuring distance' as well. Kernel had already defined protocols for PMSR in the include/uapi/linux/nl80211.h and relevant parsing/sending code are in the net/wireless/pmsr.c, but they are only used in intel's iwlwifi driver. CLs are tested with iw tool on Virtual Android device (a.k.a. Cuttlefish). Hope this explains my CLs. Many Thanks, -- V7 -> V8: Separated CL for exporting nl80211_send_chandef V6 -> V7: Split 'mac80211_hwsim: handle FTM requests with virtio' with three pieces V5 -> V6: Added per CL change history. V4 -> V5: Fixed style V3 -> V4: Added detailed explanation to cover letter and per CL commit messages, includes explanation of PMSR and FTM. Also fixed memory leak. V1 -> V3: Initial commits (include resends) Jaewan Kim (5): mac80211_hwsim: add PMSR capability support wifi: nl80211: make nl80211_send_chandef non-static mac80211_hwsim: add PMSR request support via virtio mac80211_hwsim: add PMSR abort support via virtio mac80211_hwsim: add PMSR report support via virtio drivers/net/wireless/mac80211_hwsim.c | 775 +++++++++++++++++++++++++- drivers/net/wireless/mac80211_hwsim.h | 58 ++ include/net/cfg80211.h | 9 + net/wireless/nl80211.c | 4 +- 4 files changed, 834 insertions(+), 12 deletions(-)