mbox series

[v3,0/4] RTW88 USB bug fixes

Message ID 20230417140134.2237428-1-s.hauer@pengutronix.de (mailing list archive)
Headers show
Series RTW88 USB bug fixes | expand

Message

Sascha Hauer April 17, 2023, 2:01 p.m. UTC 
Third round of the RTW88 USB bug fixes.

After some discussion and thinking I came to the conclusion that the
v1 variant of "wifi: rtw88: rtw8821c: Fix rfe_option field width" is
better than the one posted in v2, so I reverted back to this version,
but added a note to the commit message why this might not be entirely
correct for all chip variants (though for all variants currently
supported in the driver).

The patches are sorted in order of importance. 1/4 hasn't seen any
negative comments and I think it should be applied right now.
As stated above I think 2/4 should be applied as well. 3/4 fixes
something I stumbled upon while reading in the vendor driver, but
I don't what effect it actually has, I didn't notice any change
in behaviour of the driver. 4/4 straightens the logic how
rtw8821c_switch_rf_set() is called for different variants of the
rtw8821c. This is taken from the vendor driver. From the supported
chip variants this should only have an effect on the ones with
rfe_option = 6, but I don't have that one available here for
testing.

I would be glad if at least 1/4 and 2/4 could be applied as these
fix real issues in the driver.

Sascha

Sascha Hauer (4):
  wifi: rtw88: usb: fix priority queue to endpoint mapping
  wifi: rtw88: rtw8821c: Fix rfe_option field width
  wifi: rtw88: set pkg_type correctly for specific rtw8821c variants
  wifi: rtw88: call rtw8821c_switch_rf_set() according to chip variant

 drivers/net/wireless/realtek/rtw88/main.c     |  2 +-
 drivers/net/wireless/realtek/rtw88/main.h     |  2 +
 drivers/net/wireless/realtek/rtw88/rtw8821c.c | 25 +++++--
 drivers/net/wireless/realtek/rtw88/usb.c      | 70 +++++++++++++------
 4 files changed, 69 insertions(+), 30 deletions(-)

Comments

Sascha Hauer April 17, 2023, 2:05 p.m. UTC | #1 
On Mon, Apr 17, 2023 at 04:01:30PM +0200, Sascha Hauer wrote:
> Third round of the RTW88 USB bug fixes.
> 
> After some discussion and thinking I came to the conclusion that the
> v1 variant of "wifi: rtw88: rtw8821c: Fix rfe_option field width" is
> better than the one posted in v2, so I reverted back to this version,
> but added a note to the commit message why this might not be entirely
> correct for all chip variants (though for all variants currently
> supported in the driver).
> 
> The patches are sorted in order of importance. 1/4 hasn't seen any
> negative comments and I think it should be applied right now.
> As stated above I think 2/4 should be applied as well. 3/4 fixes
> something I stumbled upon while reading in the vendor driver, but
> I don't what effect it actually has, I didn't notice any change
> in behaviour of the driver. 4/4 straightens the logic how
> rtw8821c_switch_rf_set() is called for different variants of the
> rtw8821c. This is taken from the vendor driver. From the supported
> chip variants this should only have an effect on the ones with
> rfe_option = 6, but I don't have that one available here for
> testing.
> 
> I would be glad if at least 1/4 and 2/4 could be applied as these
> fix real issues in the driver.

Please ignore. There was a typo in Larrys email address, I am resending
the whole series.

Sascha
Ping-Ke Shih April 18, 2023, 12:22 a.m. UTC | #2 
> -----Original Message-----
> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Monday, April 17, 2023 10:06 PM
> To: linux-wireless <linux-wireless@vger.kernel.org>
> Cc: Hans Ulli Kroll <linux@ulli-kroll.de>; Larry Finger <Larry.Finger@lwfinger.net>; Ping-Ke Shih
> <pkshih@realtek.com>; Tim K <tpkuester@gmail.com>; Alex G . <mr.nuke.me@gmail.com>; Nick Morrow
> <morrownr@gmail.com>; Viktor Petrenko <g0000ga@gmail.com>; Andreas Henriksson <andreas@fatal.se>;
> ValdikSS <iam@valdikss.org.ru>; kernel@pengutronix.de
> Subject: Re: [PATCH v3 0/4] RTW88 USB bug fixes
> 
> On Mon, Apr 17, 2023 at 04:01:30PM +0200, Sascha Hauer wrote:
> > Third round of the RTW88 USB bug fixes.
> >
> > After some discussion and thinking I came to the conclusion that the
> > v1 variant of "wifi: rtw88: rtw8821c: Fix rfe_option field width" is
> > better than the one posted in v2, so I reverted back to this version,
> > but added a note to the commit message why this might not be entirely
> > correct for all chip variants (though for all variants currently
> > supported in the driver).
> >
> > The patches are sorted in order of importance. 1/4 hasn't seen any
> > negative comments and I think it should be applied right now.
> > As stated above I think 2/4 should be applied as well. 3/4 fixes
> > something I stumbled upon while reading in the vendor driver, but
> > I don't what effect it actually has, I didn't notice any change
> > in behaviour of the driver. 4/4 straightens the logic how
> > rtw8821c_switch_rf_set() is called for different variants of the
> > rtw8821c. This is taken from the vendor driver. From the supported
> > chip variants this should only have an effect on the ones with
> > rfe_option = 6, but I don't have that one available here for
> > testing.
> >
> > I would be glad if at least 1/4 and 2/4 could be applied as these
> > fix real issues in the driver.
> 
> Please ignore. There was a typo in Larrys email address, I am resending
> the whole series.
> 

Using v4 as your resend patchset, it would be easier to know
which one is newer.

Ping-Ke