mbox series

[PATCHv3,0/3] wifi: ath12k: Remove unsupported and unused ring configurations

Message ID 20240429072039.711706-1-quic_tamizhr@quicinc.com (mailing list archive)
Headers show
Series wifi: ath12k: Remove unsupported and unused ring configurations | expand

Message

Tamizh Chelvam Raja April 29, 2024, 7:20 a.m. UTC 
Currently in driver doing memory allocation for tx_monitor,
tcl_cmd_ring and tcl_status ring. Here driver support for
tx_monitor mode is not there and memory for tcl_cmd and tcl_status
rings are allocated by firmware and it uses that memory instead of
host allocated. So avoid these unused ring setup configuration.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1

Tamizh Chelvam Raja (3):
  wifi: ath12k: fix calling correct function for rx monitor mode
  wifi: ath12k: Remove unsupported tx monitor handling
  wifi: ath12k: Remove unused tcl_*_ring configuration

v3:
  * Addressed Karthikeyan's review comment of modifying
    ath12k_dp_tx_htt_rx_monitor_mode_ring_config in correct place.

v2:
 * Rebased on top of ToT

 drivers/net/wireless/ath/ath12k/dp.c     | 16 -------
 drivers/net/wireless/ath/ath12k/dp.h     |  2 -
 drivers/net/wireless/ath/ath12k/dp_mon.c | 40 +----------------
 drivers/net/wireless/ath/ath12k/dp_rx.c  | 56 ------------------------
 drivers/net/wireless/ath/ath12k/dp_tx.c  | 44 +------------------
 drivers/net/wireless/ath/ath12k/dp_tx.h  |  1 -
 6 files changed, 2 insertions(+), 157 deletions(-)


base-commit: bf99bc7423e18aa3475ef00a7a6fb773c31ce6df

Comments

Jeff Johnson April 29, 2024, 9:44 p.m. UTC | #1 
On 4/29/2024 12:20 AM, Tamizh Chelvam Raja wrote:
> Currently in driver doing memory allocation for tx_monitor,
> tcl_cmd_ring and tcl_status ring. Here driver support for
> tx_monitor mode is not there and memory for tcl_cmd and tcl_status
> rings are allocated by firmware and it uses that memory instead of
> host allocated. So avoid these unused ring setup configuration.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Tamizh Chelvam Raja (3):
>   wifi: ath12k: fix calling correct function for rx monitor mode
>   wifi: ath12k: Remove unsupported tx monitor handling
>   wifi: ath12k: Remove unused tcl_*_ring configuration
> 
> v3:
>   * Addressed Karthikeyan's review comment of modifying
>     ath12k_dp_tx_htt_rx_monitor_mode_ring_config in correct place.
> 
> v2:
>  * Rebased on top of ToT
> 
>  drivers/net/wireless/ath/ath12k/dp.c     | 16 -------
>  drivers/net/wireless/ath/ath12k/dp.h     |  2 -
>  drivers/net/wireless/ath/ath12k/dp_mon.c | 40 +----------------
>  drivers/net/wireless/ath/ath12k/dp_rx.c  | 56 ------------------------
>  drivers/net/wireless/ath/ath12k/dp_tx.c  | 44 +------------------
>  drivers/net/wireless/ath/ath12k/dp_tx.h  |  1 -
>  6 files changed, 2 insertions(+), 157 deletions(-)

My Qualcomm Innovation Center copyright checker reports:
drivers/net/wireless/ath/ath12k/dp_tx.h copyright missing 2024

> 
> 
> base-commit: bf99bc7423e18aa3475ef00a7a6fb773c31ce6df