mbox series

[v3,0/2] wifi: ath12k: drop failed transmitted frames from metric calculation

Message ID 20240429114841.413901-1-quic_kathirve@quicinc.com (mailing list archive)
Headers show
Series wifi: ath12k: drop failed transmitted frames from metric calculation | expand

Message

Karthikeyan Kathirvel April 29, 2024, 11:48 a.m. UTC
- Use ieee80211_free_txskb() instead of dev_kfree_skb_any().
- Drop failed transmitted frames from mesh metric calculation to avoid
false link metric averaging.

Karthikeyan Kathirvel (1):
  wifi: ath12k: drop failed transmitted frames from metric calculation.

Sven Eckelmann (1):
  wifi: ath12k: Don't drop tx_status in failure case

 drivers/net/wireless/ath/ath12k/dp_tx.c    | 43 ++++++++++++++++------
 drivers/net/wireless/ath/ath12k/hal_desc.h | 22 ++++++++++-
 2 files changed, 52 insertions(+), 13 deletions(-)


base-commit: 363e7193eaf258fe7f04e8db560bd8a282a12cd9

Comments

Jeff Johnson April 29, 2024, 6:46 p.m. UTC | #1
On 4/29/2024 4:48 AM, Karthikeyan Kathirvel wrote:
> - Use ieee80211_free_txskb() instead of dev_kfree_skb_any().
> - Drop failed transmitted frames from mesh metric calculation to avoid
> false link metric averaging.
> 
> Karthikeyan Kathirvel (1):
>   wifi: ath12k: drop failed transmitted frames from metric calculation.
> 
> Sven Eckelmann (1):
>   wifi: ath12k: Don't drop tx_status in failure case
> 
>  drivers/net/wireless/ath/ath12k/dp_tx.c    | 43 ++++++++++++++++------
>  drivers/net/wireless/ath/ath12k/hal_desc.h | 22 ++++++++++-
>  2 files changed, 52 insertions(+), 13 deletions(-)
> 
> 
> base-commit: 363e7193eaf258fe7f04e8db560bd8a282a12cd9

'b4' is barfing on this series since you posted 3 patches instead of 2:
[PATCH v3 1/2] wifi: ath12k: Don't drop tx_status in failure case
[PATCH v3 1/2] wifi: ath12k: Don't drop tx_status when peer cannot be found
[PATCH v3 2/2] wifi: ath12k: drop failed transmitted frames from metric calculation.

Why are there two different 1/2 patches?
Karthikeyan Kathirvel April 30, 2024, 7:42 a.m. UTC | #2
On 4/30/2024 12:16 AM, Jeff Johnson wrote:
> On 4/29/2024 4:48 AM, Karthikeyan Kathirvel wrote:
>> - Use ieee80211_free_txskb() instead of dev_kfree_skb_any().
>> - Drop failed transmitted frames from mesh metric calculation to avoid
>> false link metric averaging.
>>
>> Karthikeyan Kathirvel (1):
>>    wifi: ath12k: drop failed transmitted frames from metric calculation.
>>
>> Sven Eckelmann (1):
>>    wifi: ath12k: Don't drop tx_status in failure case
>>
>>   drivers/net/wireless/ath/ath12k/dp_tx.c    | 43 ++++++++++++++++------
>>   drivers/net/wireless/ath/ath12k/hal_desc.h | 22 ++++++++++-
>>   2 files changed, 52 insertions(+), 13 deletions(-)
>>
>>
>> base-commit: 363e7193eaf258fe7f04e8db560bd8a282a12cd9
> 
> 'b4' is barfing on this series since you posted 3 patches instead of 2:
> [PATCH v3 1/2] wifi: ath12k: Don't drop tx_status in failure case
> [PATCH v3 1/2] wifi: ath12k: Don't drop tx_status when peer cannot be found
> [PATCH v3 2/2] wifi: ath12k: drop failed transmitted frames from metric calculation.
> 
> Why are there two different 1/2 patches?
Uploaded an invalid patch by mistake, have removed it in next version v4 
and also replaced a dev_kfree_skb_any() by ieee80211_free_txskb() in 
ath12k_dp_tx_free_txbuf(),