mbox series

[0/4] wifi: ath12k: Add support to enable debugfs_htt_stats

Message ID 20240429173825.2369355-1-quic_rgnanase@quicinc.com (mailing list archive)
Headers show
Series wifi: ath12k: Add support to enable debugfs_htt_stats | expand

Message

Ramya Gnanasekar April 29, 2024, 5:38 p.m. UTC
Bring in the basic infrastructure necessary for enabling htt_stats via debugfs.
Patch series bring support to request stats type to firmware,
dump the stats and request to reset the stats from firmware.

Schema with one ath12k device:

ath12k
`-- pci-0000:06:00.0
    |-- mac0
        `-- htt_stats
        |-- htt_stats_type
        |-- htt_stats_reset

Dinesh Karthikeyan (3):
  wifi: ath12k: Add support to enable debugfs_htt_stats
  wifi: ath12k: Add htt_stats_dump file ops support
  wifi: ath12k: Add support to parse requested stats_type

Ramya Gnanasekar (1):
  wifi: ath12k: Dump additional Tx PDEV HTT stats

 drivers/net/wireless/ath/ath12k/Makefile      |   2 +-
 drivers/net/wireless/ath/ath12k/core.h        |  11 +
 drivers/net/wireless/ath/ath12k/debugfs.c     |   3 +
 .../wireless/ath/ath12k/debugfs_htt_stats.c   | 713 ++++++++++++++++++
 .../wireless/ath/ath12k/debugfs_htt_stats.h   | 300 ++++++++
 drivers/net/wireless/ath/ath12k/dp_rx.c       |  10 +-
 drivers/net/wireless/ath/ath12k/dp_rx.h       |   4 +
 7 files changed, 1038 insertions(+), 5 deletions(-)
 create mode 100644 drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
 create mode 100644 drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h


base-commit: 326f8f68f28b0b831233acfabffb486a5b0f4717

Comments

Jeff Johnson April 29, 2024, 9:34 p.m. UTC | #1
On 4/29/2024 10:38 AM, Ramya Gnanasekar wrote:
> Bring in the basic infrastructure necessary for enabling htt_stats via debugfs.
> Patch series bring support to request stats type to firmware,
> dump the stats and request to reset the stats from firmware.
> 
> Schema with one ath12k device:
> 
> ath12k
> `-- pci-0000:06:00.0
>     |-- mac0
>         `-- htt_stats
>         |-- htt_stats_type
>         |-- htt_stats_reset
> 
> Dinesh Karthikeyan (3):
>   wifi: ath12k: Add support to enable debugfs_htt_stats
>   wifi: ath12k: Add htt_stats_dump file ops support
>   wifi: ath12k: Add support to parse requested stats_type
> 
> Ramya Gnanasekar (1):
>   wifi: ath12k: Dump additional Tx PDEV HTT stats
> 
>  drivers/net/wireless/ath/ath12k/Makefile      |   2 +-
>  drivers/net/wireless/ath/ath12k/core.h        |  11 +
>  drivers/net/wireless/ath/ath12k/debugfs.c     |   3 +
>  .../wireless/ath/ath12k/debugfs_htt_stats.c   | 713 ++++++++++++++++++
>  .../wireless/ath/ath12k/debugfs_htt_stats.h   | 300 ++++++++
>  drivers/net/wireless/ath/ath12k/dp_rx.c       |  10 +-
>  drivers/net/wireless/ath/ath12k/dp_rx.h       |   4 +
>  7 files changed, 1038 insertions(+), 5 deletions(-)
>  create mode 100644 drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
>  create mode 100644 drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
> 
> 
> base-commit: 326f8f68f28b0b831233acfabffb486a5b0f4717

testing on my laptop

good news is the files are being populated:
# ls /sys/kernel/debug/ath12k/pci-0000\:03\:00.0/mac0/
dfs_simulate_radar  htt_stats  htt_stats_reset  htt_stats_type

bad news is:
# echo 1 > /sys/kernel/debug/ath12k/pci-0000\:03\:00.0/mac0/htt_stats_type
# cat /sys/kernel/debug/ath12k/pci-0000\:03\:00.0/mac0/htt_stats
cat: '/sys/kernel/debug/ath12k/pci-0000:03:00.0/mac0/htt_stats': Connection timed out

journalctl shows:
Apr 29 14:17:16 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: htc rx completion ep 2 skb ffff8c4e50e5ed00
Apr 29 14:17:19 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: stats request timed out

so something isn't right, at least for WCN7850

has this been tested with upstream kernel?
Ramya Gnanasekar April 30, 2024, 5:25 p.m. UTC | #2
> -----Original Message-----
> From: Jeff Johnson (QUIC) <quic_jjohnson@quicinc.com>
> Sent: Tuesday, April 30, 2024 3:05 AM
> To: Ramya Gnanasekar (Temp) (QUIC) <quic_rgnanase@quicinc.com>;
> ath12k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: Re: [PATCH 0/4] wifi: ath12k: Add support to enable debugfs_htt_stats
> 
> On 4/29/2024 10:38 AM, Ramya Gnanasekar wrote:
> > Bring in the basic infrastructure necessary for enabling htt_stats via debugfs.
> > Patch series bring support to request stats type to firmware, dump the
> > stats and request to reset the stats from firmware.
> >
> > Schema with one ath12k device:
> >
> > ath12k
> > `-- pci-0000:06:00.0
> >     |-- mac0
> >         `-- htt_stats
> >         |-- htt_stats_type
> >         |-- htt_stats_reset
> >
> > Dinesh Karthikeyan (3):
> >   wifi: ath12k: Add support to enable debugfs_htt_stats
> >   wifi: ath12k: Add htt_stats_dump file ops support
> >   wifi: ath12k: Add support to parse requested stats_type
> >
> > Ramya Gnanasekar (1):
> >   wifi: ath12k: Dump additional Tx PDEV HTT stats
> >
> >  drivers/net/wireless/ath/ath12k/Makefile      |   2 +-
> >  drivers/net/wireless/ath/ath12k/core.h        |  11 +
> >  drivers/net/wireless/ath/ath12k/debugfs.c     |   3 +
> >  .../wireless/ath/ath12k/debugfs_htt_stats.c   | 713 ++++++++++++++++++
> >  .../wireless/ath/ath12k/debugfs_htt_stats.h   | 300 ++++++++
> >  drivers/net/wireless/ath/ath12k/dp_rx.c       |  10 +-
> >  drivers/net/wireless/ath/ath12k/dp_rx.h       |   4 +
> >  7 files changed, 1038 insertions(+), 5 deletions(-)  create mode
> > 100644 drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> >  create mode 100644
> > drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
> >
> >
> > base-commit: 326f8f68f28b0b831233acfabffb486a5b0f4717
> 
> testing on my laptop
> 
> good news is the files are being populated:
> # ls /sys/kernel/debug/ath12k/pci-0000\:03\:00.0/mac0/
> dfs_simulate_radar  htt_stats  htt_stats_reset  htt_stats_type
> 
> bad news is:
> # echo 1 > /sys/kernel/debug/ath12k/pci-0000\:03\:00.0/mac0/htt_stats_type
> # cat /sys/kernel/debug/ath12k/pci-0000\:03\:00.0/mac0/htt_stats
> cat: '/sys/kernel/debug/ath12k/pci-0000:03:00.0/mac0/htt_stats': Connection
> timed out
> 
> journalctl shows:
> Apr 29 14:17:16 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: htc rx
> completion ep 2 skb ffff8c4e50e5ed00 Apr 29 14:17:19 qca-HP-ZBook-14-G2
> kernel: ath12k_pci 0000:03:00.0: stats request timed out
> 
> so something isn't right, at least for WCN7850
> 
> has this been tested with upstream kernel?

Tested on QCN9274 upstream kernel. HTT stats event is not received by host upon stats request.
Will check further on this.