mbox series

[0/4] wifi: ath12k: Add multi device support for WBM idle ring buffer setup

Message ID 20240430054759.722620-1-quic_periyasa@quicinc.com (mailing list archive)
Headers show
Series wifi: ath12k: Add multi device support for WBM idle ring buffer setup | expand

Message

Karthikeyan Periyasamy April 30, 2024, 5:47 a.m. UTC 
Refactor the WBM idle ring buffer setup to scalable for inter device
multi-link operation.

Note: This patchset rebased on top of below patch series
 [PATCH v2 0/8] wifi: ath12k: Introduce device group abstraction
 Link: https://lore.kernel.org/all/20240425055759.1181165-1-quic_hprem@quicinc.com/

Karthikeyan Periyasamy (4):
  wifi: ath12k: Replace "chip" with "device" in hal Rx return buffer
    manager
  wifi: ath12k: Refactor idle ring descriptor setup
  wifi: ath12k: use device index to advertise MLO parameter
  wifi: ath12k: add multi device support for WBM idle ring buffer setup

 drivers/net/wireless/ath/ath12k/core.c  | 10 +++++++++
 drivers/net/wireless/ath/ath12k/dp.c    | 27 ++++++++++++++++++++++---
 drivers/net/wireless/ath/ath12k/dp.h    |  1 +
 drivers/net/wireless/ath/ath12k/dp_rx.c |  5 +++--
 drivers/net/wireless/ath/ath12k/hal.c   |  5 +++--
 drivers/net/wireless/ath/ath12k/hal.h   | 21 ++++++++++---------
 drivers/net/wireless/ath/ath12k/qmi.c   |  4 ++--
 7 files changed, 54 insertions(+), 19 deletions(-)


base-commit: 861928281f22a08e3d258ebcfe7159d729ec07d4
prerequisite-patch-id: 4bc84a4f5b10ebc28db60c5167abdaf343a1619d
prerequisite-patch-id: ea87d2f46dbd5e7c82d5df02934906e219aa8388
prerequisite-patch-id: e08d8632dcde9e891d37b538832b4ecfed140d9e
prerequisite-patch-id: bc2c9455c9175c27b8b68f6f41d468b258007478
prerequisite-patch-id: 00966c65589af8a50078fea94630cbe355f0dacf
prerequisite-patch-id: 4bd8ce903cd89ae536109922f65f128ed1d4307c
prerequisite-patch-id: 54fe8eb540a77804c8befeb695b61756c133b56f
prerequisite-patch-id: 06244ca08d9bed3834dc5315470a19d096d749ee
prerequisite-patch-id: 8e7575808b1c498d81b606777153e0e2d4ee99bd
prerequisite-patch-id: 1baa4ce64b2054e82e117cfbe29f85870def37c7
prerequisite-patch-id: 733cb4a1e0d02079820d8306a3da88fe2d35b06c

Comments

Jeff Johnson April 30, 2024, 4:08 p.m. UTC | #1 
On 4/29/2024 10:47 PM, Karthikeyan Periyasamy wrote:
> Refactor the WBM idle ring buffer setup to scalable for inter device
> multi-link operation.
> 
> Note: This patchset rebased on top of below patch series
>  [PATCH v2 0/8] wifi: ath12k: Introduce device group abstraction
>  Link: https://lore.kernel.org/all/20240425055759.1181165-1-quic_hprem@quicinc.com/
> 
> Karthikeyan Periyasamy (4):
>   wifi: ath12k: Replace "chip" with "device" in hal Rx return buffer
>     manager
>   wifi: ath12k: Refactor idle ring descriptor setup
>   wifi: ath12k: use device index to advertise MLO parameter
>   wifi: ath12k: add multi device support for WBM idle ring buffer setup
> 
>  drivers/net/wireless/ath/ath12k/core.c  | 10 +++++++++
>  drivers/net/wireless/ath/ath12k/dp.c    | 27 ++++++++++++++++++++++---
>  drivers/net/wireless/ath/ath12k/dp.h    |  1 +
>  drivers/net/wireless/ath/ath12k/dp_rx.c |  5 +++--
>  drivers/net/wireless/ath/ath12k/hal.c   |  5 +++--
>  drivers/net/wireless/ath/ath12k/hal.h   | 21 ++++++++++---------
>  drivers/net/wireless/ath/ath12k/qmi.c   |  4 ++--
>  7 files changed, 54 insertions(+), 19 deletions(-)
> 
> 
> base-commit: 861928281f22a08e3d258ebcfe7159d729ec07d4
> prerequisite-patch-id: 4bc84a4f5b10ebc28db60c5167abdaf343a1619d
> prerequisite-patch-id: ea87d2f46dbd5e7c82d5df02934906e219aa8388
> prerequisite-patch-id: e08d8632dcde9e891d37b538832b4ecfed140d9e
> prerequisite-patch-id: bc2c9455c9175c27b8b68f6f41d468b258007478
> prerequisite-patch-id: 00966c65589af8a50078fea94630cbe355f0dacf
> prerequisite-patch-id: 4bd8ce903cd89ae536109922f65f128ed1d4307c
> prerequisite-patch-id: 54fe8eb540a77804c8befeb695b61756c133b56f
> prerequisite-patch-id: 06244ca08d9bed3834dc5315470a19d096d749ee
> prerequisite-patch-id: 8e7575808b1c498d81b606777153e0e2d4ee99bd
> prerequisite-patch-id: 1baa4ce64b2054e82e117cfbe29f85870def37c7
> prerequisite-patch-id: 733cb4a1e0d02079820d8306a3da88fe2d35b06c

My automation can't test this series since git reports:
fatal: bad object 861928281f22a08e3d258ebcfe7159d729ec07d4

Also note that the "device group abstraction" series itself has dependencies.

Using a base that isn't visible in the upstream ath.git is not helpful

/jeff
Karthikeyan Periyasamy April 30, 2024, 4:16 p.m. UTC | #2 
On 4/30/2024 9:38 PM, Jeff Johnson wrote:
> On 4/29/2024 10:47 PM, Karthikeyan Periyasamy wrote:
>> Refactor the WBM idle ring buffer setup to scalable for inter device
>> multi-link operation.
>>
>> Note: This patchset rebased on top of below patch series
>>   [PATCH v2 0/8] wifi: ath12k: Introduce device group abstraction
>>   Link: https://lore.kernel.org/all/20240425055759.1181165-1-quic_hprem@quicinc.com/
>>
>> Karthikeyan Periyasamy (4):
>>    wifi: ath12k: Replace "chip" with "device" in hal Rx return buffer
>>      manager
>>    wifi: ath12k: Refactor idle ring descriptor setup
>>    wifi: ath12k: use device index to advertise MLO parameter
>>    wifi: ath12k: add multi device support for WBM idle ring buffer setup
>>
>>   drivers/net/wireless/ath/ath12k/core.c  | 10 +++++++++
>>   drivers/net/wireless/ath/ath12k/dp.c    | 27 ++++++++++++++++++++++---
>>   drivers/net/wireless/ath/ath12k/dp.h    |  1 +
>>   drivers/net/wireless/ath/ath12k/dp_rx.c |  5 +++--
>>   drivers/net/wireless/ath/ath12k/hal.c   |  5 +++--
>>   drivers/net/wireless/ath/ath12k/hal.h   | 21 ++++++++++---------
>>   drivers/net/wireless/ath/ath12k/qmi.c   |  4 ++--
>>   7 files changed, 54 insertions(+), 19 deletions(-)
>>
>>
>> base-commit: 861928281f22a08e3d258ebcfe7159d729ec07d4
>> prerequisite-patch-id: 4bc84a4f5b10ebc28db60c5167abdaf343a1619d
>> prerequisite-patch-id: ea87d2f46dbd5e7c82d5df02934906e219aa8388
>> prerequisite-patch-id: e08d8632dcde9e891d37b538832b4ecfed140d9e
>> prerequisite-patch-id: bc2c9455c9175c27b8b68f6f41d468b258007478
>> prerequisite-patch-id: 00966c65589af8a50078fea94630cbe355f0dacf
>> prerequisite-patch-id: 4bd8ce903cd89ae536109922f65f128ed1d4307c
>> prerequisite-patch-id: 54fe8eb540a77804c8befeb695b61756c133b56f
>> prerequisite-patch-id: 06244ca08d9bed3834dc5315470a19d096d749ee
>> prerequisite-patch-id: 8e7575808b1c498d81b606777153e0e2d4ee99bd
>> prerequisite-patch-id: 1baa4ce64b2054e82e117cfbe29f85870def37c7
>> prerequisite-patch-id: 733cb4a1e0d02079820d8306a3da88fe2d35b06c
> 
> My automation can't test this series since git reports:
> fatal: bad object 861928281f22a08e3d258ebcfe7159d729ec07d4
> 
> Also note that the "device group abstraction" series itself has dependencies.
> 
> Using a base that isn't visible in the upstream ath.git is not helpful
> 

Looks like "device group abstraction" patch is block due to warning call 
trace. Shall i remove the dependency and make the "device group 
abstraction" patch depend on this series ?
Karthikeyan Periyasamy April 30, 2024, 4:57 p.m. UTC | #3 
On 4/30/2024 9:46 PM, Karthikeyan Periyasamy wrote:
> 
> 
> On 4/30/2024 9:38 PM, Jeff Johnson wrote:
>> On 4/29/2024 10:47 PM, Karthikeyan Periyasamy wrote:
>>> Refactor the WBM idle ring buffer setup to scalable for inter device
>>> multi-link operation.
>>>
>>> Note: This patchset rebased on top of below patch series
>>>   [PATCH v2 0/8] wifi: ath12k: Introduce device group abstraction
>>>   Link: 
>>> https://lore.kernel.org/all/20240425055759.1181165-1-quic_hprem@quicinc.com/
>>>
>>> Karthikeyan Periyasamy (4):
>>>    wifi: ath12k: Replace "chip" with "device" in hal Rx return buffer
>>>      manager
>>>    wifi: ath12k: Refactor idle ring descriptor setup
>>>    wifi: ath12k: use device index to advertise MLO parameter
>>>    wifi: ath12k: add multi device support for WBM idle ring buffer setup
>>>
>>>   drivers/net/wireless/ath/ath12k/core.c  | 10 +++++++++
>>>   drivers/net/wireless/ath/ath12k/dp.c    | 27 ++++++++++++++++++++++---
>>>   drivers/net/wireless/ath/ath12k/dp.h    |  1 +
>>>   drivers/net/wireless/ath/ath12k/dp_rx.c |  5 +++--
>>>   drivers/net/wireless/ath/ath12k/hal.c   |  5 +++--
>>>   drivers/net/wireless/ath/ath12k/hal.h   | 21 ++++++++++---------
>>>   drivers/net/wireless/ath/ath12k/qmi.c   |  4 ++--
>>>   7 files changed, 54 insertions(+), 19 deletions(-)
>>>
>>>
>>> base-commit: 861928281f22a08e3d258ebcfe7159d729ec07d4
>>> prerequisite-patch-id: 4bc84a4f5b10ebc28db60c5167abdaf343a1619d
>>> prerequisite-patch-id: ea87d2f46dbd5e7c82d5df02934906e219aa8388
>>> prerequisite-patch-id: e08d8632dcde9e891d37b538832b4ecfed140d9e
>>> prerequisite-patch-id: bc2c9455c9175c27b8b68f6f41d468b258007478
>>> prerequisite-patch-id: 00966c65589af8a50078fea94630cbe355f0dacf
>>> prerequisite-patch-id: 4bd8ce903cd89ae536109922f65f128ed1d4307c
>>> prerequisite-patch-id: 54fe8eb540a77804c8befeb695b61756c133b56f
>>> prerequisite-patch-id: 06244ca08d9bed3834dc5315470a19d096d749ee
>>> prerequisite-patch-id: 8e7575808b1c498d81b606777153e0e2d4ee99bd
>>> prerequisite-patch-id: 1baa4ce64b2054e82e117cfbe29f85870def37c7
>>> prerequisite-patch-id: 733cb4a1e0d02079820d8306a3da88fe2d35b06c
>>
>> My automation can't test this series since git reports:
>> fatal: bad object 861928281f22a08e3d258ebcfe7159d729ec07d4
>>
>> Also note that the "device group abstraction" series itself has 
>> dependencies.
>>
>> Using a base that isn't visible in the upstream ath.git is not helpful
>>
> 
> Looks like "device group abstraction" patch is block due to warning call 
> trace. Shall i remove the dependency and make the "device group 
> abstraction" patch depend on this series ?
> 

sent the next version by removing the dependency.