mbox series

[v2,00/22] wifi: ath12k: add Ath12k AHB driver support for IPQ5332

Message ID 20241015182637.955753-1-quic_rajkbhag@quicinc.com (mailing list archive)
Headers show
Series wifi: ath12k: add Ath12k AHB driver support for IPQ5332 | expand

Message

Raj Kumar Bhagat Oct. 15, 2024, 6:26 p.m. UTC 
Currently, Ath12k driver only supports WiFi devices that are based on
PCI bus. New Ath12k device IPQ5332 is based on AHB bus. Hence, add
Ath12k AHB support for IPQ5332.

IPQ5332 is IEEE802.11be 2 GHz 2x2 Wifi device. To bring-up IPQ5332
device:
- Add hardware parameters for IPQ5332.
- CE and CMEM register address space in IPQ5332 is separate from WCSS
  register space. Hence, add logic to remap CE and CMEM register
  address.
- Add support for fixed QMI firmware memory for IPQ5332.
- Support userPD handling for WCSS secure PIL driver to enable ath12k
  AHB support.

Depends-On: [PATCH V7 0/5] remove unnecessary q6 clocks
Depends-On: [PATCH V2 0/4] Add new driver for WCSS secure PIL loading
Link: https://lore.kernel.org/all/20240820055618.267554-1-quic_gokulsri@quicinc.com/
Link: https://lore.kernel.org/all/20240829134021.1452711-1-quic_gokulsri@quicinc.com/

Balamurugan S (9):
  wifi: ath12k: add ath12k_hw_params for IPQ5332
  wifi: ath12k: add ath12k_hw_hal_params for IPQ5332
  wifi: ath12k: avoid m3 firmware download in AHB device IPQ5332
  wifi: ath12k: add new CMEM read-write ath12k_hif_ops
  wifi: ath12k: remap CMEM register space for IPQ5332
  wifi: ath12k: fix incorrect CE addresses
  wifi: ath12k: remap CE register space for IPQ5332
  wifi: ath12k: add AHB driver support for IPQ5332
  wifi: ath12k: enable ath12k AHB support

P Praneesh (4):
  wifi: ath12k: refactor ath12k_hw_regs structure
  wifi: ath12k: add ath12k_hw_regs for IPQ5332
  wifi: ath12k: add ath12k_hw_ring_mask for IPQ5332
  wifi: ath12k: add CE configurations for IPQ5332

Raj Kumar Bhagat (5):
  dt-bindings: net: wireless: describe the ath12k AHB module
  arm64: dts: qcom: add wifi node for IPQ5332 based RDP441
  wifi: ath12k: add support for fixed QMI firmware memory
  wifi: ath12k: add BDF address in hardware parameter
  wifi: ath12k: convert tasklet to BH workqueue for CE interrupts

Sowmiya Sree Elavalagan (4):
  wifi: ath12k: Power up root PD
  wifi: ath12k: Register various userPD interrupts and save SMEM entries
  wifi: ath12k: Power up userPD
  wifi: ath12k: Power down userPD
---
v2:
- Integrated the “Support userPD handling for WCSS secure PIL driver”
  patch series with the Ath12k AHB bring-up patch.
- Updated DT binding and DTS files to align with the new Rproc design.
- Addressed review comments on RFC patch series v1 of
  “wifi: ath12k: add Ath12k AHB driver support for IPQ5332”.
- Removed the RFC tag as all dependency patch series are now compilable.

v1: https://patchwork.kernel.org/project/linux-wireless/cover/20240814094323.3927603-1-quic_rajkbhag@quicinc.com/
---
 .../net/wireless/qcom,ath12k-ahb.yaml         |  293 ++++
 arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts   |   59 +-
 arch/arm64/boot/dts/qcom/ipq5332.dtsi         |  108 +-
 drivers/net/wireless/ath/ath12k/Kconfig       |    6 +
 drivers/net/wireless/ath/ath12k/Makefile      |    1 +
 drivers/net/wireless/ath/ath12k/ahb.c         | 1326 +++++++++++++++++
 drivers/net/wireless/ath/ath12k/ahb.h         |   80 +
 drivers/net/wireless/ath/ath12k/ce.c          |   90 ++
 drivers/net/wireless/ath/ath12k/ce.h          |   18 +-
 drivers/net/wireless/ath/ath12k/core.c        |   35 +-
 drivers/net/wireless/ath/ath12k/core.h        |   19 +-
 drivers/net/wireless/ath/ath12k/dp.c          |   10 +-
 drivers/net/wireless/ath/ath12k/hal.c         |   82 +-
 drivers/net/wireless/ath/ath12k/hal.h         |   69 +-
 drivers/net/wireless/ath/ath12k/hif.h         |   13 +
 drivers/net/wireless/ath/ath12k/hw.c          |  482 ++++++
 drivers/net/wireless/ath/ath12k/hw.h          |   16 +
 drivers/net/wireless/ath/ath12k/pci.c         |   28 +-
 drivers/net/wireless/ath/ath12k/pci.h         |    2 +
 drivers/net/wireless/ath/ath12k/qmi.c         |  169 ++-
 drivers/net/wireless/ath/ath12k/qmi.h         |    1 +
 21 files changed, 2793 insertions(+), 114 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
 create mode 100644 drivers/net/wireless/ath/ath12k/ahb.c
 create mode 100644 drivers/net/wireless/ath/ath12k/ahb.h


base-commit: 69eabe24843f238e79a6dbbd2b3fcc8eef39d6b8
prerequisite-patch-id: bfefff55ba6a3fdf8930b3b4d48746bc9cd5a0a0
prerequisite-patch-id: 9e143f9cd10add55d2fd52bac0e538b904d6dee5
prerequisite-patch-id: cb987ee3dbc145fee1135307badb61c0e21f0ccd
prerequisite-patch-id: 14b990ceacec658b924c78d91ce33b45f70ca112
prerequisite-patch-id: b1f6cc6ae066f3e10b5626ff0af3267449d613d3
prerequisite-patch-id: be810c2435b44ea08527d739510d18770e732dfa
prerequisite-patch-id: 1a946f3d5f563f0de825606b276dbaee695aa5b8
prerequisite-patch-id: 97f4a586c7040822e0e7977bd1599333ad02237b
prerequisite-patch-id: bc306b2998d1afe66757052e33dc685ae4e7a627

Comments

Krzysztof Kozlowski Oct. 16, 2024, 6:57 a.m. UTC | #1 
On Tue, Oct 15, 2024 at 11:56:15PM +0530, Raj Kumar Bhagat wrote:
> Currently, Ath12k driver only supports WiFi devices that are based on
> PCI bus. New Ath12k device IPQ5332 is based on AHB bus. Hence, add
> Ath12k AHB support for IPQ5332.
> 
> IPQ5332 is IEEE802.11be 2 GHz 2x2 Wifi device. To bring-up IPQ5332
> device:
> - Add hardware parameters for IPQ5332.
> - CE and CMEM register address space in IPQ5332 is separate from WCSS
>   register space. Hence, add logic to remap CE and CMEM register
>   address.
> - Add support for fixed QMI firmware memory for IPQ5332.
> - Support userPD handling for WCSS secure PIL driver to enable ath12k
>   AHB support.
> 
> Depends-On: [PATCH V7 0/5] remove unnecessary q6 clocks
> Depends-On: [PATCH V2 0/4] Add new driver for WCSS secure PIL loading
> Link: https://lore.kernel.org/all/20240820055618.267554-1-quic_gokulsri@quicinc.com/
> Link: https://lore.kernel.org/all/20240829134021.1452711-1-quic_gokulsri@quicinc.com/


These are series targetting other subsystems. I do not understand why
you created such dependency. It does not look needed and for sure is not
good: nothing here can be tested, nothing can be applied.

Best regards,
Krzysztof