mbox series

[RFC,0/5] wifi: cfg80211/mac80211: Set/get wiphy parameters on per-radio basis

Message ID 20250107182506.1838704-1-quic_ramess@quicinc.com (mailing list archive)
Headers show
Series wifi: cfg80211/mac80211: Set/get wiphy parameters on per-radio basis | expand

Message

Rameshkumar Sundaram Jan. 7, 2025, 6:25 p.m. UTC
Currently wiphy level configurations like RTS threshold, TX power etc.
lacks radio level get/set support and same value is applied to all radios
of wiphy. Add support to parse radio id attribute and use the same to
apply the configuration to corresponding radio of a multi radio wiphy.

This design will not disturb the global wiphy configuration. If radio id is
not passed from userspace, then the existing design of setting attribute to
all the radios will hold good.
Also add support to get the radio specific attributes in a multi-radio
wiphy from userspace.

Note:
This is design proposal to extend support to set RTS threshold/tx power for
each radio and get the same from the userspace and hence sent as RFC.
If we agree on this design, all per-radio attributes supported in wiphy
can follow this design to modify attributes for a specific radio without
disturbing other radios in the wiphy.

The attributes that can be handled for each radio are:
NL80211_ATTR_WIPHY_FREQ
NL80211_ATTR_WIPHY_ANTENNA_TX
NL80211_ATTR_WIPHY_ANTENNA_RX
NL80211_ATTR_WIPHY_RETRY_SHORT
NL80211_ATTR_WIPHY_RETRY_LONG
NL80211_ATTR_WIPHY_FRAG_THRESHOLD
NL80211_ATTR_WIPHY_RTS_THRESHOLD
NL80211_ATTR_WIPHY_COVERAGE_CLASS
NL80211_ATTR_WIPHY_DYN_AC

With this design, the new userspace designed to set/get per-radio
parameters can work with both traditional and multi-radio wiphys.

An alternate design is to allow multiple radios to be configured with
different per-radio attributes in a single command. To achieve this,
a new nested attribute can be added to hold all per-radio attributes
for all the radios in multi-radio wiphy. The attributes and respective
values passed from userspace (say iw) can be parsed in NL80211 and for
each attribute, corresponding handlers can be called in iteration for
each radio. This design will require adding an attribute indicating index
of the radio along with the nested attribute to circle down the radio of
interest.

Rameshkumar Sundaram (2):
  wifi: cfg80211: set tx power per radio in a wiphy
  wifi: mac80211: set tx power per radio in a wiphy

Roopni Devanathan (3):
  wifi: cfg80211: Add Support to Set RTS Threshold for each Radio
  wifi: cfg80211: Report per-radio RTS threshold to userspace
  wifi: mac80211: Set RTS threshold on per-radio basis

 drivers/net/wireless/ath/ath6kl/cfg80211.c    |  3 +-
 drivers/net/wireless/ath/wil6210/cfg80211.c   |  2 +-
 .../broadcom/brcm80211/brcmfmac/cfg80211.c    |  4 +-
 .../net/wireless/marvell/mwifiex/cfg80211.c   |  4 +-
 .../wireless/microchip/wilc1000/cfg80211.c    |  4 +-
 .../net/wireless/quantenna/qtnfmac/cfg80211.c |  4 +-
 drivers/net/wireless/virtual/mac80211_hwsim.c |  3 +-
 .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c |  4 +-
 include/net/cfg80211.h                        | 23 ++++++-
 include/net/mac80211.h                        |  2 +-
 include/uapi/linux/nl80211.h                  | 14 ++++
 net/mac80211/cfg.c                            | 25 ++++++-
 net/mac80211/driver-ops.h                     |  6 +-
 net/mac80211/trace.h                          | 24 ++++++-
 net/mac80211/util.c                           |  7 +-
 net/wireless/core.c                           | 18 +++++
 net/wireless/nl80211.c                        | 67 +++++++++++++++----
 net/wireless/rdev-ops.h                       | 12 ++--
 net/wireless/trace.h                          | 16 +++--
 net/wireless/wext-compat.c                    | 11 +--
 20 files changed, 197 insertions(+), 56 deletions(-)


base-commit: b73e56f16250c6124f8975636f1844472f6fd450