| Message ID | 20250408-fix_reboot_issues_with_hw_grouping-v4-0-95e7bf048595@oss.qualcomm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | wifi: ath12k: fixes for rmmod and recovery issues with hardware grouping | expand |
On Tue, 08 Apr 2025 11:36:28 +0530, Aditya Kumar Singh wrote: > With hardware grouping, there is a kernel crash with signature - > > $ rmmod ath12k.ko > Unable to handle kernel paging request at virtual address 000000000000d1a8 > [...] > Call trace: > ath12k_reg_free+0x14/0x74 [ath12k] (P) > ath12k_core_hw_group_destroy+0x7c/0xb4 [ath12k] (L) > ath12k_core_hw_group_destroy+0x7c/0xb4 [ath12k] > ath12k_core_deinit+0xd8/0x124 [ath12k] > ath12k_pci_remove+0x6c/0x130 [ath12k] > pci_device_remove+0x44/0xe8 > device_remove+0x4c/0x80 > device_release_driver_internal+0x1d0/0x22c > driver_detach+0x50/0x98 > bus_remove_driver+0x70/0xf4 > driver_unregister+0x30/0x60 > pci_unregister_driver+0x24/0x9c > ath12k_pci_exit+0x18/0x24 [ath12k] > __arm64_sys_delete_module+0x1a0/0x2a8 > invoke_syscall+0x48/0x110 > el0_svc_common.constprop.0+0x40/0xe0 > do_el0_svc+0x1c/0x28 > el0_svc+0x30/0xd0 > el0t_64_sync_handler+0x10c/0x138 > el0t_64_sync+0x198/0x19c > Code: a9bd7bfd 910003fd a9025bf5 91402015 (f968d6a1) > ---[ end trace 0000000000000000 ]--- > Segmentation fault > > [...] Applied, thanks! [1/9] wifi: ath12k: fix SLUB BUG - Object already free in ath12k_reg_free() commit: 6d019abc402f58b25a7cab30b2d9af2f3173e4df [2/9] wifi: ath12k: add reference counting for core attachment to hardware group commit: 62f3878fa290cb21535459311fe1dc008cd381da [3/9] wifi: ath12k: fix failed to set mhi state error during reboot with hardware grouping commit: dce7aec6b1f74b0a46b901ab8de1f7bd0515f733 [4/9] wifi: ath12k: fix ATH12K_FLAG_REGISTERED flag handling commit: 6af396942bf132a1a49523e8fe2f816dc1ebd913 [5/9] wifi: ath12k: fix firmware assert during reboot with hardware grouping commit: 1d55625bc2a1c2a8c68153b020e1e097ea27f1b0 [6/9] wifi: ath12k: fix ath12k_core_pre_reconfigure_recovery() with grouping commit: 718ead261feba32b00f8ef1d3dff7527106b9458 [7/9] wifi: ath12k: handle ath12k_core_restart() with hardware grouping commit: 3e1312f01b508d3f77147bec5286caef074e5d9e [8/9] wifi: ath12k: handle ath12k_core_reset() with hardware grouping commit: 929069c1bdb70c6332c15f3978d4c8830bc43efd [9/9] wifi: ath12k: reset MLO global memory during recovery commit: f5755c23ed8a4603194f6425828a2760f814e117 Best regards,
With hardware grouping, there is a kernel crash with signature - $ rmmod ath12k.ko Unable to handle kernel paging request at virtual address 000000000000d1a8 [...] Call trace: ath12k_reg_free+0x14/0x74 [ath12k] (P) ath12k_core_hw_group_destroy+0x7c/0xb4 [ath12k] (L) ath12k_core_hw_group_destroy+0x7c/0xb4 [ath12k] ath12k_core_deinit+0xd8/0x124 [ath12k] ath12k_pci_remove+0x6c/0x130 [ath12k] pci_device_remove+0x44/0xe8 device_remove+0x4c/0x80 device_release_driver_internal+0x1d0/0x22c driver_detach+0x50/0x98 bus_remove_driver+0x70/0xf4 driver_unregister+0x30/0x60 pci_unregister_driver+0x24/0x9c ath12k_pci_exit+0x18/0x24 [ath12k] __arm64_sys_delete_module+0x1a0/0x2a8 invoke_syscall+0x48/0x110 el0_svc_common.constprop.0+0x40/0xe0 do_el0_svc+0x1c/0x28 el0_svc+0x30/0xd0 el0t_64_sync_handler+0x10c/0x138 el0t_64_sync+0x198/0x19c Code: a9bd7bfd 910003fd a9025bf5 91402015 (f968d6a1) ---[ end trace 0000000000000000 ]--- Segmentation fault This series aims to fix this stability issue. With this now, 100+ iteration of rmmod and insmod works perfectly. Also, firmware recovery with grouping is not working fine. Randomly, some NULL pointer crash or another firmware assert is seen. This series aims to fix that as well. With this in place now, 100+ iteration of firmware recovery with one 3 link AP MLD up works fine. --- Changes in v4: - Rebased on ToT. - Fixed potential deadlock warning. - Moved to oss email from quicinc. - Link to v3: https://lore.kernel.org/r/20250124-fix_reboot_issues_with_hw_grouping-v3-0-329030b18d9e@quicinc.com Changes in v3: - Rebased on ToT due to FTM changes conflict. - Link to v2: https://lore.kernel.org/r/20250120-fix_reboot_issues_with_hw_grouping-v2-0-b7d073bb2a22@quicinc.com Changes in v2: - Rebased on ToT. - No changes in 1-4, 6-10. - Removed regd_freed flag in 5. - Link to v1: https://lore.kernel.org/r/20250109-fix_reboot_issues_with_hw_grouping-v1-0-fb39ec03451e@quicinc.com --- Aditya Kumar Singh (9): wifi: ath12k: fix SLUB BUG - Object already free in ath12k_reg_free() wifi: ath12k: add reference counting for core attachment to hardware group wifi: ath12k: fix failed to set mhi state error during reboot with hardware grouping wifi: ath12k: fix ATH12K_FLAG_REGISTERED flag handling wifi: ath12k: fix firmware assert during reboot with hardware grouping wifi: ath12k: fix ath12k_core_pre_reconfigure_recovery() with grouping wifi: ath12k: handle ath12k_core_restart() with hardware grouping wifi: ath12k: handle ath12k_core_reset() with hardware grouping wifi: ath12k: reset MLO global memory during recovery drivers/net/wireless/ath/ath12k/core.c | 110 ++++++++++++++++++++++++++++++--- drivers/net/wireless/ath/ath12k/core.h | 15 +---- drivers/net/wireless/ath/ath12k/mac.c | 6 -- drivers/net/wireless/ath/ath12k/pci.c | 26 +++++++- drivers/net/wireless/ath/ath12k/qmi.c | 22 +++++++ drivers/net/wireless/ath/ath12k/qmi.h | 2 + drivers/net/wireless/ath/ath12k/reg.c | 4 ++ 7 files changed, 156 insertions(+), 29 deletions(-) --- base-commit: ac17b1211841c98a9b4c2900ba2a7f457c80cf90 change-id: 20241218-fix_reboot_issues_with_hw_grouping-0c2d367a587b