| Message ID | cover.f21c8e62e188620d586edb3f77514e6237122c4c.1541238842.git-series.plaes@plaes.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Use common cordic algorithm for b43 | expand |
Priit Laes <plaes@plaes.org> writes: > b43 wireless driver included internal implementation of cordic > algorithm which has now been removed in favor of library > implementation. > > During the process, brcmfmac was driver was also cleaned. > > Please note that this series is only compile-tested, as I > do not have access to the hardware. > > Priit Laes (5): > lib: cordic: Move cordic macros and defines to header file > brcmfmac: Use common CORDIC_FLOAT macro from lib > brcmfmac: Drop unused cordic defines and macros > b43: Use common cordic algorithm from kernel lib > b43: Drop internal cordic algorithm implementation > > drivers/net/wireless/broadcom/b43/Kconfig | 1 +- > drivers/net/wireless/broadcom/b43/phy_common.c | 47 +------- > drivers/net/wireless/broadcom/b43/phy_common.h | 9 +- > drivers/net/wireless/broadcom/b43/phy_lp.c | 13 +- > drivers/net/wireless/broadcom/b43/phy_n.c | 13 +- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h | 7 +- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 4 +- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 4 +- > include/linux/cordic.h | 9 +- > lib/cordic.c | 23 +--- > 10 files changed, 35 insertions(+), 95 deletions(-) I don't see patch 1 in linux-wireless patchwork: https://patchwork.kernel.org/project/linux-wireless/list/?series=38033&state=* Via which tree are you planning to push these? These could potentially go via my wireless-drivers-next tree (if review goes ok) but I need to have all five patches in patchwork. Also I don't see MAINTAINERS entry for cordic.[c|h], that would be good to have as well.
Kalle Valo <kvalo@codeaurora.org> writes: > Priit Laes <plaes@plaes.org> writes: > >> b43 wireless driver included internal implementation of cordic >> algorithm which has now been removed in favor of library >> implementation. >> >> During the process, brcmfmac was driver was also cleaned. >> >> Please note that this series is only compile-tested, as I >> do not have access to the hardware. >> >> Priit Laes (5): >> lib: cordic: Move cordic macros and defines to header file >> brcmfmac: Use common CORDIC_FLOAT macro from lib >> brcmfmac: Drop unused cordic defines and macros >> b43: Use common cordic algorithm from kernel lib >> b43: Drop internal cordic algorithm implementation >> >> drivers/net/wireless/broadcom/b43/Kconfig | 1 +- >> drivers/net/wireless/broadcom/b43/phy_common.c | 47 +------- >> drivers/net/wireless/broadcom/b43/phy_common.h | 9 +- >> drivers/net/wireless/broadcom/b43/phy_lp.c | 13 +- >> drivers/net/wireless/broadcom/b43/phy_n.c | 13 +- >> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h | 7 +- >> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 4 +- >> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 4 +- >> include/linux/cordic.h | 9 +- >> lib/cordic.c | 23 +--- >> 10 files changed, 35 insertions(+), 95 deletions(-) > > I don't see patch 1 in linux-wireless patchwork: > > https://patchwork.kernel.org/project/linux-wireless/list/?series=38033&state=* > > Via which tree are you planning to push these? These could potentially > go via my wireless-drivers-next tree (if review goes ok) but I need to > have all five patches in patchwork. Oh, forgot to mention that please resubmit all five patches, not just patch 1, because then it's easier for me to apply them. https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#resubmit_the_whole_patchset
On 11/5/2018 9:02 AM, Kalle Valo wrote: > Also I don't see MAINTAINERS entry for cordic.[c|h], that would be good > to have as well. We added the cordic library functions during brcm80211 staging cleanup. We can add it to MAINTAINERS file. Regards, Arend
On 11/3/2018 10:59 AM, Priit Laes wrote: > b43 wireless driver included internal implementation of cordic > algorithm which has now been removed in favor of library > implementation. > > During the process, brcmfmac was driver was also cleaned. You actually touched the *brcmsmac* driver, not brcmfmac. Please fix the driver prefix where appropriate in this series, ie. patches 2 and 3. > Please note that this series is only compile-tested, as I > do not have access to the hardware. I can/will verify brcmsmac. As Kalle mentioned it makes more sense to push the 'lib: cordic:' patch through the wireless tree as well as it only is used by wireless drivers right now. Regards, Arend
Arend van Spriel <arend.vanspriel@broadcom.com> writes: > On 11/5/2018 9:02 AM, Kalle Valo wrote: >> Also I don't see MAINTAINERS entry for cordic.[c|h], that would be good >> to have as well. > > We added the cordic library functions during brcm80211 staging > cleanup. We can add it to MAINTAINERS file. Great, thanks.