| Message ID | 003401db8476$348684c0$9d938e40$@onet.pl (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | wifi: mt76: mt7915: fix broken background radar implementation | expand |
diff --git a/drivers/net/wireless/mt76/mt7915/mcu.c b/drivers/net/wireless/mt76/mt7915/mcu.c index 9d790f23..a2bad361 100644 --- a/drivers/net/wireless/mt76/mt7915/mcu.c +++ b/ drivers/net/wireless/mt76/mt7915/mcu.c @@ -2718,8 +2718,8 @@ int mt7915_mcu_rdd_background_enable(str int err, region; if (!chandef) { /* disable offchain */ - err = mt76_connac_mcu_rdd_cmd(&dev->mt76, RDD_STOP, MT_RX_SEL2, - 0, 0); + err = mt76_connac_mcu_rdd_cmd(&dev->mt76, RDD_STOP, 0, + MT_RX_SEL2, 0); if (err) return err;
Currently enabling background radar in hostapd results in unreachable AP. There is because of mistake in enabling background radar implementation for mt7915 mcu driver - 3rd and 4th parameters are swapped. mt76_connac_mcu_rdd_cmd requires rx_sel as a fourth parameter but this parameter is provided as third argument. Fix was tested on mt7981 and background radar works now correctly. Other mt76 drivers do not have similar issues. The issue was also described here: https://github.com/openwrt/mt76/issues/958 Signed-off-by: Lukasz Michalski <lukasz.michalski@onet.pl> --- drivers/net/wireless/mt76/mt7915/mcu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) @@ -2745,8 +2745,8 @@ int mt7915_mcu_rdd_background_enable(str break; } - return mt76_connac_mcu_rdd_cmd(&dev->mt76, RDD_START, MT_RX_SEL2, - 0, region); + return mt76_connac_mcu_rdd_cmd(&dev->mt76, RDD_START, 0, + MT_RX_SEL2, region); } int mt7915_mcu_set_chan_info(struct mt7915_phy *phy, int cmd)