| Message ID | 1248915719-6208-1-git-send-email-lrodriguez@atheros.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Wed, 2009-07-29 at 18:01 -0700, Luis R. Rodriguez wrote: > Since the bss is always set now once we are connected, if the > bss has its own information element we refer to it and pass that > instead of relying on mac80211's parsing. > > Now all cfg80211 drivers get country IE support, automatically. > > Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com> > --- > > Johill, I think this is what you wanted in the end, I tested it and > I get no country IE hint going through :( I could debug further but I'm > done for now and gotta work on some other stuff, not sure when I can > get back to this. Well, you've made a critical mistake: + regulatory_hint_11d(wdev->wiphy, + bss->information_elements, + bss->len_information_elements); needs to be const u8 *country_ie country_ie = ieee80211_bss_get_ie(&bss->pub, WLAN_EID_COUNTRY); if (country_ie) regulatory_hint_11d(wdev->wiphy, country_ie + 2, country_ie[1]); It's rather likely that it doesn't come first, so whatever is in information_elements first would end up not looking like a country IE or having the right length, so the _11d function would just throw it out. johannes
On Thu, Jul 30, 2009 at 12:57 AM, Johannes Berg<johannes@sipsolutions.net> wrote: > On Wed, 2009-07-29 at 18:01 -0700, Luis R. Rodriguez wrote: >> Since the bss is always set now once we are connected, if the >> bss has its own information element we refer to it and pass that >> instead of relying on mac80211's parsing. >> >> Now all cfg80211 drivers get country IE support, automatically. >> >> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com> >> --- >> >> Johill, I think this is what you wanted in the end, I tested it and >> I get no country IE hint going through :( I could debug further but I'm >> done for now and gotta work on some other stuff, not sure when I can >> get back to this. > > Well, you've made a critical mistake: > > + Â Â Â regulatory_hint_11d(wdev->wiphy, > + Â Â Â Â Â Â Â Â Â Â Â Â Â bss->information_elements, > + Â Â Â Â Â Â Â Â Â Â Â Â Â bss->len_information_elements); > > needs to be > > Â Â Â Â const u8 *country_ie > > Â Â Â Â country_ie = ieee80211_bss_get_ie(&bss->pub, WLAN_EID_COUNTRY); > Â Â Â Â if (country_ie) > Â Â Â Â Â Â Â Â regulatory_hint_11d(wdev->wiphy, > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â country_ie + 2, > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â country_ie[1]); > > > It's rather likely that it doesn't come first, so whatever is in > information_elements first would end up not looking like a country IE or > having the right length, so the _11d function would just throw it out. Hah, thanks, will try it. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index e1b9235..fa72997 100644 --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -1514,20 +1514,6 @@ unsigned int cfg80211_classify8021d(struct sk_buff *skb); extern int regulatory_hint(struct wiphy *wiphy, const char *alpha2); /** - * regulatory_hint_11d - hints a country IE as a regulatory domain - * @wiphy: the wireless device giving the hint (used only for reporting - * conflicts) - * @country_ie: pointer to the country IE - * @country_ie_len: length of the country IE - * - * We will intersect the rd with the what CRDA tells us should apply - * for the alpha2 this country IE belongs to, this prevents APs from - * sending us incorrect or outdated information against a country. - */ -extern void regulatory_hint_11d(struct wiphy *wiphy, - u8 *country_ie, - u8 country_ie_len); -/** * wiphy_apply_custom_regulatory - apply a custom driver regulatory domain * @wiphy: the wireless device we want to process the regulatory domain on * @regd: the custom regulatory domain to use for this wiphy diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 0779ba1..5ff1496 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -1846,12 +1846,8 @@ static void ieee80211_rx_mgmt_beacon(struct ieee80211_sub_if_data *sdata, bssid, ap_ht_cap_flags); } + /* Note: country IE parsing is done for us by cfg80211 */ if (elems.country_elem) { - /* Note we are only reviewing this on beacons - * for the BSSID we are associated to */ - regulatory_hint_11d(local->hw.wiphy, - elems.country_elem, elems.country_elem_len); - /* TODO: IBSS also needs this */ if (elems.pwr_constr_elem) ieee80211_handle_pwr_constr(sdata, diff --git a/net/wireless/reg.c b/net/wireless/reg.c index 41c16fc..48158fc 100644 --- a/net/wireless/reg.c +++ b/net/wireless/reg.c @@ -1904,7 +1904,6 @@ free_rd_out: out: spin_unlock(®_lock); } -EXPORT_SYMBOL(regulatory_hint_11d); static bool freq_is_chan_12_13_14(u16 freq) { diff --git a/net/wireless/reg.h b/net/wireless/reg.h index e37829a..662a9da 100644 --- a/net/wireless/reg.h +++ b/net/wireless/reg.h @@ -36,4 +36,19 @@ int regulatory_hint_found_beacon(struct wiphy *wiphy, struct ieee80211_channel *beacon_chan, gfp_t gfp); +/** + * regulatory_hint_11d - hints a country IE as a regulatory domain + * @wiphy: the wireless device giving the hint (used only for reporting + * conflicts) + * @country_ie: pointer to the country IE + * @country_ie_len: length of the country IE + * + * We will intersect the rd with the what CRDA tells us should apply + * for the alpha2 this country IE belongs to, this prevents APs from + * sending us incorrect or outdated information against a country. + */ +void regulatory_hint_11d(struct wiphy *wiphy, + u8 *country_ie, + u8 country_ie_len); + #endif /* __NET_WIRELESS_REG_H */ diff --git a/net/wireless/sme.c b/net/wireless/sme.c index 3728d2b..c332c42 100644 --- a/net/wireless/sme.c +++ b/net/wireless/sme.c @@ -13,6 +13,7 @@ #include <net/cfg80211.h> #include <net/rtnetlink.h> #include "nl80211.h" +#include "reg.h" struct cfg80211_conn { struct cfg80211_connect_params params; @@ -401,6 +402,10 @@ void __cfg80211_connect_result(struct net_device *dev, const u8 *bssid, wdev->sme_state = CFG80211_SME_CONNECTED; cfg80211_upload_connect_keys(wdev); + + regulatory_hint_11d(wdev->wiphy, + bss->information_elements, + bss->len_information_elements); } void cfg80211_connect_result(struct net_device *dev, const u8 *bssid,
Since the bss is always set now once we are connected, if the bss has its own information element we refer to it and pass that instead of relying on mac80211's parsing. Now all cfg80211 drivers get country IE support, automatically. Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com> --- Johill, I think this is what you wanted in the end, I tested it and I get no country IE hint going through :( I could debug further but I'm done for now and gotta work on some other stuff, not sure when I can get back to this. include/net/cfg80211.h | 14 -------------- net/mac80211/mlme.c | 6 +----- net/wireless/reg.c | 1 - net/wireless/reg.h | 15 +++++++++++++++ net/wireless/sme.c | 5 +++++ 5 files changed, 21 insertions(+), 20 deletions(-)