| Message ID | 1250281559-13041-33-git-send-email-lrodriguez@atheros.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri, 2009-08-14 at 16:25 -0400, Luis R. Rodriguez wrote: > We can now remove that comment about mac80211 requiring > cfg80211 and do that for the user. "now"? What changed to make this possible? NAK this change, because with it, it's possible to select mac80211 = Y -> cfg80211 = Y while rfkill = M which will break the kernel build. johannes
On Fri, Aug 14, 2009 at 11:06 PM, Johannes Berg<johannes@sipsolutions.net> wrote: > On Fri, 2009-08-14 at 16:25 -0400, Luis R. Rodriguez wrote: >> We can now remove that comment about mac80211 requiring >> cfg80211 and do that for the user. > > "now"? What changed to make this possible? > > NAK this change, because with it, it's possible to select > mac80211 = Y > -> cfg80211 = Y > while rfkill = M > > which will break the kernel build. > > johannes > Why not make cfg80211 select rfkill?
[please trim your quotes] On Sat, 2009-08-15 at 14:12 +0200, Gábor Stefanik wrote: > > NAK this change, because with it, it's possible to select > > mac80211 = Y > > -> cfg80211 = Y > > while rfkill = M > Why not make cfg80211 select rfkill? Because it doesn't require it. See net/wireless/Kconfig. johannes
On Fri, Aug 14, 2009 at 2:06 PM, Johannes Berg<johannes@sipsolutions.net> wrote: > On Fri, 2009-08-14 at 16:25 -0400, Luis R. Rodriguez wrote: >> We can now remove that comment about mac80211 requiring >> cfg80211 and do that for the user. > > "now"? What changed to make this possible? > > NAK this change, because with it, it's possible to select > mac80211 = Y > -> cfg80211 = Y > while rfkill = M > > which will break the kernel build. I'm able to do this with current kconfig, does this need to be fixed? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2009-08-17 at 10:00 -0700, Luis R. Rodriguez wrote: > On Fri, Aug 14, 2009 at 2:06 PM, Johannes Berg<johannes@sipsolutions.net> wrote: > > On Fri, 2009-08-14 at 16:25 -0400, Luis R. Rodriguez wrote: > >> We can now remove that comment about mac80211 requiring > >> cfg80211 and do that for the user. > > > > "now"? What changed to make this possible? > > > > NAK this change, because with it, it's possible to select > > mac80211 = Y > > -> cfg80211 = Y > > while rfkill = M > > > > which will break the kernel build. > > I'm able to do this with current kconfig, does this need to be fixed? I don't think you can select this with the current config since cfg80211 depends on RFKILL == CFG80211 || RFKILL == n. So you can do CFG80211 = m RFKILL = m CFG80211 = * RFKILL = n CFG80211 = * RFKILL = y but NOT CFG80211 = y RFKILL = m johannes
diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig index d4d3dca..6293b21 100644 --- a/net/mac80211/Kconfig +++ b/net/mac80211/Kconfig @@ -1,6 +1,6 @@ config MAC80211 tristate "mac80211 - SoftMAC device support" - depends on CFG80211 + select CFG80211 select CRYPTO select CRYPTO_ECB select CRYPTO_ARC4 @@ -28,10 +28,6 @@ config MAC80211 When built as a module mac80211 will be built as mac80211.ko, if not sure you should build this as a module. - -comment "CFG80211 needs to be enabled for MAC80211" - depends on CFG80211=n - menu "Rate control algorithm selection" depends on MAC80211 != n
We can now remove that comment about mac80211 requiring cfg80211 and do that for the user. Cc: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com> --- net/mac80211/Kconfig | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-)