| Message ID | 1251406807-31495-14-git-send-email-luciano.coelho@nokia.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri, 2009-08-28 at 00:00 +0300, Luciano Coelho wrote: > Add Juuso as one of the module authors, since he's working heavily on this > module as well. > > Cc: Juuso Oikarinen <juuso.oikarinen@nokia.com> > Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com> > --- > drivers/net/wireless/wl12xx/wl1271_main.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c > index a97d434..4163eac 100644 > --- a/drivers/net/wireless/wl12xx/wl1271_main.c > +++ b/drivers/net/wireless/wl12xx/wl1271_main.c > @@ -1449,4 +1449,5 @@ module_init(wl1271_init); > module_exit(wl1271_exit); > > MODULE_LICENSE("GPL"); > -MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com>"); > +MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com>, " > + "Juuso Oikarinen <juuso.oikarinen@nokia.com>"); Use multiple MODULE_AUTHORs instead. johannes
On Thu, Aug 27, 2009 at 2:32 PM, Johannes Berg<johannes@sipsolutions.net> wrote: > On Fri, 2009-08-28 at 00:00 +0300, Luciano Coelho wrote: >> Add Juuso as one of the module authors, since he's working heavily on this >> module as well. >> >> Cc: Juuso Oikarinen <juuso.oikarinen@nokia.com> >> Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com> >> --- >> Â drivers/net/wireless/wl12xx/wl1271_main.c | Â Â 3 ++- >> Â 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c >> index a97d434..4163eac 100644 >> --- a/drivers/net/wireless/wl12xx/wl1271_main.c >> +++ b/drivers/net/wireless/wl12xx/wl1271_main.c >> @@ -1449,4 +1449,5 @@ module_init(wl1271_init); >> Â module_exit(wl1271_exit); >> >> Â MODULE_LICENSE("GPL"); >> -MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com>"); >> +MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com>, " >> + Â Â Â Â Â "Juuso Oikarinen <juuso.oikarinen@nokia.com>"); > > Use multiple MODULE_AUTHORs instead. Where is that defined? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Aug 27, 2009 at 2:35 PM, Luis R. Rodriguez<mcgrof@gmail.com> wrote: > On Thu, Aug 27, 2009 at 2:32 PM, Johannes Berg<johannes@sipsolutions.net> wrote: >> On Fri, 2009-08-28 at 00:00 +0300, Luciano Coelho wrote: >>> Add Juuso as one of the module authors, since he's working heavily on this >>> module as well. >>> >>> Cc: Juuso Oikarinen <juuso.oikarinen@nokia.com> >>> Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com> >>> --- >>> Â drivers/net/wireless/wl12xx/wl1271_main.c | Â Â 3 ++- >>> Â 1 files changed, 2 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c >>> index a97d434..4163eac 100644 >>> --- a/drivers/net/wireless/wl12xx/wl1271_main.c >>> +++ b/drivers/net/wireless/wl12xx/wl1271_main.c >>> @@ -1449,4 +1449,5 @@ module_init(wl1271_init); >>> Â module_exit(wl1271_exit); >>> >>> Â MODULE_LICENSE("GPL"); >>> -MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com>"); >>> +MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com>, " >>> + Â Â Â Â Â "Juuso Oikarinen <juuso.oikarinen@nokia.com>"); >> >> Use multiple MODULE_AUTHORs instead. > > Where is that defined? Hah nevermind, my mind read MODULE_AUTHORS() :) Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
ext Johannes Berg wrote: > On Fri, 2009-08-28 at 00:00 +0300, Luciano Coelho wrote: > >> Add Juuso as one of the module authors, since he's working heavily on this >> module as well. >> >> Cc: Juuso Oikarinen <juuso.oikarinen@nokia.com> >> Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com> >> --- >> drivers/net/wireless/wl12xx/wl1271_main.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c >> index a97d434..4163eac 100644 >> --- a/drivers/net/wireless/wl12xx/wl1271_main.c >> +++ b/drivers/net/wireless/wl12xx/wl1271_main.c >> @@ -1449,4 +1449,5 @@ module_init(wl1271_init); >> module_exit(wl1271_exit); >> >> MODULE_LICENSE("GPL"); >> -MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com>"); >> +MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com>, " >> + "Juuso Oikarinen <juuso.oikarinen@nokia.com>"); >> > > Use multiple MODULE_AUTHORs instead. > Is that the right way to do it? At least in include/linux/module.h it says this: /* Author, ideally of form NAME[, NAME]*[ and NAME] */ #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author) As I interpret it, it means that there should be one MODULE_AUTHOR with a string that contains all the names. So actually the right way to do it would be this: MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com> and " "Juuso Oikarinen <juuso.oikarinen@nokia.com>"); Or am I missing/misinterpreting something?
On Fri, 2009-08-28 at 12:01 +0300, Luciano Coelho wrote: > Is that the right way to do it? At least in include/linux/module.h it > says this: > > /* Author, ideally of form NAME[, NAME]*[ and NAME] */ > #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author) Interesting, but I suspect that should just be changed. If you use multiple MODULE_AUTHOR, they will be shown as such: $ /sbin/modinfo ar9170usb | grep author author: Christian Lamparter <chunkeey@web.de> author: Johannes Berg <johannes@sipsolutions.net> If you use just one, it would be one long author: line with all of them. I think the multiple line case is much nicer. johannes
ext Johannes Berg wrote: > On Fri, 2009-08-28 at 12:01 +0300, Luciano Coelho wrote: > > >> Is that the right way to do it? At least in include/linux/module.h it >> says this: >> >> /* Author, ideally of form NAME[, NAME]*[ and NAME] */ >> #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author) >> > > Interesting, but I suspect that should just be changed. > > If you use multiple MODULE_AUTHOR, they will be shown as such: > > $ /sbin/modinfo ar9170usb | grep author > author: Christian Lamparter <chunkeey@web.de> > author: Johannes Berg <johannes@sipsolutions.net> > > > If you use just one, it would be one long author: line with all of them. > I think the multiple line case is much nicer. > Yes, I totally agree with you. I'll use multiple MODULE_AUTHOR()s. ;)
diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c index a97d434..4163eac 100644 --- a/drivers/net/wireless/wl12xx/wl1271_main.c +++ b/drivers/net/wireless/wl12xx/wl1271_main.c @@ -1449,4 +1449,5 @@ module_init(wl1271_init); module_exit(wl1271_exit); MODULE_LICENSE("GPL"); -MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com>"); +MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com>, " + "Juuso Oikarinen <juuso.oikarinen@nokia.com>");
Add Juuso as one of the module authors, since he's working heavily on this module as well. Cc: Juuso Oikarinen <juuso.oikarinen@nokia.com> Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com> --- drivers/net/wireless/wl12xx/wl1271_main.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)