| Message ID | 1253775657.3868.8.camel@johannes.local (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Thu, Sep 24, 2009 at 12:00 AM, Johannes Berg <johannes@sipsolutions.net> wrote: > When wpa_supplicant is used to connect to open networks, > it causes the wdev->wext.keys to point to key memory, but > that key memory is all empty. Only use privacy when there > is a default key to be used. > > Signed-off-by: Johannes Berg <johannes@sipsolutions.net> Tested-by: Luis R. Rodriguez <lrodriguez@atheros.com> Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Sep 24, 2009 at 12:00 AM, Johannes Berg <johannes@sipsolutions.net> wrote: > When wpa_supplicant is used to connect to open networks, > it causes the wdev->wext.keys to point to key memory, but > that key memory is all empty. Only use privacy when there > is a default key to be used. > > Signed-off-by: Johannes Berg <johannes@sipsolutions.net> Thanks, this fixes the issue I reported yesterday evening. Tested-by: Kalle Valo <kalle.valo@iki.fi> > Never happened of course with iw ... This is just the reason why I still use stock wpa_supplicant from debian :) Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- wireless-testing.orig/net/wireless/wext-sme.c 2009-09-24 08:51:14.000000000 +0200 +++ wireless-testing/net/wireless/wext-sme.c 2009-09-24 08:57:01.000000000 +0200 @@ -30,7 +30,8 @@ int cfg80211_mgd_wext_connect(struct cfg if (wdev->wext.keys) { wdev->wext.keys->def = wdev->wext.default_key; wdev->wext.keys->defmgmt = wdev->wext.default_mgmt_key; - wdev->wext.connect.privacy = true; + if (wdev->wext.default_key != -1) + wdev->wext.connect.privacy = true; } if (!wdev->wext.connect.ssid_len)
When wpa_supplicant is used to connect to open networks, it causes the wdev->wext.keys to point to key memory, but that key memory is all empty. Only use privacy when there is a default key to be used. Signed-off-by: Johannes Berg <johannes@sipsolutions.net> --- Never happened of course with iw ... net/wireless/wext-sme.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html