diff mbox

ath9k: Fix drain txq failure in flush

Message ID 1303984917-12340-1-git-send-email-rmanoharan@atheros.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Rajkumar Manoharan April 28, 2011, 10:01 a.m. UTC 
While draining the txq in flush, the buffers can be
added into the tx queue by tx_tasklet which leads to
unneccesary chip reset.

This issue was originially found with AR9382 and
running heavy uplink udp traffic with higher bandwidth
and doing frequent bgscan.

Cc: stable@kernel.org
Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Rajkumar Manoharan <rmanoharan@atheros.com>
---
 drivers/net/wireless/ath/ath9k/main.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

Comments

John W. Linville April 29, 2011, 7:27 p.m. UTC | #1 
On Thu, Apr 28, 2011 at 03:31:57PM +0530, Rajkumar Manoharan wrote:
> While draining the txq in flush, the buffers can be
> added into the tx queue by tx_tasklet which leads to
> unneccesary chip reset.
> 
> This issue was originially found with AR9382 and
> running heavy uplink udp traffic with higher bandwidth
> and doing frequent bgscan.
> 
> Cc: stable@kernel.org
> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> Signed-off-by: Rajkumar Manoharan <rmanoharan@atheros.com>

Should this be a fix for 2.6.39?
Rajkumar Manoharan May 2, 2011, 4:34 a.m. UTC | #2 
On Sat, Apr 30, 2011 at 12:57:51AM +0530, John W. Linville wrote:
> On Thu, Apr 28, 2011 at 03:31:57PM +0530, Rajkumar Manoharan wrote:
> > While draining the txq in flush, the buffers can be
> > added into the tx queue by tx_tasklet which leads to
> > unneccesary chip reset.
> > 
> > This issue was originially found with AR9382 and
> > running heavy uplink udp traffic with higher bandwidth
> > and doing frequent bgscan.
> > 
> > Cc: stable@kernel.org
> > Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> > Signed-off-by: Rajkumar Manoharan <rmanoharan@atheros.com>
> 
> Should this be a fix for 2.6.39?
>
Yes. This patch is meant for 2.6.39 only.

--
Rajkumar
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index c3dbf26..efdafd2 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -2261,6 +2261,7 @@  static void ath9k_flush(struct ieee80211_hw *hw, bool drop)
 	struct ath_softc *sc = hw->priv;
 	int timeout = 200; /* ms */
 	int i, j;
+	bool drain_txq;
 
 	mutex_lock(&sc->mutex);
 	cancel_delayed_work_sync(&sc->tx_complete_work);
@@ -2286,7 +2287,10 @@  static void ath9k_flush(struct ieee80211_hw *hw, bool drop)
 	}
 
 	ath9k_ps_wakeup(sc);
-	if (!ath_drain_all_txq(sc, false))
+	spin_lock_bh(&sc->sc_pcu_lock);
+	drain_txq = ath_drain_all_txq(sc, false);
+	spin_unlock_bh(&sc->sc_pcu_lock);
+	if (!drain_txq)
 		ath_reset(sc, false);
 	ath9k_ps_restore(sc);
 	ieee80211_wake_queues(hw);