| Message ID | 1307642840-3043-1-git-send-email-arend@broadcom.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
2011/6/9 Arend van Spriel <arend@broadcom.com>: > In the brcm80211 driver we disable the 80211 core when the driver is > 'down'. The bcma_core_disable() function exactly does the same as > our implementation so exporting this function makes sense. Michael said we should not do do such a exporting without getting users within the same patch serie.
On 06/10/2011 01:40 PM, Rafa? Mi?ecki wrote: > 2011/6/9 Arend van Spriel<arend@broadcom.com>: >> In the brcm80211 driver we disable the 80211 core when the driver is >> 'down'. The bcma_core_disable() function exactly does the same as >> our implementation so exporting this function makes sense. > Michael said we should not do do such a exporting without getting > users within the same patch serie. Hi Rafa?, That is going to be hard for me despite my willingness to comply. Our driver is still in staging so we submit our brcm80211 patches to Greg KH. I figured it would be better to do submit patches for bcma on wireless repository. Gr. AvS
On Fri, 10 Jun 2011 13:46:52 +0200 "Arend van Spriel" <arend@broadcom.com> wrote: > > Michael said we should not do do such a exporting without getting > > users within the same patch serie. > That is going to be hard for me despite my willingness to comply. Our > driver is still in staging so we submit our brcm80211 patches to Greg > KH. I figured it would be better to do submit patches for bcma on > wireless repository. There are no rules without exceptions ;-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 10, 2011 at 01:39:11PM +0000, Michael Büsch wrote: > On Fri, 10 Jun 2011 13:46:52 +0200 > "Arend van Spriel" <arend@broadcom.com> wrote: > > > Michael said we should not do do such a exporting without getting > > > users within the same patch serie. > > That is going to be hard for me despite my willingness to comply. Our > > driver is still in staging so we submit our brcm80211 patches to Greg > > KH. I figured it would be better to do submit patches for bcma on > > wireless repository. > > There are no rules without exceptions ;-) Right, so I don't really mind taking it. OTOH, maybe Greg could just carry the patch in his staging tree...? John
On 06/10/2011 03:40 PM, John W. Linville wrote: > On Fri, Jun 10, 2011 at 01:39:11PM +0000, Michael Büsch wrote: >> On Fri, 10 Jun 2011 13:46:52 +0200 >> "Arend van Spriel"<arend@broadcom.com> wrote: >>>> Michael said we should not do do such a exporting without getting >>>> users within the same patch serie. >>> That is going to be hard for me despite my willingness to comply. Our >>> driver is still in staging so we submit our brcm80211 patches to Greg >>> KH. I figured it would be better to do submit patches for bcma on >>> wireless repository. >> There are no rules without exceptions ;-) > Right, so I don't really mind taking it. OTOH, maybe Greg could just > carry the patch in his staging tree...? > > John Thanks, John I leave it up to Rafa? and Michael to decide. Both ways are fine by me. Gr. AvS
W dniu 10 czerwca 2011 18:29 u?ytkownik Arend van Spriel <arend@broadcom.com> napisa?: > On 06/10/2011 03:40 PM, John W. Linville wrote: >> >> On Fri, Jun 10, 2011 at 01:39:11PM +0000, Michael Büsch wrote: >>> >>> On Fri, 10 Jun 2011 13:46:52 +0200 >>> "Arend van Spriel"<arend@broadcom.com> wrote: >>>>> >>>>> Michael said we should not do do such a exporting without getting >>>>> users within the same patch serie. >>>> >>>> That is going to be hard for me despite my willingness to comply. Our >>>> driver is still in staging so we submit our brcm80211 patches to Greg >>>> KH. I figured it would be better to do submit patches for bcma on >>>> wireless repository. >>> >>> There are no rules without exceptions ;-) >> >> Right, so I don't really mind taking it. OTOH, maybe Greg could just >> carry the patch in his staging tree...? >> >> John > > Thanks, John > > I leave it up to Rafa? and Michael to decide. Both ways are fine by me. Please, take it to wireless tree. I'm going to need this in b43 soon anyway.
diff --git a/drivers/bcma/core.c b/drivers/bcma/core.c index ced379f..1ec7d45 100644 --- a/drivers/bcma/core.c +++ b/drivers/bcma/core.c @@ -19,7 +19,7 @@ bool bcma_core_is_enabled(struct bcma_device *core) } EXPORT_SYMBOL_GPL(bcma_core_is_enabled); -static void bcma_core_disable(struct bcma_device *core, u32 flags) +void bcma_core_disable(struct bcma_device *core, u32 flags) { if (bcma_aread32(core, BCMA_RESET_CTL) & BCMA_RESET_CTL_RESET) return; @@ -31,6 +31,7 @@ static void bcma_core_disable(struct bcma_device *core, u32 flags) bcma_awrite32(core, BCMA_RESET_CTL, BCMA_RESET_CTL_RESET); udelay(1); } +EXPORT_SYMBOL_GPL(bcma_core_disable); int bcma_core_enable(struct bcma_device *core, u32 flags) { diff --git a/include/linux/bcma/bcma.h b/include/linux/bcma/bcma.h index 6ff080e..3895aeb 100644 --- a/include/linux/bcma/bcma.h +++ b/include/linux/bcma/bcma.h @@ -244,6 +244,7 @@ void bcma_awrite32(struct bcma_device *core, u16 offset, u32 value) } extern bool bcma_core_is_enabled(struct bcma_device *core); +extern void bcma_core_disable(struct bcma_device *core, u32 flags); extern int bcma_core_enable(struct bcma_device *core, u32 flags); #endif /* LINUX_BCMA_H_ */
In the brcm80211 driver we disable the 80211 core when the driver is 'down'. The bcma_core_disable() function exactly does the same as our implementation so exporting this function makes sense. Cc: linux-wireless@vger.kernel.org Cc: Rafal Milecki <zajec5@gmail.com> Signed-off-by: Arend van Spriel <arend@broadcom.com> --- drivers/bcma/core.c | 3 ++- include/linux/bcma/bcma.h | 1 + 2 files changed, 3 insertions(+), 1 deletions(-)