diff mbox

ath5k: set hw mfp capable flag for secured mesh

Message ID 1345778993-23033-1-git-send-email-yeohchunyeow@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Chun-Yeow Yeoh Aug. 24, 2012, 3:29 a.m. UTC
The IEEE80211_HW_MFP_CAPABLE is required to ensure the
successful key installation of CIPHER_AES_CMAC (currently
done in software) for secured mesh.

Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
---
 drivers/net/wireless/ath/ath5k/base.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Johannes Berg Aug. 24, 2012, 6:55 a.m. UTC | #1
On Fri, 2012-08-24 at 11:29 +0800, Chun-Yeow Yeoh wrote:
> The IEEE80211_HW_MFP_CAPABLE is required to ensure the
> successful key installation of CIPHER_AES_CMAC (currently
> done in software) for secured mesh.

You shouldn't blindly set the flag though because it "is required". You
really need to test that management frames aren't decrypted by the
hardware erroneously.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Chun-Yeow Yeoh Aug. 24, 2012, 10:07 a.m. UTC | #2
> You shouldn't blindly set the flag though because it "is required". You
> really need to test that management frames aren't decrypted by the
> hardware erroneously.

Noted. Will take a look on alternative solution for this.

--
Chun-Yeow
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index a0a202d..4605fe1 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -2446,7 +2446,8 @@  ath5k_init_ah(struct ath5k_hw *ah, const struct ath_bus_ops *bus_ops)
 	hw->flags = IEEE80211_HW_RX_INCLUDES_FCS |
 			IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
 			IEEE80211_HW_SIGNAL_DBM |
-			IEEE80211_HW_REPORTS_TX_ACK_STATUS;
+			IEEE80211_HW_REPORTS_TX_ACK_STATUS |
+			IEEE80211_HW_MFP_CAPABLE;
 
 	hw->wiphy->interface_modes =
 		BIT(NL80211_IFTYPE_AP) |