diff mbox

wext: include wireless event id when it has a size problem

Message ID 1345812212-18778-1-git-send-email-arend@broadcom.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Arend van Spriel Aug. 24, 2012, 12:43 p.m. UTC 
The wext code checks is the event data is within size limits.
When this check fails a message is logged with violating size.
This patch adds the event id to put us on the right track for
resolving that violation.

Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
---
Maybe wext is not popular, but I found the change helpful debugging
so others may benefit from it. Still some wireless apps default to
it, eg. wpa_supplicant.

Gr. AvS
---
 net/wireless/wext-core.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Johannes Berg Sept. 5, 2012, 2:13 p.m. UTC | #1 
On Fri, 2012-08-24 at 14:43 +0200, Arend van Spriel wrote:
> The wext code checks is the event data is within size limits.
> When this check fails a message is logged with violating size.
> This patch adds the event id to put us on the right track for
> resolving that violation.
> 
> Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> ---
> Maybe wext is not popular, but I found the change helpful debugging
> so others may benefit from it. Still some wireless apps default to
> it, eg. wpa_supplicant.

I don't even want to know what you're debugging, but I applied it
anyway.

FWIW, wext isn't just "not popular", it's "pretty much dead" :-)

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Arend van Spriel Sept. 5, 2012, 4:21 p.m. UTC | #2 
On 09/05/2012 04:13 PM, Johannes Berg wrote:
> On Fri, 2012-08-24 at 14:43 +0200, Arend van Spriel wrote:
>> The wext code checks is the event data is within size limits.
>> When this check fails a message is logged with violating size.
>> This patch adds the event id to put us on the right track for
>> resolving that violation.
>>
>> Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
>> Signed-off-by: Arend van Spriel <arend@broadcom.com>
>> ---
>> Maybe wext is not popular, but I found the change helpful debugging
>> so others may benefit from it. Still some wireless apps default to
>> it, eg. wpa_supplicant.
>
> I don't even want to know what you're debugging, but I applied it
> anyway.
>
> FWIW, wext isn't just "not popular", it's "pretty much dead" :-)
>
> johannes
>
>

We got the "Wireless Event too big" message and were wondering what 
event from our driver was causing it. I agree wext is pretty much dead 
although wpa_supplicant still defaults to that driver. At least in most 
distro's it seems to be so.

Gr. AvS

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/wireless/wext-core.c b/net/wireless/wext-core.c
index b0eb7aa..c8717c1 100644
--- a/net/wireless/wext-core.c
+++ b/net/wireless/wext-core.c
@@ -478,13 +478,13 @@  void wireless_send_event(struct net_device *	dev,
 	if (descr->header_type == IW_HEADER_TYPE_POINT) {
 		/* Check if number of token fits within bounds */
 		if (wrqu->data.length > descr->max_tokens) {
-			netdev_err(dev, "(WE) : Wireless Event too big (%d)\n",
-				   wrqu->data.length);
+			netdev_err(dev, "(WE) : Wireless Event (cmd=0x%04X) too big (%d)\n",
+				   cmd, wrqu->data.length);
 			return;
 		}
 		if (wrqu->data.length < descr->min_tokens) {
-			netdev_err(dev, "(WE) : Wireless Event too small (%d)\n",
-				   wrqu->data.length);
+			netdev_err(dev, "(WE) : Wireless Event (cmd=0x%04X) too small (%d)\n",
+				   cmd, wrqu->data.length);
 			return;
 		}
 		/* Calculate extra_len - extra is NULL for restricted events */