diff mbox

bcma: export PLL reading function

Message ID 1347483216-2309-1-git-send-email-zajec5@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Rafał Miłecki Sept. 12, 2012, 8:53 p.m. UTC
This is required by NAND flash driver for initializing wait counters.

Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
---
To see usage, take a look at
[PATCH 2/4] mtd: bcm47xxnflash: init NAND on BCM4706
(it is ML posted patch only, not included in any tree yet)
---
 drivers/bcma/driver_chipcommon_pmu.c |    3 ++-
 include/linux/bcma/bcma.h            |    1 +
 2 files changed, 3 insertions(+), 1 deletions(-)

Comments

Rafał Miłecki Sept. 21, 2012, 8:27 a.m. UTC | #1
2012/9/12 Rafa? Mi?ecki <zajec5@gmail.com>:
> This is required by NAND flash driver for initializing wait counters.

John: have you take a look at this patch? Can you take it or would you
prefer it to be submitted together with NAND driver (using different
than wireless tree)?
John W. Linville Sept. 24, 2012, 6:54 p.m. UTC | #2
On Fri, Sep 21, 2012 at 10:27:51AM +0200, Rafa? Mi?ecki wrote:
> 2012/9/12 Rafa? Mi?ecki <zajec5@gmail.com>:
> > This is required by NAND flash driver for initializing wait counters.
> 
> John: have you take a look at this patch? Can you take it or would you
> prefer it to be submitted together with NAND driver (using different
> than wireless tree)?

I think you should just send it as part of a series with the driver
that makes use of it.

Thanks,

John
Rafał Miłecki Sept. 24, 2012, 7:58 p.m. UTC | #3
2012/9/24 John W. Linville <linville@tuxdriver.com>:
> On Fri, Sep 21, 2012 at 10:27:51AM +0200, Rafa? Mi?ecki wrote:
>> 2012/9/12 Rafa? Mi?ecki <zajec5@gmail.com>:
>> > This is required by NAND flash driver for initializing wait counters.
>>
>> John: have you take a look at this patch? Can you take it or would you
>> prefer it to be submitted together with NAND driver (using different
>> than wireless tree)?
>
> I think you should just send it as part of a series with the driver
> that makes use of it.

OK, drop it :)
diff mbox

Patch

diff --git a/drivers/bcma/driver_chipcommon_pmu.c b/drivers/bcma/driver_chipcommon_pmu.c
index 8b8f2f3..c7d94b47 100644
--- a/drivers/bcma/driver_chipcommon_pmu.c
+++ b/drivers/bcma/driver_chipcommon_pmu.c
@@ -13,12 +13,13 @@ 
 #include <linux/export.h>
 #include <linux/bcma/bcma.h>
 
-static u32 bcma_chipco_pll_read(struct bcma_drv_cc *cc, u32 offset)
+u32 bcma_chipco_pll_read(struct bcma_drv_cc *cc, u32 offset)
 {
 	bcma_cc_write32(cc, BCMA_CC_PLLCTL_ADDR, offset);
 	bcma_cc_read32(cc, BCMA_CC_PLLCTL_ADDR);
 	return bcma_cc_read32(cc, BCMA_CC_PLLCTL_DATA);
 }
+EXPORT_SYMBOL_GPL(bcma_chipco_pll_read);
 
 void bcma_chipco_pll_write(struct bcma_drv_cc *cc, u32 offset, u32 value)
 {
diff --git a/include/linux/bcma/bcma.h b/include/linux/bcma/bcma.h
index 1954a4e..b58fae0 100644
--- a/include/linux/bcma/bcma.h
+++ b/include/linux/bcma/bcma.h
@@ -345,6 +345,7 @@  extern void bcma_core_set_clockmode(struct bcma_device *core,
 				    enum bcma_clkmode clkmode);
 extern void bcma_core_pll_ctl(struct bcma_device *core, u32 req, u32 status,
 			      bool on);
+extern u32 bcma_chipco_pll_read(struct bcma_drv_cc *cc, u32 offset);
 #define BCMA_DMA_TRANSLATION_MASK	0xC0000000
 #define  BCMA_DMA_TRANSLATION_NONE	0x00000000
 #define  BCMA_DMA_TRANSLATION_DMA32_CMT	0x40000000 /* Client Mode Translation for 32-bit DMA */