diff mbox

ipw2x00: silence GCC warning for unused variable 'dev'

Message ID 1348221722.1581.12.camel@x61.thuisdomein (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Paul Bolle Sept. 21, 2012, 10:02 a.m. UTC
Building the libipw component without CONFIG_LIBIPW_DEBUG set triggers this GCC
warning:
    drivers/net/wireless/ipw2x00/libipw_wx.c:526:21: warning: unused variable 'dev' [-Wunused-variable]

The cause of this warning is that, without CONFIG_LIBIPW_DEBUG set,
LIBIPW_DEBUG_WX compiles away. Fix it by substituting ieee->dev for (its
equivalent) dev.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) I noticed this warning while building v3.6-rc6 on current Fedora 17,
using Fedora's default config.

1) Compile tested only (by just compiling libipw_wx.o).

 drivers/net/wireless/ipw2x00/libipw_wx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stanislav Yakovlev Sept. 24, 2012, 12:26 a.m. UTC | #1
Hello Paul,

On 21 September 2012 14:02, Paul Bolle <pebolle@tiscali.nl> wrote:
> Building the libipw component without CONFIG_LIBIPW_DEBUG set triggers this GCC
> warning:
>     drivers/net/wireless/ipw2x00/libipw_wx.c:526:21: warning: unused variable 'dev' [-Wunused-variable]
>
> The cause of this warning is that, without CONFIG_LIBIPW_DEBUG set,
> LIBIPW_DEBUG_WX compiles away. Fix it by substituting ieee->dev for (its
> equivalent) dev.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) I noticed this warning while building v3.6-rc6 on current Fedora 17,
> using Fedora's default config.
>
> 1) Compile tested only (by just compiling libipw_wx.o).
>
>  drivers/net/wireless/ipw2x00/libipw_wx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks fine, thanks.

Stanislav.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/ipw2x00/libipw_wx.c b/drivers/net/wireless/ipw2x00/libipw_wx.c
index 1571505..54aba47 100644
--- a/drivers/net/wireless/ipw2x00/libipw_wx.c
+++ b/drivers/net/wireless/ipw2x00/libipw_wx.c
@@ -675,7 +675,7 @@  int libipw_wx_set_encodeext(struct libipw_device *ieee,
 	}
       done:
 	if (ieee->set_security)
-		ieee->set_security(ieee->dev, &sec);
+		ieee->set_security(dev, &sec);
 
 	return ret;
 }