diff mbox

[1/3] regulatory: allow VHT channels in world roaming

Message ID 1360797364-9430-2-git-send-email-johannes@sipsolutions.net (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Johannes Berg Feb. 13, 2013, 11:16 p.m. UTC
From: Johannes Berg <johannes.berg@intel.com>

For VHT, the wider bandwidths (up to 160 MHz) need
to be allowed. Since world roaming only covers the
case of connecting to an AP, it can be opened up
there, we will rely on the AP to know the local
regulations.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 net/wireless/reg.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Luis R. Rodriguez Feb. 28, 2013, 11:33 p.m. UTC | #1
On Wed, Feb 13, 2013 at 3:16 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> For VHT, the wider bandwidths (up to 160 MHz) need
> to be allowed. Since world roaming only covers the
> case of connecting to an AP, it can be opened up
> there, we will rely on the AP to know the local
> regulations.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

This seems reasonable to me but in your patch you only allow 80, not
160, any reason for that? Michael, any thoughts, this would just be
for passive scan, STA only, we'd rely on the AP existing and having
such configuration.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Johannes Berg Feb. 28, 2013, 11:56 p.m. UTC | #2
On Thu, 2013-02-28 at 15:33 -0800, Luis R. Rodriguez wrote:

> > For VHT, the wider bandwidths (up to 160 MHz) need
> > to be allowed. Since world roaming only covers the
> > case of connecting to an AP, it can be opened up
> > there, we will rely on the AP to know the local
> > regulations.

> This seems reasonable to me but in your patch you only allow 80, not
> 160, any reason for that?

160 doesn't fit here yet -- I think it should be enabled when/if those
DFS channels are added, I don't see a reason they're missing there.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Luis R. Rodriguez March 4, 2013, 7:19 p.m. UTC | #3
On Thu, Feb 28, 2013 at 3:56 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Thu, 2013-02-28 at 15:33 -0800, Luis R. Rodriguez wrote:
>
>> > For VHT, the wider bandwidths (up to 160 MHz) need
>> > to be allowed. Since world roaming only covers the
>> > case of connecting to an AP, it can be opened up
>> > there, we will rely on the AP to know the local
>> > regulations.
>
>> This seems reasonable to me but in your patch you only allow 80, not
>> 160, any reason for that?
>
> 160 doesn't fit here yet -- I think it should be enabled when/if those
> DFS channels are added, I don't see a reason they're missing there.

True. OK I checked internally and enabling VHT80 is reasonable, as for
the DFS stuff you mentioned, you are right as well, but that should be
done through a separate patch. The only thing to consider there is
scan time increases considerably but seems like a reasonable
compromise. I'm surprised no one has had issues before with this.

Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Johannes Berg March 4, 2013, 7:52 p.m. UTC | #4
On Mon, 2013-03-04 at 11:19 -0800, Luis R. Rodriguez wrote:
> On Thu, Feb 28, 2013 at 3:56 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Thu, 2013-02-28 at 15:33 -0800, Luis R. Rodriguez wrote:
> >
> >> > For VHT, the wider bandwidths (up to 160 MHz) need
> >> > to be allowed. Since world roaming only covers the
> >> > case of connecting to an AP, it can be opened up
> >> > there, we will rely on the AP to know the local
> >> > regulations.
> >
> >> This seems reasonable to me but in your patch you only allow 80, not
> >> 160, any reason for that?
> >
> > 160 doesn't fit here yet -- I think it should be enabled when/if those
> > DFS channels are added, I don't see a reason they're missing there.
> 
> True. OK I checked internally and enabling VHT80 is reasonable, as for
> the DFS stuff you mentioned, you are right as well, but that should be
> done through a separate patch. The only thing to consider there is
> scan time increases considerably but seems like a reasonable
> compromise. I'm surprised no one has had issues before with this.
> 
> Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>

Ok, applied the patch then. I'll send a patch for those DFS channels
momentarily, care to take of db.txt?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index e97d5b0..bf35e1f 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -184,14 +184,14 @@  static const struct ieee80211_regdomain world_regdom = {
 			NL80211_RRF_NO_IBSS |
 			NL80211_RRF_NO_OFDM),
 		/* IEEE 802.11a, channel 36..48 */
-		REG_RULE(5180-10, 5240+10, 40, 6, 20,
+		REG_RULE(5180-10, 5240+10, 80, 6, 20,
                         NL80211_RRF_PASSIVE_SCAN |
                         NL80211_RRF_NO_IBSS),
 
-		/* NB: 5260 MHz - 5700 MHz requies DFS */
+		/* NB: 5260 MHz - 5700 MHz requires DFS */
 
 		/* IEEE 802.11a, channel 149..165 */
-		REG_RULE(5745-10, 5825+10, 40, 6, 20,
+		REG_RULE(5745-10, 5825+10, 80, 6, 20,
 			NL80211_RRF_PASSIVE_SCAN |
 			NL80211_RRF_NO_IBSS),