| Message ID | 1361267868-2316-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Tue, 2013-02-19 at 15:27 +0530, Sachin Kamat wrote: > 'rfkill_regulator_ops' is used only in this file. Hence make it static. > Silences the following warning: > net/rfkill/rfkill-regulator.c:54:19: warning: > symbol 'rfkill_regulator_ops' was not declared. Should it be static? I'll take this, but it isn't going anywhere until the merge window opens again. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2013-02-20 at 11:08 +0100, Johannes Berg wrote: > On Tue, 2013-02-19 at 15:27 +0530, Sachin Kamat wrote: > > 'rfkill_regulator_ops' is used only in this file. Hence make it static. > > Silences the following warning: > > net/rfkill/rfkill-regulator.c:54:19: warning: > > symbol 'rfkill_regulator_ops' was not declared. Should it be static? > > I'll take this, but it isn't going anywhere until the merge window opens > again. Err, I mean closes, and we open -next. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/rfkill/rfkill-regulator.c b/net/rfkill/rfkill-regulator.c index 4b5ab21..d11ac79 100644 --- a/net/rfkill/rfkill-regulator.c +++ b/net/rfkill/rfkill-regulator.c @@ -51,7 +51,7 @@ static int rfkill_regulator_set_block(void *data, bool blocked) return 0; } -struct rfkill_ops rfkill_regulator_ops = { +static struct rfkill_ops rfkill_regulator_ops = { .set_block = rfkill_regulator_set_block, };
'rfkill_regulator_ops' is used only in this file. Hence make it static. Silences the following warning: net/rfkill/rfkill-regulator.c:54:19: warning: symbol 'rfkill_regulator_ops' was not declared. Should it be static? Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- net/rfkill/rfkill-regulator.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)