| Message ID | 1370419185-3977-1-git-send-email-arend@broadcom.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
"Arend van Spriel" <arend@broadcom.com> writes: > This patch fixes a regression introduced by: > > commit 6da3b6c48d79da96a36c2632053cf4f53bf48fb2 > Author: Hauke Mehrtens <hauke@hauke-m.de> > Date: Sun Mar 24 01:45:52 2013 +0100 > > brcmsmac: remove brcms_bss_cfg->associated > > The regression behaviour is described in: > > http://www.spinics.net/lists/linux-wireless/msg107474.html The link is not a very reliable reference, it can die anytime and there's no way to know what message it refers to. Stating the message id would better. And the best would be to copy the full text to the commit log, it's only few lines anyway.
Kalle Valo <kvalo@adurom.com> writes: > "Arend van Spriel" <arend@broadcom.com> writes: > >> This patch fixes a regression introduced by: >> >> commit 6da3b6c48d79da96a36c2632053cf4f53bf48fb2 >> Author: Hauke Mehrtens <hauke@hauke-m.de> >> Date: Sun Mar 24 01:45:52 2013 +0100 >> >> brcmsmac: remove brcms_bss_cfg->associated >> >> The regression behaviour is described in: >> >> http://www.spinics.net/lists/linux-wireless/msg107474.html > > The link is not a very reliable reference, it can die anytime and > there's no way to know what message it refers to. Stating the message id > would better. And the best would be to copy the full text to the commit > log, it's only few lines anyway. Johannes gave a handy tip. Gmane has a service which uses message ids: http://mid.gmane.org/5197DC4F.7030503@broadcom.com If the link or service dies, one can find the email with the message id visible from the link.
On 06/05/2013 10:44 AM, Kalle Valo wrote: > Kalle Valo <kvalo@adurom.com> writes: > >> "Arend van Spriel" <arend@broadcom.com> writes: >> >>> This patch fixes a regression introduced by: >>> >>> commit 6da3b6c48d79da96a36c2632053cf4f53bf48fb2 >>> Author: Hauke Mehrtens <hauke@hauke-m.de> >>> Date: Sun Mar 24 01:45:52 2013 +0100 >>> >>> brcmsmac: remove brcms_bss_cfg->associated >>> >>> The regression behaviour is described in: >>> >>> http://www.spinics.net/lists/linux-wireless/msg107474.html >> >> The link is not a very reliable reference, it can die anytime and >> there's no way to know what message it refers to. Stating the message id >> would better. And the best would be to copy the full text to the commit >> log, it's only few lines anyway. > > Johannes gave a handy tip. Gmane has a service which uses message ids: > > http://mid.gmane.org/5197DC4F.7030503@broadcom.com > > If the link or service dies, one can find the email with the message id > visible from the link. > What if gmane dies ;-) Gr. AvS -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/05/2013 10:46 AM, Arend van Spriel wrote: > On 06/05/2013 10:44 AM, Kalle Valo wrote: >> Kalle Valo <kvalo@adurom.com> writes: >> >>> "Arend van Spriel" <arend@broadcom.com> writes: >>> >>>> This patch fixes a regression introduced by: >>>> >>>> commit 6da3b6c48d79da96a36c2632053cf4f53bf48fb2 >>>> Author: Hauke Mehrtens <hauke@hauke-m.de> >>>> Date: Sun Mar 24 01:45:52 2013 +0100 >>>> >>>> brcmsmac: remove brcms_bss_cfg->associated >>>> >>>> The regression behaviour is described in: >>>> >>>> http://www.spinics.net/lists/linux-wireless/msg107474.html >>> >>> The link is not a very reliable reference, it can die anytime and >>> there's no way to know what message it refers to. Stating the message id >>> would better. And the best would be to copy the full text to the commit >>> log, it's only few lines anyway. >> >> Johannes gave a handy tip. Gmane has a service which uses message ids: >> >> http://mid.gmane.org/5197DC4F.7030503@broadcom.com >> >> If the link or service dies, one can find the email with the message id >> visible from the link. >> > > What if gmane dies ;-) > > Gr. AvS There is also a bugzilla entry for this bug: https://bugzilla.kernel.org/show_bug.cgi?id=58471 Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
"Arend van Spriel" <arend@broadcom.com> writes: > On 06/05/2013 10:44 AM, Kalle Valo wrote: >> Kalle Valo <kvalo@adurom.com> writes: >> >>> "Arend van Spriel" <arend@broadcom.com> writes: >>> >>>> This patch fixes a regression introduced by: >>>> >>>> commit 6da3b6c48d79da96a36c2632053cf4f53bf48fb2 >>>> Author: Hauke Mehrtens <hauke@hauke-m.de> >>>> Date: Sun Mar 24 01:45:52 2013 +0100 >>>> >>>> brcmsmac: remove brcms_bss_cfg->associated >>>> >>>> The regression behaviour is described in: >>>> >>>> http://www.spinics.net/lists/linux-wireless/msg107474.html >>> >>> The link is not a very reliable reference, it can die anytime and >>> there's no way to know what message it refers to. Stating the message id >>> would better. And the best would be to copy the full text to the commit >>> log, it's only few lines anyway. >> >> Johannes gave a handy tip. Gmane has a service which uses message ids: >> >> http://mid.gmane.org/5197DC4F.7030503@broadcom.com >> >> If the link or service dies, one can find the email with the message id >> visible from the link. >> > > What if gmane dies ;-) You missed my point. If gmane dies you do this: http://lmgtfy.com/?q=5197DC4F.7030503%40broadcom.com :D The id above is the real message id from the email, that's why you can use it to search from email archives, google and so on.
On Wed, Jun 05, 2013 at 02:09:47PM +0300, Kalle Valo wrote: > "Arend van Spriel" <arend@broadcom.com> writes: > > > On 06/05/2013 10:44 AM, Kalle Valo wrote: > >> Kalle Valo <kvalo@adurom.com> writes: > >> > >>> "Arend van Spriel" <arend@broadcom.com> writes: > >>> > >>>> This patch fixes a regression introduced by: > >>>> > >>>> commit 6da3b6c48d79da96a36c2632053cf4f53bf48fb2 > >>>> Author: Hauke Mehrtens <hauke@hauke-m.de> > >>>> Date: Sun Mar 24 01:45:52 2013 +0100 > >>>> > >>>> brcmsmac: remove brcms_bss_cfg->associated > >>>> > >>>> The regression behaviour is described in: > >>>> > >>>> http://www.spinics.net/lists/linux-wireless/msg107474.html > >>> > >>> The link is not a very reliable reference, it can die anytime and > >>> there's no way to know what message it refers to. Stating the message id > >>> would better. And the best would be to copy the full text to the commit > >>> log, it's only few lines anyway. > >> > >> Johannes gave a handy tip. Gmane has a service which uses message ids: > >> > >> http://mid.gmane.org/5197DC4F.7030503@broadcom.com > >> > >> If the link or service dies, one can find the email with the message id > >> visible from the link. > >> > > > > What if gmane dies ;-) > > You missed my point. If gmane dies you do this: > > http://lmgtfy.com/?q=5197DC4F.7030503%40broadcom.com > > :D > > The id above is the real message id from the email, that's why you can > use it to search from email archives, google and so on. Would it be too hard to copy the text in the commit message? :-) Why should somebody jump here and there just to get the description of a bug? Imho, at least a short description should appear here. In this way also David can immediately figure out what the problem is, without jumping on the web (imagine many of this in one pull request) :-) my 2 cents. Cheers,
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c index 28e7aee..9fd6f2f 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c @@ -3074,21 +3074,8 @@ static void brcms_b_antsel_set(struct brcms_hardware *wlc_hw, u32 antsel_avail) */ static bool brcms_c_ps_allowed(struct brcms_c_info *wlc) { - /* disallow PS when one of the following global conditions meets */ - if (!wlc->pub->associated) - return false; - - /* disallow PS when one of these meets when not scanning */ - if (wlc->filter_flags & FIF_PROMISC_IN_BSS) - return false; - - if (wlc->bsscfg->type == BRCMS_TYPE_AP) - return false; - - if (wlc->bsscfg->type == BRCMS_TYPE_ADHOC) - return false; - - return true; + /* not supporting PS so always return false for now */ + return false; } static void brcms_c_statsupd(struct brcms_c_info *wlc)
This patch fixes a regression introduced by: commit 6da3b6c48d79da96a36c2632053cf4f53bf48fb2 Author: Hauke Mehrtens <hauke@hauke-m.de> Date: Sun Mar 24 01:45:52 2013 +0100 brcmsmac: remove brcms_bss_cfg->associated The regression behaviour is described in: http://www.spinics.net/lists/linux-wireless/msg107474.html Before the mentioned commit the return value of the function brcms_c_ps_allowed() was always false, which is desired behaviour as power-save is not supported at the moment. Therefor, the function is changed to just return false instead of simply reverting the mentioned commit. Signed-off-by: Arend van Spriel <arend@broadcom.com> --- Sorry, John Hope the revised commit message has all the needed information now. Without this patch brcmsmac is useless for anyone using it in station mode. Gr. AvS --- drivers/net/wireless/brcm80211/brcmsmac/main.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-)